* Re: [dpdk-dev] [PATCH v2] sched : Initialize tc ov watermark.
2021-03-09 16:10 ` [dpdk-dev] [PATCH v2] " Savinay Dharmappa
@ 2021-03-10 16:53 ` Singh, Jasvinder
2021-03-15 16:42 ` Coyle, David
` (2 subsequent siblings)
3 siblings, 0 replies; 11+ messages in thread
From: Singh, Jasvinder @ 2021-03-10 16:53 UTC (permalink / raw)
To: Dharmappa, Savinay, Dumitrescu, Cristian, dev
> -----Original Message-----
> From: Dharmappa, Savinay <savinay.dharmappa@intel.com>
> Sent: Tuesday, March 9, 2021 4:10 PM
> To: Singh, Jasvinder <jasvinder.singh@intel.com>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>; dev@dpdk.org
> Cc: Dharmappa, Savinay <savinay.dharmappa@intel.com>
> Subject: [PATCH v2] sched : Initialize tc ov watermark.
>
> tc ov watermark is initialized with computed value of max tc ov watermark.
>
> Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com>
> ---
> v2: fix spelling error.
> ---
> lib/librte_sched/rte_sched.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c index
> 7c56880681..cd87e688e4 100644
> --- a/lib/librte_sched/rte_sched.c
> +++ b/lib/librte_sched/rte_sched.c
> @@ -1249,7 +1249,6 @@ rte_sched_subport_config(struct rte_sched_port
> *port, #ifdef RTE_SCHED_SUBPORT_TC_OV
> /* TC oversubscription */
> s->tc_ov_wm_min = port->mtu;
> - s->tc_ov_wm = s->tc_ov_wm_max;
> s->tc_ov_period_id = 0;
> s->tc_ov = 0;
> s->tc_ov_n = 0;
> @@ -1277,6 +1276,7 @@ rte_sched_subport_config(struct rte_sched_port
> *port, #ifdef RTE_SCHED_SUBPORT_TC_OV
> s->tc_ov_wm_max = rte_sched_time_ms_to_bytes(profile-
> >tc_period,
> s-
> >pipe_tc_be_rate_max);
> + s->tc_ov_wm = s->tc_ov_wm_max;
> #endif
> s->profile = subport_profile_id;
>
> --
> 2.17.1
Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [dpdk-dev] [PATCH v2] sched : Initialize tc ov watermark.
2021-03-09 16:10 ` [dpdk-dev] [PATCH v2] " Savinay Dharmappa
2021-03-10 16:53 ` Singh, Jasvinder
@ 2021-03-15 16:42 ` Coyle, David
2021-03-23 16:02 ` Thomas Monjalon
2021-04-21 6:50 ` [dpdk-dev] [PATCH v3] sched : fix traffic class oversubscription parameter Savinay Dharmappa
3 siblings, 0 replies; 11+ messages in thread
From: Coyle, David @ 2021-03-15 16:42 UTC (permalink / raw)
To: Dharmappa, Savinay, Singh, Jasvinder, Dumitrescu, Cristian, dev
Cc: Dharmappa, Savinay
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Savinay Dharmappa
> Sent: Tuesday, March 9, 2021 4:10 PM
> To: Singh, Jasvinder <jasvinder.singh@intel.com>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>; dev@dpdk.org
> Cc: Dharmappa, Savinay <savinay.dharmappa@intel.com>
> Subject: [dpdk-dev] [PATCH v2] sched : Initialize tc ov watermark.
>
> tc ov watermark is initialized with computed value of max tc ov watermark.
>
> Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com>
> ---
> v2: fix spelling error.
> ---
> lib/librte_sched/rte_sched.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Tested-by: David Coyle <david.coyle@intel.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [PATCH v2] sched : Initialize tc ov watermark.
2021-03-09 16:10 ` [dpdk-dev] [PATCH v2] " Savinay Dharmappa
2021-03-10 16:53 ` Singh, Jasvinder
2021-03-15 16:42 ` Coyle, David
@ 2021-03-23 16:02 ` Thomas Monjalon
2021-04-20 10:13 ` Thomas Monjalon
2021-04-21 6:50 ` [dpdk-dev] [PATCH v3] sched : fix traffic class oversubscription parameter Savinay Dharmappa
3 siblings, 1 reply; 11+ messages in thread
From: Thomas Monjalon @ 2021-03-23 16:02 UTC (permalink / raw)
To: Savinay Dharmappa; +Cc: jasvinder.singh, cristian.dumitrescu, dev
09/03/2021 17:10, Savinay Dharmappa:
> tc ov watermark is initialized with computed value of
> max tc ov watermark.
Sorry I don't understand what the change is doing.
Was there an issue?
In the title, please avoid "tc ov" which is meaningless
for most of readers I guess.
> --- a/lib/librte_sched/rte_sched.c
> +++ b/lib/librte_sched/rte_sched.c
> - s->tc_ov_wm = s->tc_ov_wm_max;
[...]
> + s->tc_ov_wm = s->tc_ov_wm_max;
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [PATCH v2] sched : Initialize tc ov watermark.
2021-03-23 16:02 ` Thomas Monjalon
@ 2021-04-20 10:13 ` Thomas Monjalon
2021-04-20 10:36 ` Singh, Jasvinder
0 siblings, 1 reply; 11+ messages in thread
From: Thomas Monjalon @ 2021-04-20 10:13 UTC (permalink / raw)
To: Savinay Dharmappa, jasvinder.singh, cristian.dumitrescu; +Cc: dev, dev
Ping
23/03/2021 17:02, Thomas Monjalon:
> 09/03/2021 17:10, Savinay Dharmappa:
> > tc ov watermark is initialized with computed value of
> > max tc ov watermark.
>
> Sorry I don't understand what the change is doing.
> Was there an issue?
>
> In the title, please avoid "tc ov" which is meaningless
> for most of readers I guess.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [PATCH v2] sched : Initialize tc ov watermark.
2021-04-20 10:13 ` Thomas Monjalon
@ 2021-04-20 10:36 ` Singh, Jasvinder
2021-04-20 13:54 ` Thomas Monjalon
0 siblings, 1 reply; 11+ messages in thread
From: Singh, Jasvinder @ 2021-04-20 10:36 UTC (permalink / raw)
To: Thomas Monjalon, Dharmappa, Savinay, Dumitrescu, Cristian; +Cc: dev, dev
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, April 20, 2021 11:14 AM
> To: Dharmappa, Savinay <savinay.dharmappa@intel.com>; Singh, Jasvinder
> <jasvinder.singh@intel.com>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>
> Cc: dev@dpdk.org; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] sched : Initialize tc ov watermark.
>
> Ping
>
> 23/03/2021 17:02, Thomas Monjalon:
> > 09/03/2021 17:10, Savinay Dharmappa:
> > > tc ov watermark is initialized with computed value of max tc ov
> > > watermark.
> >
> > Sorry I don't understand what the change is doing.
> > Was there an issue?
> >
> > In the title, please avoid "tc ov" which is meaningless for most of
> > readers I guess.
>
>
Hi Thomas,
This is a fix for oversubscription threshold value of traffic class which is computed later. We will re-spin the patch by mentioning "fix" in the message and title.
Thanks,
Jasvinder
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [PATCH v2] sched : Initialize tc ov watermark.
2021-04-20 10:36 ` Singh, Jasvinder
@ 2021-04-20 13:54 ` Thomas Monjalon
0 siblings, 0 replies; 11+ messages in thread
From: Thomas Monjalon @ 2021-04-20 13:54 UTC (permalink / raw)
To: Dharmappa, Savinay, Dumitrescu, Cristian, Singh, Jasvinder; +Cc: dev
20/04/2021 12:36, Singh, Jasvinder:
> From: Thomas Monjalon <thomas@monjalon.net>
> >
> > Ping
> >
> > 23/03/2021 17:02, Thomas Monjalon:
> > > 09/03/2021 17:10, Savinay Dharmappa:
> > > > tc ov watermark is initialized with computed value of max tc ov
> > > > watermark.
> > >
> > > Sorry I don't understand what the change is doing.
> > > Was there an issue?
> > >
> > > In the title, please avoid "tc ov" which is meaningless for most of
> > > readers I guess.
> >
> >
> Hi Thomas,
>
> This is a fix for oversubscription threshold value of traffic class which is computed later. We will re-spin the patch by mentioning "fix" in the message and title.
Yes please give a clear explanation with full words, thanks.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-dev] [PATCH v3] sched : fix traffic class oversubscription parameter
2021-03-09 16:10 ` [dpdk-dev] [PATCH v2] " Savinay Dharmappa
` (2 preceding siblings ...)
2021-03-23 16:02 ` Thomas Monjalon
@ 2021-04-21 6:50 ` Savinay Dharmappa
2021-04-21 14:53 ` Thomas Monjalon
2021-04-21 15:24 ` Dumitrescu, Cristian
3 siblings, 2 replies; 11+ messages in thread
From: Savinay Dharmappa @ 2021-04-21 6:50 UTC (permalink / raw)
To: dev, jasvinder.singh, cristian.dumitrescu; +Cc: savinay.dharmappa, stable
This patch fixes the traffic class oversubscription watermark
value by initialising it with computed value of maximum watermark.
Fixes: ac6fcb841b0f ("sched: update subport rate dynamically")
Cc: stable@dpdk.org
Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com>
Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>
---
v3: update the title.
---
lib/librte_sched/rte_sched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c
index 7c56880681..cd87e688e4 100644
--- a/lib/librte_sched/rte_sched.c
+++ b/lib/librte_sched/rte_sched.c
@@ -1249,7 +1249,6 @@ rte_sched_subport_config(struct rte_sched_port *port,
#ifdef RTE_SCHED_SUBPORT_TC_OV
/* TC oversubscription */
s->tc_ov_wm_min = port->mtu;
- s->tc_ov_wm = s->tc_ov_wm_max;
s->tc_ov_period_id = 0;
s->tc_ov = 0;
s->tc_ov_n = 0;
@@ -1277,6 +1276,7 @@ rte_sched_subport_config(struct rte_sched_port *port,
#ifdef RTE_SCHED_SUBPORT_TC_OV
s->tc_ov_wm_max = rte_sched_time_ms_to_bytes(profile->tc_period,
s->pipe_tc_be_rate_max);
+ s->tc_ov_wm = s->tc_ov_wm_max;
#endif
s->profile = subport_profile_id;
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [dpdk-dev] [PATCH v3] sched : fix traffic class oversubscription parameter
2021-04-21 6:50 ` [dpdk-dev] [PATCH v3] sched : fix traffic class oversubscription parameter Savinay Dharmappa
@ 2021-04-21 14:53 ` Thomas Monjalon
2021-04-21 15:24 ` Dumitrescu, Cristian
1 sibling, 0 replies; 11+ messages in thread
From: Thomas Monjalon @ 2021-04-21 14:53 UTC (permalink / raw)
To: Savinay Dharmappa; +Cc: dev, jasvinder.singh, cristian.dumitrescu, stable
21/04/2021 08:50, Savinay Dharmappa:
> This patch fixes the traffic class oversubscription watermark
> value by initialising it with computed value of maximum watermark.
>
> Fixes: ac6fcb841b0f ("sched: update subport rate dynamically")
> Cc: stable@dpdk.org
>
> Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com>
> Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [dpdk-dev] [PATCH v3] sched : fix traffic class oversubscription parameter
2021-04-21 6:50 ` [dpdk-dev] [PATCH v3] sched : fix traffic class oversubscription parameter Savinay Dharmappa
2021-04-21 14:53 ` Thomas Monjalon
@ 2021-04-21 15:24 ` Dumitrescu, Cristian
1 sibling, 0 replies; 11+ messages in thread
From: Dumitrescu, Cristian @ 2021-04-21 15:24 UTC (permalink / raw)
To: Dharmappa, Savinay, dev, Singh, Jasvinder; +Cc: stable
> -----Original Message-----
> From: Dharmappa, Savinay <savinay.dharmappa@intel.com>
> Sent: Wednesday, April 21, 2021 7:50 AM
> To: dev@dpdk.org; Singh, Jasvinder <jasvinder.singh@intel.com>;
> Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: Dharmappa, Savinay <savinay.dharmappa@intel.com>; stable@dpdk.org
> Subject: [PATCH v3] sched : fix traffic class oversubscription parameter
>
> This patch fixes the traffic class oversubscription watermark
> value by initialising it with computed value of maximum watermark.
>
> Fixes: ac6fcb841b0f ("sched: update subport rate dynamically")
> Cc: stable@dpdk.org
>
> Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com>
> Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>
> ---
> v3: update the title.
> ---
> lib/librte_sched/rte_sched.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c
> index 7c56880681..cd87e688e4 100644
> --- a/lib/librte_sched/rte_sched.c
> +++ b/lib/librte_sched/rte_sched.c
> @@ -1249,7 +1249,6 @@ rte_sched_subport_config(struct rte_sched_port
> *port,
> #ifdef RTE_SCHED_SUBPORT_TC_OV
> /* TC oversubscription */
> s->tc_ov_wm_min = port->mtu;
> - s->tc_ov_wm = s->tc_ov_wm_max;
> s->tc_ov_period_id = 0;
> s->tc_ov = 0;
> s->tc_ov_n = 0;
> @@ -1277,6 +1276,7 @@ rte_sched_subport_config(struct rte_sched_port
> *port,
> #ifdef RTE_SCHED_SUBPORT_TC_OV
> s->tc_ov_wm_max = rte_sched_time_ms_to_bytes(profile-
> >tc_period,
> s-
> >pipe_tc_be_rate_max);
> + s->tc_ov_wm = s->tc_ov_wm_max;
> #endif
> s->profile = subport_profile_id;
>
> --
> 2.17.1
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
^ permalink raw reply [flat|nested] 11+ messages in thread