All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felix Kuehling <felix.kuehling-5C7GfCeVMHo@public.gmane.org>
To: Timothy Pearson
	<tpearson-z0qzliK6Om0mgXJStvpl+vpXobYPEAuW@public.gmane.org>,
	amd-gfx
	<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH 1/1] amdgpu: Enable KFD on POWER systems
Date: Mon, 25 Nov 2019 12:07:31 -0500	[thread overview]
Message-ID: <44175d39-e507-83f9-6596-cbde108dd65a@amd.com> (raw)
In-Reply-To: <2068915477.1923611.1574622916022.JavaMail.zimbra-z0qzliK6Om0mgXJStvpl+u2xl0RS173n@public.gmane.org>

Hi Timothy,

Thank you for the patch and for confirming that it works. We did some 
experimental work on Power8 a few years ago. I see that Talos II is Power9.

At the time we were working on Power8 we had to add some #ifdef 
CONFIG_ACPI guards around some ACPI-specific code in KFD. Do you know to 
what extent ACPI is available and working on the Power architecture?

Another problem we ran into with Power, is the physical address map. 
System memory can be a physical addresses outside the range accessible 
by the GPU. Vega has 44-bit physical addressing. Older Polaris GPUs only 
have 40-bits. Did you run into any such problems? Do you need an IOMMU 
to make system memory accessible to the GPU?

Regards,
   Felix

On 2019-11-24 2:15 p.m., Timothy Pearson wrote:
> KFD has been verified to function on POWER systems (Talos II / Vega 64).
> It should be available as a kernel configuration option on these systems.
>
> Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com>
> ---
>   drivers/gpu/drm/amd/amdkfd/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig b/drivers/gpu/drm/amd/amdkfd/Kconfig
> index a1a35d4d594b..ba0e68057a89 100644
> --- a/drivers/gpu/drm/amd/amdkfd/Kconfig
> +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig
> @@ -5,7 +5,7 @@
>   
>   config HSA_AMD
>   	bool "HSA kernel driver for AMD GPU devices"
> -	depends on DRM_AMDGPU && (X86_64 || ARM64)
> +	depends on DRM_AMDGPU && (X86_64 || ARM64 || PPC64)
>   	imply AMD_IOMMU_V2 if X86_64
>   	select MMU_NOTIFIER
>   	help
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Felix Kuehling <felix.kuehling@amd.com>
To: Timothy Pearson <tpearson@raptorengineering.com>,
	amd-gfx <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/1] amdgpu: Enable KFD on POWER systems
Date: Mon, 25 Nov 2019 12:07:31 -0500	[thread overview]
Message-ID: <44175d39-e507-83f9-6596-cbde108dd65a@amd.com> (raw)
Message-ID: <20191125170731.acBohij0uufonYFHnpi-xcYiVYMxxu8DbCFWAE5-k2A@z> (raw)
In-Reply-To: <2068915477.1923611.1574622916022.JavaMail.zimbra@raptorengineeringinc.com>

Hi Timothy,

Thank you for the patch and for confirming that it works. We did some 
experimental work on Power8 a few years ago. I see that Talos II is Power9.

At the time we were working on Power8 we had to add some #ifdef 
CONFIG_ACPI guards around some ACPI-specific code in KFD. Do you know to 
what extent ACPI is available and working on the Power architecture?

Another problem we ran into with Power, is the physical address map. 
System memory can be a physical addresses outside the range accessible 
by the GPU. Vega has 44-bit physical addressing. Older Polaris GPUs only 
have 40-bits. Did you run into any such problems? Do you need an IOMMU 
to make system memory accessible to the GPU?

Regards,
   Felix

On 2019-11-24 2:15 p.m., Timothy Pearson wrote:
> KFD has been verified to function on POWER systems (Talos II / Vega 64).
> It should be available as a kernel configuration option on these systems.
>
> Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com>
> ---
>   drivers/gpu/drm/amd/amdkfd/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig b/drivers/gpu/drm/amd/amdkfd/Kconfig
> index a1a35d4d594b..ba0e68057a89 100644
> --- a/drivers/gpu/drm/amd/amdkfd/Kconfig
> +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig
> @@ -5,7 +5,7 @@
>   
>   config HSA_AMD
>   	bool "HSA kernel driver for AMD GPU devices"
> -	depends on DRM_AMDGPU && (X86_64 || ARM64)
> +	depends on DRM_AMDGPU && (X86_64 || ARM64 || PPC64)
>   	imply AMD_IOMMU_V2 if X86_64
>   	select MMU_NOTIFIER
>   	help
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2019-11-25 17:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-24 19:15 [PATCH 1/1] amdgpu: Enable KFD on POWER systems Timothy Pearson
2019-11-24 19:15 ` Timothy Pearson
     [not found] ` <2068915477.1923611.1574622916022.JavaMail.zimbra-z0qzliK6Om0mgXJStvpl+u2xl0RS173n@public.gmane.org>
2019-11-25 14:59   ` Alex Deucher
2019-11-25 14:59     ` Alex Deucher
2019-11-25 17:07   ` Felix Kuehling [this message]
2019-11-25 17:07     ` Felix Kuehling
     [not found]     ` <44175d39-e507-83f9-6596-cbde108dd65a-5C7GfCeVMHo@public.gmane.org>
2019-11-25 21:06       ` Timothy Pearson
2019-11-25 21:06         ` Timothy Pearson
     [not found]         ` <535694171.2118031.1574716002431.JavaMail.zimbra-z0qzliK6Om0mgXJStvpl+u2xl0RS173n@public.gmane.org>
2019-11-25 21:34           ` Felix Kuehling
2019-11-25 21:34             ` Felix Kuehling
     [not found]             ` <5dcfdba7-dc14-99d4-d6e5-fc1768fcc5c0-5C7GfCeVMHo@public.gmane.org>
2019-11-25 21:52               ` Timothy Pearson
2019-11-25 21:52                 ` Timothy Pearson
  -- strict thread matches above, loose matches on Subject: below --
2019-11-24 19:10 Timothy Pearson
2019-11-24 19:10 ` Timothy Pearson
     [not found] ` <443989900.1923547.1574622652551.JavaMail.zimbra-z0qzliK6Om0mgXJStvpl+u2xl0RS173n@public.gmane.org>
2019-11-24 19:19   ` Timothy Pearson
2019-11-24 19:19     ` Timothy Pearson
2019-11-24 19:09 Timothy Pearson
2019-11-24 19:09 ` Timothy Pearson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44175d39-e507-83f9-6596-cbde108dd65a@amd.com \
    --to=felix.kuehling-5c7gfcevmho@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=tpearson-z0qzliK6Om0mgXJStvpl+vpXobYPEAuW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.