All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net] bridge/br_netlink.c: no need to return void function
@ 2024-04-19  8:02 Hangbin Liu
  2024-04-19  9:25 ` Nikolay Aleksandrov
  2024-04-22 11:00 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Hangbin Liu @ 2024-04-19  8:02 UTC (permalink / raw)
  To: netdev
  Cc: Roopa Prabhu, Nikolay Aleksandrov, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Horatiu Vultur, Henrik Bjoernlund,
	bridge, Hangbin Liu

br_info_notify is a void function. There is no need to return.

Fixes: b6d0425b816e ("bridge: cfm: Netlink Notifications.")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
 net/bridge/br_netlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
index 2cf4fc756263..f17dbac7d828 100644
--- a/net/bridge/br_netlink.c
+++ b/net/bridge/br_netlink.c
@@ -667,7 +667,7 @@ void br_ifinfo_notify(int event, const struct net_bridge *br,
 {
 	u32 filter = RTEXT_FILTER_BRVLAN_COMPRESSED;
 
-	return br_info_notify(event, br, port, filter);
+	br_info_notify(event, br, port, filter);
 }
 
 /*
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH net] bridge/br_netlink.c: no need to return void function
  2024-04-19  8:02 [PATCH net] bridge/br_netlink.c: no need to return void function Hangbin Liu
@ 2024-04-19  9:25 ` Nikolay Aleksandrov
  2024-04-22 11:00 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Nikolay Aleksandrov @ 2024-04-19  9:25 UTC (permalink / raw)
  To: Hangbin Liu, netdev
  Cc: Roopa Prabhu, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Horatiu Vultur, Henrik Bjoernlund, bridge

On 4/19/24 11:02, Hangbin Liu wrote:
> br_info_notify is a void function. There is no need to return.
> 
> Fixes: b6d0425b816e ("bridge: cfm: Netlink Notifications.")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
>   net/bridge/br_netlink.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
> index 2cf4fc756263..f17dbac7d828 100644
> --- a/net/bridge/br_netlink.c
> +++ b/net/bridge/br_netlink.c
> @@ -667,7 +667,7 @@ void br_ifinfo_notify(int event, const struct net_bridge *br,
>   {
>   	u32 filter = RTEXT_FILTER_BRVLAN_COMPRESSED;
>   
> -	return br_info_notify(event, br, port, filter);
> +	br_info_notify(event, br, port, filter);
>   }
>   
>   /*

Acked-by: Nikolay Aleksandrov <razor@blackwall.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH net] bridge/br_netlink.c: no need to return void function
  2024-04-19  8:02 [PATCH net] bridge/br_netlink.c: no need to return void function Hangbin Liu
  2024-04-19  9:25 ` Nikolay Aleksandrov
@ 2024-04-22 11:00 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-04-22 11:00 UTC (permalink / raw)
  To: Hangbin Liu
  Cc: netdev, roopa, razor, davem, edumazet, kuba, pabeni,
	horatiu.vultur, henrik.bjoernlund, bridge

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Fri, 19 Apr 2024 16:02:00 +0800 you wrote:
> br_info_notify is a void function. There is no need to return.
> 
> Fixes: b6d0425b816e ("bridge: cfm: Netlink Notifications.")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
>  net/bridge/br_netlink.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [net] bridge/br_netlink.c: no need to return void function
    https://git.kernel.org/netdev/net/c/4fd1edcdf13c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-22 11:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-19  8:02 [PATCH net] bridge/br_netlink.c: no need to return void function Hangbin Liu
2024-04-19  9:25 ` Nikolay Aleksandrov
2024-04-22 11:00 ` patchwork-bot+netdevbpf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.