[Accel-config] Re: [PATCH v1 00/14] Add Zcompress32, Zdecompress32, Compress and Decompress test.

[Accel-config] Re: [PATCH v1 00/14] Add Zcompress32, Zdecompress32, Compress and Decompress test.

[Dave Jiang]

[-- Attachment #1: Type: text/plain, Size: 2125 bytes --]


On 5/24/2022 3:24 AM, Li Zhang wrote:
> Add software algorithms of Zcompress32, Zdecompress32 and Decompress,
> add operation Zcompress32, Zdecompress32, Compress and Decompress
> test code, modify Makefile and test script.
>
> Li Zhang (14):
>    accel-config/test: Add algorithm to do Zcompress32
>    accel-config/test: Add test code of operation Zcompress32
>    accel-config/test: Modify script for executing Zcompress32 test
>    accel-config/test: Add algorithm to do Zdecompress32
>    accel-config/test: Add test code of operation Zdecompress32
>    accel-config/test: Modify script for executing Zdecompress32 test
>    accel-config/test: Add function to do Decompress
>    accel-config/test: Add macros for IAA Compress register
>    accel-config/test: Add test code of operation Compress
>    Modify script for executing Compress test
>    accel-config/test: Add macros for IAA Decompress register
>    accel-config/test: Add element input_size to struct task
>    accel-config/test: Add test code of operation Decompress
>    accel-config/test: Modify script for executing Decompress test
>
>   accfg/idxd.h                    |  10 +
>   test/Makefile.am                |   5 +-
>   test/accel_test.h               |   1 +
>   test/algorithms/iaa_compress.c  |  58 ++++
>   test/algorithms/iaa_compress.h  | 413 +++++++++++++++++++++++
>   test/algorithms/iaa_zcompress.c |  77 +++++
>   test/algorithms/iaa_zcompress.h |   2 +
>   test/iaa.c                      | 569 +++++++++++++++++++++++++++++++-
>   test/iaa.h                      |  13 +
>   test/iaa_prep.c                 |  50 +++
>   test/iaa_test.c                 |  97 +++++-
>   test/iaa_user_test_runner.sh    |   4 +-
>   12 files changed, 1292 insertions(+), 7 deletions(-)
>   create mode 100644 test/algorithms/iaa_compress.c
>   create mode 100644 test/algorithms/iaa_compress.h

I'm not a subject matter expert on the operations. But everything else 
looks ok to me.

Reviewed-by: Dave Jiang <dave.jiang(a)intel.com>

Tony, have you reviewed the code since you are the test suite maintainer?

[Accel-config] Re: [PATCH v1 00/14] Add Zcompress32, Zdecompress32, Compress and Decompress test.

[Dave Jiang]

[-- Attachment #1: Type: text/plain, Size: 2082 bytes --]


On 6/3/2022 5:48 PM, Li Zhang wrote:
> Add software algorithms of Zcompress32, Zdecompress32 and Decompress,
> add operation Zcompress32, Zdecompress32, Compress and Decompress
> test code, modify Makefile and test script.
Hi Li. Did anything change in this version? If so, please mark this as 
v2 (instead of v1) and also provide change history in the cover letter. 
Thank you.
>
> Li Zhang (14):
>    accel-config/test: Add algorithm to do Zcompress32
>    accel-config/test: Add test code of operation Zcompress32
>    accel-config/test: Modify script for executing Zcompress32 test
>    accel-config/test: Add algorithm to do Zdecompress32
>    accel-config/test: Add test code of operation Zdecompress32
>    accel-config/test: Modify script for executing Zdecompress32 test
>    accel-config/test: Add function to do Decompress
>    accel-config/test: Add macros for IAA Compress register
>    accel-config/test: Add test code of operation Compress
>    accel-config/test: Modify script for executing Compress test
>    accel-config/test: Add macros for IAA Decompress register
>    accel-config/test: Add element input_size to struct task
>    accel-config/test: Add test code of operation Decompress
>    accel-config/test: Modify script for executing Decompress test
>
>   accfg/idxd.h                    |  10 +
>   test/Makefile.am                |   5 +-
>   test/accel_test.h               |   1 +
>   test/algorithms/iaa_compress.c  |  58 ++++
>   test/algorithms/iaa_compress.h  | 413 +++++++++++++++++++++++
>   test/algorithms/iaa_zcompress.c |  77 +++++
>   test/algorithms/iaa_zcompress.h |   2 +
>   test/iaa.c                      | 569 +++++++++++++++++++++++++++++++-
>   test/iaa.h                      |  13 +
>   test/iaa_prep.c                 |  50 +++
>   test/iaa_test.c                 |  97 +++++-
>   test/iaa_user_test_runner.sh    |   4 +-
>   12 files changed, 1292 insertions(+), 7 deletions(-)
>   create mode 100644 test/algorithms/iaa_compress.c
>   create mode 100644 test/algorithms/iaa_compress.h
>