All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] powerpc: remote save_stack_trace_tsk_reliable export
@ 2019-03-01 19:17 Joe Lawrence
  2019-03-03 20:05 ` Singh, Balbir
  2019-03-04  0:48 ` Michael Ellerman
  0 siblings, 2 replies; 3+ messages in thread
From: Joe Lawrence @ 2019-03-01 19:17 UTC (permalink / raw)
  To: live-patching, x86, linuxppc-dev; +Cc: Thomas Gleixner

As tglx points out, there are no in-tree module users of
save_stack_trace_tsk_reliable() and its x86 counterpart is not exported,
so remove the powerpc symbol export.

Suggested-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
---
 arch/powerpc/kernel/stacktrace.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/powerpc/kernel/stacktrace.c b/arch/powerpc/kernel/stacktrace.c
index e2c50b55138f..42c587de21a9 100644
--- a/arch/powerpc/kernel/stacktrace.c
+++ b/arch/powerpc/kernel/stacktrace.c
@@ -193,7 +193,6 @@ save_stack_trace_tsk_reliable(struct task_struct *tsk,
 	}
 	return 0;
 }
-EXPORT_SYMBOL_GPL(save_stack_trace_tsk_reliable);
 #endif /* CONFIG_HAVE_RELIABLE_STACKTRACE */
 
 #if defined(CONFIG_PPC_BOOK3S_64) && defined(CONFIG_NMI_IPI)
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] powerpc: remote save_stack_trace_tsk_reliable export
  2019-03-01 19:17 [PATCH] powerpc: remote save_stack_trace_tsk_reliable export Joe Lawrence
@ 2019-03-03 20:05 ` Singh, Balbir
  2019-03-04  0:48 ` Michael Ellerman
  1 sibling, 0 replies; 3+ messages in thread
From: Singh, Balbir @ 2019-03-03 20:05 UTC (permalink / raw)
  To: Joe Lawrence, live-patching, x86, linuxppc-dev; +Cc: Thomas Gleixner



On 3/1/19 11:17 AM, Joe Lawrence wrote:
> As tglx points out, there are no in-tree module users of
> save_stack_trace_tsk_reliable() and its x86 counterpart is not exported,
> so remove the powerpc symbol export.
> 
> Suggested-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
> ---
>  arch/powerpc/kernel/stacktrace.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/powerpc/kernel/stacktrace.c b/arch/powerpc/kernel/stacktrace.c
> index e2c50b55138f..42c587de21a9 100644
> --- a/arch/powerpc/kernel/stacktrace.c
> +++ b/arch/powerpc/kernel/stacktrace.c
> @@ -193,7 +193,6 @@ save_stack_trace_tsk_reliable(struct task_struct *tsk,
>  	}
>  	return 0;
>  }
> -EXPORT_SYMBOL_GPL(save_stack_trace_tsk_reliable);
>  #endif /* CONFIG_HAVE_RELIABLE_STACKTRACE */
>  
>  #if defined(CONFIG_PPC_BOOK3S_64) && defined(CONFIG_NMI_IPI)
> 


Acked-by: Balbir Singh <bsingharora@gmail.com>

Balbir Singh

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: powerpc: remote save_stack_trace_tsk_reliable export
  2019-03-01 19:17 [PATCH] powerpc: remote save_stack_trace_tsk_reliable export Joe Lawrence
  2019-03-03 20:05 ` Singh, Balbir
@ 2019-03-04  0:48 ` Michael Ellerman
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2019-03-04  0:48 UTC (permalink / raw)
  To: Joe Lawrence, live-patching, x86, linuxppc-dev; +Cc: Thomas Gleixner

On Fri, 2019-03-01 at 19:17:21 UTC, Joe Lawrence wrote:
> As tglx points out, there are no in-tree module users of
> save_stack_trace_tsk_reliable() and its x86 counterpart is not exported,
> so remove the powerpc symbol export.
> 
> Suggested-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
> Acked-by: Balbir Singh <bsingharora@gmail.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/39070a96a1c2c502b2f77972ba8c2eba

cheers

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-03-04  0:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-01 19:17 [PATCH] powerpc: remote save_stack_trace_tsk_reliable export Joe Lawrence
2019-03-03 20:05 ` Singh, Balbir
2019-03-04  0:48 ` Michael Ellerman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.