Re: [PATCH] VIA IRQ quirk fixup only in XT_PIC mode Take 2

From: Daniel Drake <dsd@gentoo.org>
To: sergio@sergiomb.no-ip.org
Cc: bjorn.helgaas@hp.com, linux-kernel@vger.kernel.org,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Andrew Morton <akpm@osdl.org>, Chris Wedgwood <cw@f00f.org>,
	greg@kroah.com, jeff@garzik.org, harmon@ksu.edu
Subject: Re: [PATCH] VIA IRQ quirk fixup only in XT_PIC mode Take 2
Date: Tue, 29 Aug 2006 23:46:18 -0400	[thread overview]
Message-ID: <44F50A0A.2040800@gentoo.org> (raw)
In-Reply-To: <1156906638.3022.18.camel@localhost.portugal>

Sergio Monteiro Basto wrote:
> I remember check my emails that I send to Len Brown about this subject.
> And I found, what I want, is just revert one patch of Bjorn Helgaas :)
> between kernel 2.6.12-rc5 and 6.13.

It does look like this patch was under discussion of being reverted 
before. See http://lkml.org/lkml/2005/9/26/183

The following comment still stands when we just revert Bjorn's change:

>> I'm reasonably certain that this patch will apply the quirks on the 
>> affected systems again, so I'm happy for it to be applied, people will 
>> be able to use their hardware again. However I'm not sure how good a 
>> solution it is, because in some circumstances it will apply the quirks 
>> to VIA PCI cards on non-VIA boards, which was the reason we messed with 
>> this code in the first place. We could possibly merge it with the 
>> southbridge detection hack, but it gets a bit silly at that point...

So perhaps the best solution is a combination of reverting Bjorn's 
patch, adding Linus' suggested change, and adding my southbridge hack.

Daniel