Re: [PATCH] VIA IRQ quirk fixup only in XT_PIC mode Take 2

From: Daniel Drake <dsd@gentoo.org>
To: Sergio Monteiro Basto <sergio@sergiomb.no-ip.org>
Cc: bjorn.helgaas@hp.com, linux-kernel@vger.kernel.org,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Andrew Morton <akpm@osdl.org>, Chris Wedgwood <cw@f00f.org>,
	greg@kroah.com, jeff@garzik.org, harmon@ksu.edu
Subject: Re: [PATCH] VIA IRQ quirk fixup only in XT_PIC mode Take 2
Date: Tue, 05 Sep 2006 09:37:50 -0400	[thread overview]
Message-ID: <44FD7DAE.7030705@gentoo.org> (raw)
In-Reply-To: <1157024002.2724.4.camel@localhost.localdomain>

Sergio Monteiro Basto wrote:
> On Wed, 2006-08-30 at 12:13 -0400, Daniel Drake wrote:
> 
>>> about Linus suggestion : 
>>> -	new_irq = dev->irq & 0xf;
>>> +	new_irq = dev->irq;
>>> +	if (!new_irq || new_irq >= 15)
>>> +		return;
>>>
>>> no, we have problem with VIA SATA controllers which have irq lower than
>>> 15 
>> Any chance you can provide a link to this example so that we can 
>> document the decision in the commit message?
> 
> http://lkml.org/lkml/2006/7/30/59

I'm confused. Heikki's report is about a sata_sil controller and he 
didn't include any dmesg output so I don't know how you can conclude 
that quirking an IRQ to something less than 15 was the fix...

Also note that the fix was *not* quirking the device at all (your patch 
ensured that the quirks didn't run because IO-APIC was enabled), this 
hardly seems like an accurate way of arguing that quirks that change the 
IRQ to something less than 15 are *required*...

Daniel

Daniel