Re: [poky] [PATCH v2] local.conf.sample: use https instead of http for SSTATE_MIRRORS

["Michael Opdenacker" <michael.opdenacker@bootlin.com>]

Hi Peter,

Thank you very much for the review!

On 1/26/22 12:24, Peter Kjellerstedt wrote:
>> -----Original Message-----
>> From: poky@lists.yoctoproject.org <poky@lists.yoctoproject.org> On Behalf Of Michael Opdenacker
>> Sent: den 26 januari 2022 11:44
>> To: poky@lists.yoctoproject.org
>> Cc: Michael Opdenacker <michael.opdenacker@bootlin.com>
>> Subject: [poky] [PATCH v2] local.conf.sample: use https instead of http for SSTATE_MIRRORS
>>
>> Both http and https work, but we should get fewer questions
>> with https
>>
>> Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
>> ---
>>  meta-poky/conf/local.conf.sample | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/meta-poky/conf/local.conf.sample b/meta-poky/conf/local.conf.sample
>> index 7bdbba0..3100eb1 100644
>> --- a/meta-poky/conf/local.conf.sample
>> +++ b/meta-poky/conf/local.conf.sample
>> @@ -206,7 +206,7 @@ BB_DISKMON_DIRS ??= "\
>>  # used to accelerate build time. This variable can be used to configure the system
>>  # to search other mirror locations for these objects before it builds the data itself.
>>  #
>> -# This can be a filesystem directory, or a remote url such as http or ftp. These
>> +# This can be a filesystem directory, or a remote url such as https or ftp. These
>>  # would contain the sstate-cache results from previous builds (possibly from other
>>  # machines). This variable works like fetcher MIRRORS/PREMIRRORS and points to the
>>  # cache locations to check for the shared objects.
>> @@ -214,7 +214,7 @@ BB_DISKMON_DIRS ??= "\
>>  # at the end as shown in the examples below. This will be substituted with the
>>  # correct path within the directory structure.
>>  #SSTATE_MIRRORS ?= "\
>> -#file://.* http://someserver.tld/share/sstate/PATH;downloadfilename=PATH \n \
>> +#file://.* https://someserver.tld/share/sstate/PATH;downloadfilename=PATH \n \
> While there, you may as well remove the "\n".


Good idea. We already did that in other places.
However, shouldn't it be a separate commit? I can read Quentin's lips ;-)
Cheers
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com