* [PATCH 1/1] arm64: dts: meson-g12b-odroid-n2: move assigned-clocks
@ 2021-12-18 14:26 ` Alexander Stein
0 siblings, 0 replies; 8+ messages in thread
From: Alexander Stein @ 2021-12-18 14:26 UTC (permalink / raw)
To: Rob Herring, Neil Armstrong, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl
Cc: Alexander Stein, devicetree, linux-amlogic
dtschema expects a 'clocks' property if 'assigned-clocks' is used, but
'sound' node does not.
So move the MPLL[0-2] clock settings &clkc_audio which actually use them.
This fixes the dtschema warning:
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dt.yaml: sound: 'clocks' is a dependency of 'assigned-clocks'
Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
---
.../boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
index 9c05c83453f5..85257507206c 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
@@ -252,14 +252,6 @@ sound {
"U19 INR", "ACODEC LORP",
"Lineout", "U19 OUTL",
"Lineout", "U19 OUTR";
-
- assigned-clocks = <&clkc CLKID_MPLL2>,
- <&clkc CLKID_MPLL0>,
- <&clkc CLKID_MPLL1>;
- assigned-clock-parents = <0>, <0>, <0>;
- assigned-clock-rates = <294912000>,
- <270950400>,
- <393216000>;
status = "okay";
dai-link-0 {
@@ -365,6 +357,13 @@ &cecb_AO {
};
&clkc_audio {
+ assigned-clocks = <&clkc CLKID_MPLL2>,
+ <&clkc CLKID_MPLL0>,
+ <&clkc CLKID_MPLL1>;
+ assigned-clock-parents = <0>, <0>, <0>;
+ assigned-clock-rates = <294912000>,
+ <270950400>,
+ <393216000>;
status = "okay";
};
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 1/1] arm64: dts: meson-g12b-odroid-n2: move assigned-clocks
@ 2021-12-18 14:26 ` Alexander Stein
0 siblings, 0 replies; 8+ messages in thread
From: Alexander Stein @ 2021-12-18 14:26 UTC (permalink / raw)
To: Rob Herring, Neil Armstrong, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl
Cc: Alexander Stein, devicetree, linux-amlogic
dtschema expects a 'clocks' property if 'assigned-clocks' is used, but
'sound' node does not.
So move the MPLL[0-2] clock settings &clkc_audio which actually use them.
This fixes the dtschema warning:
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dt.yaml: sound: 'clocks' is a dependency of 'assigned-clocks'
Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
---
.../boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
index 9c05c83453f5..85257507206c 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
@@ -252,14 +252,6 @@ sound {
"U19 INR", "ACODEC LORP",
"Lineout", "U19 OUTL",
"Lineout", "U19 OUTR";
-
- assigned-clocks = <&clkc CLKID_MPLL2>,
- <&clkc CLKID_MPLL0>,
- <&clkc CLKID_MPLL1>;
- assigned-clock-parents = <0>, <0>, <0>;
- assigned-clock-rates = <294912000>,
- <270950400>,
- <393216000>;
status = "okay";
dai-link-0 {
@@ -365,6 +357,13 @@ &cecb_AO {
};
&clkc_audio {
+ assigned-clocks = <&clkc CLKID_MPLL2>,
+ <&clkc CLKID_MPLL0>,
+ <&clkc CLKID_MPLL1>;
+ assigned-clock-parents = <0>, <0>, <0>;
+ assigned-clock-rates = <294912000>,
+ <270950400>,
+ <393216000>;
status = "okay";
};
--
2.34.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] arm64: dts: meson-g12b-odroid-n2: move assigned-clocks
2021-12-18 14:26 ` Alexander Stein
@ 2021-12-18 15:03 ` Jerome Brunet
-1 siblings, 0 replies; 8+ messages in thread
From: Jerome Brunet @ 2021-12-18 15:03 UTC (permalink / raw)
To: Alexander Stein, Rob Herring, Neil Armstrong, Kevin Hilman,
Martin Blumenstingl
Cc: devicetree, linux-amlogic
On Sat 18 Dec 2021 at 15:26, Alexander Stein <alexander.stein@mailbox.org> wrote:
> dtschema expects a 'clocks' property if 'assigned-clocks' is used, but
> 'sound' node does not.
> So move the MPLL[0-2] clock settings &clkc_audio which actually use them.
No, this does not make sense.
The sound card needs the clocks set in such way - nothing else
The clock controller work just as well regarless of the clock rate
Having a clock property or not does not change that
> This fixes the dtschema warning:
> arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dt.yaml: sound: 'clocks' is a dependency of 'assigned-clocks'
>
Then the schema needs fixing IMO
> Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
> ---
> .../boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> index 9c05c83453f5..85257507206c 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> @@ -252,14 +252,6 @@ sound {
> "U19 INR", "ACODEC LORP",
> "Lineout", "U19 OUTL",
> "Lineout", "U19 OUTR";
> -
> - assigned-clocks = <&clkc CLKID_MPLL2>,
> - <&clkc CLKID_MPLL0>,
> - <&clkc CLKID_MPLL1>;
> - assigned-clock-parents = <0>, <0>, <0>;
> - assigned-clock-rates = <294912000>,
> - <270950400>,
> - <393216000>;
> status = "okay";
>
> dai-link-0 {
> @@ -365,6 +357,13 @@ &cecb_AO {
> };
>
> &clkc_audio {
> + assigned-clocks = <&clkc CLKID_MPLL2>,
> + <&clkc CLKID_MPLL0>,
> + <&clkc CLKID_MPLL1>;
> + assigned-clock-parents = <0>, <0>, <0>;
> + assigned-clock-rates = <294912000>,
> + <270950400>,
> + <393216000>;
> status = "okay";
> };
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] arm64: dts: meson-g12b-odroid-n2: move assigned-clocks
@ 2021-12-18 15:03 ` Jerome Brunet
0 siblings, 0 replies; 8+ messages in thread
From: Jerome Brunet @ 2021-12-18 15:03 UTC (permalink / raw)
To: Alexander Stein, Rob Herring, Neil Armstrong, Kevin Hilman,
Martin Blumenstingl
Cc: devicetree, linux-amlogic
On Sat 18 Dec 2021 at 15:26, Alexander Stein <alexander.stein@mailbox.org> wrote:
> dtschema expects a 'clocks' property if 'assigned-clocks' is used, but
> 'sound' node does not.
> So move the MPLL[0-2] clock settings &clkc_audio which actually use them.
No, this does not make sense.
The sound card needs the clocks set in such way - nothing else
The clock controller work just as well regarless of the clock rate
Having a clock property or not does not change that
> This fixes the dtschema warning:
> arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dt.yaml: sound: 'clocks' is a dependency of 'assigned-clocks'
>
Then the schema needs fixing IMO
> Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
> ---
> .../boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> index 9c05c83453f5..85257507206c 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> @@ -252,14 +252,6 @@ sound {
> "U19 INR", "ACODEC LORP",
> "Lineout", "U19 OUTL",
> "Lineout", "U19 OUTR";
> -
> - assigned-clocks = <&clkc CLKID_MPLL2>,
> - <&clkc CLKID_MPLL0>,
> - <&clkc CLKID_MPLL1>;
> - assigned-clock-parents = <0>, <0>, <0>;
> - assigned-clock-rates = <294912000>,
> - <270950400>,
> - <393216000>;
> status = "okay";
>
> dai-link-0 {
> @@ -365,6 +357,13 @@ &cecb_AO {
> };
>
> &clkc_audio {
> + assigned-clocks = <&clkc CLKID_MPLL2>,
> + <&clkc CLKID_MPLL0>,
> + <&clkc CLKID_MPLL1>;
> + assigned-clock-parents = <0>, <0>, <0>;
> + assigned-clock-rates = <294912000>,
> + <270950400>,
> + <393216000>;
> status = "okay";
> };
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] arm64: dts: meson-g12b-odroid-n2: move assigned-clocks
2021-12-18 15:03 ` Jerome Brunet
@ 2021-12-19 9:56 ` Alexander Stein
-1 siblings, 0 replies; 8+ messages in thread
From: Alexander Stein @ 2021-12-19 9:56 UTC (permalink / raw)
To: Rob Herring, Neil Armstrong, Kevin Hilman, Martin Blumenstingl,
Jerome Brunet
Cc: devicetree, linux-amlogic
Am Samstag, 18. Dezember 2021, 16:03:16 CET schrieb Jerome Brunet:
>
> On Sat 18 Dec 2021 at 15:26, Alexander Stein <alexander.stein@mailbox.org> wrote:
>
> > dtschema expects a 'clocks' property if 'assigned-clocks' is used, but
> > 'sound' node does not.
> > So move the MPLL[0-2] clock settings &clkc_audio which actually use them.
>
> No, this does not make sense.
> The sound card needs the clocks set in such way - nothing else
> The clock controller work just as well regarless of the clock rate
>
> Having a clock property or not does not change that
Well, I checked what others did to fix this warning. So I did the same as in [1].
Despite that, IMHO if you split 'assigned-clocks' for the same clock ´all
over users who is gonna win? Because the sound card needs the clocks set
his way it is set, it is done in the same file.
Best regards,
Alexander
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4afb06afd76855932a2d19c983c013105f1cfb9a
> > This fixes the dtschema warning:
> > arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dt.yaml: sound: 'clocks' is a dependency of 'assigned-clocks'
> >
>
> Then the schema needs fixing IMO
>
> > Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
> > ---
> > .../boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 15 +++++++--------
> > 1 file changed, 7 insertions(+), 8 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> > index 9c05c83453f5..85257507206c 100644
> > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> > @@ -252,14 +252,6 @@ sound {
> > "U19 INR", "ACODEC LORP",
> > "Lineout", "U19 OUTL",
> > "Lineout", "U19 OUTR";
> > -
> > - assigned-clocks = <&clkc CLKID_MPLL2>,
> > - <&clkc CLKID_MPLL0>,
> > - <&clkc CLKID_MPLL1>;
> > - assigned-clock-parents = <0>, <0>, <0>;
> > - assigned-clock-rates = <294912000>,
> > - <270950400>,
> > - <393216000>;
> > status = "okay";
> >
> > dai-link-0 {
> > @@ -365,6 +357,13 @@ &cecb_AO {
> > };
> >
> > &clkc_audio {
> > + assigned-clocks = <&clkc CLKID_MPLL2>,
> > + <&clkc CLKID_MPLL0>,
> > + <&clkc CLKID_MPLL1>;
> > + assigned-clock-parents = <0>, <0>, <0>;
> > + assigned-clock-rates = <294912000>,
> > + <270950400>,
> > + <393216000>;
> > status = "okay";
> > };
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] arm64: dts: meson-g12b-odroid-n2: move assigned-clocks
@ 2021-12-19 9:56 ` Alexander Stein
0 siblings, 0 replies; 8+ messages in thread
From: Alexander Stein @ 2021-12-19 9:56 UTC (permalink / raw)
To: Rob Herring, Neil Armstrong, Kevin Hilman, Martin Blumenstingl,
Jerome Brunet
Cc: devicetree, linux-amlogic
Am Samstag, 18. Dezember 2021, 16:03:16 CET schrieb Jerome Brunet:
>
> On Sat 18 Dec 2021 at 15:26, Alexander Stein <alexander.stein@mailbox.org> wrote:
>
> > dtschema expects a 'clocks' property if 'assigned-clocks' is used, but
> > 'sound' node does not.
> > So move the MPLL[0-2] clock settings &clkc_audio which actually use them.
>
> No, this does not make sense.
> The sound card needs the clocks set in such way - nothing else
> The clock controller work just as well regarless of the clock rate
>
> Having a clock property or not does not change that
Well, I checked what others did to fix this warning. So I did the same as in [1].
Despite that, IMHO if you split 'assigned-clocks' for the same clock ´all
over users who is gonna win? Because the sound card needs the clocks set
his way it is set, it is done in the same file.
Best regards,
Alexander
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4afb06afd76855932a2d19c983c013105f1cfb9a
> > This fixes the dtschema warning:
> > arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dt.yaml: sound: 'clocks' is a dependency of 'assigned-clocks'
> >
>
> Then the schema needs fixing IMO
>
> > Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
> > ---
> > .../boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 15 +++++++--------
> > 1 file changed, 7 insertions(+), 8 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> > index 9c05c83453f5..85257507206c 100644
> > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> > @@ -252,14 +252,6 @@ sound {
> > "U19 INR", "ACODEC LORP",
> > "Lineout", "U19 OUTL",
> > "Lineout", "U19 OUTR";
> > -
> > - assigned-clocks = <&clkc CLKID_MPLL2>,
> > - <&clkc CLKID_MPLL0>,
> > - <&clkc CLKID_MPLL1>;
> > - assigned-clock-parents = <0>, <0>, <0>;
> > - assigned-clock-rates = <294912000>,
> > - <270950400>,
> > - <393216000>;
> > status = "okay";
> >
> > dai-link-0 {
> > @@ -365,6 +357,13 @@ &cecb_AO {
> > };
> >
> > &clkc_audio {
> > + assigned-clocks = <&clkc CLKID_MPLL2>,
> > + <&clkc CLKID_MPLL0>,
> > + <&clkc CLKID_MPLL1>;
> > + assigned-clock-parents = <0>, <0>, <0>;
> > + assigned-clock-rates = <294912000>,
> > + <270950400>,
> > + <393216000>;
> > status = "okay";
> > };
>
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] arm64: dts: meson-g12b-odroid-n2: move assigned-clocks
2021-12-19 9:56 ` Alexander Stein
@ 2021-12-21 10:54 ` Jerome Brunet
-1 siblings, 0 replies; 8+ messages in thread
From: Jerome Brunet @ 2021-12-21 10:54 UTC (permalink / raw)
To: Alexander Stein, Rob Herring, Neil Armstrong, Kevin Hilman,
Martin Blumenstingl
Cc: devicetree, linux-amlogic
On Sun 19 Dec 2021 at 10:56, Alexander Stein <alexander.stein@mailbox.org> wrote:
> Am Samstag, 18. Dezember 2021, 16:03:16 CET schrieb Jerome Brunet:
>>
>> On Sat 18 Dec 2021 at 15:26, Alexander Stein <alexander.stein@mailbox.org> wrote:
>>
>> > dtschema expects a 'clocks' property if 'assigned-clocks' is used, but
>> > 'sound' node does not.
>> > So move the MPLL[0-2] clock settings &clkc_audio which actually use them.
>>
>> No, this does not make sense.
>> The sound card needs the clocks set in such way - nothing else
>> The clock controller work just as well regarless of the clock rate
>>
>> Having a clock property or not does not change that
Also the documentation of assigned does not mandate that.
>
> Well, I checked what others did to fix this warning. So I did the same as in [1].
> Despite that, IMHO if you split 'assigned-clocks' for the same clock ´all
> over users who is gonna win?
1. This is explicitly forbidden by the assigned-clock binding documentation
2. Like other interfaces, it is likely a last write wins
The fact the ID assigned by the card and the one claimed controller are
the same is merely a coincidence. The ID assigned could very well have
been internal to the audio controller.
> Because the sound card needs the clocks set
> his way it is set, it is done in the same file.
If I push this logic further, I may as well put everything at root of DT,
or anywhere else, as long as it is in the same file and there is a clock
property for the schema. We could put it with uart, that would work ;)
(just kidding)
The cards needs these rate because of rate family we choose to support,
and how we choose to support them. This is where the assignment makes
sense.
>
> Best regards,
> Alexander
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4afb06afd76855932a2d19c983c013105f1cfb9a
>
>> > This fixes the dtschema warning:
>> > arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dt.yaml: sound: 'clocks' is a dependency of 'assigned-clocks'
>> >
>>
>> Then the schema needs fixing IMO
>>
>> > Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
>> > ---
>> > .../boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 15 +++++++--------
>> > 1 file changed, 7 insertions(+), 8 deletions(-)
>> >
>> > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
>> > index 9c05c83453f5..85257507206c 100644
>> > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
>> > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
>> > @@ -252,14 +252,6 @@ sound {
>> > "U19 INR", "ACODEC LORP",
>> > "Lineout", "U19 OUTL",
>> > "Lineout", "U19 OUTR";
>> > -
>> > - assigned-clocks = <&clkc CLKID_MPLL2>,
>> > - <&clkc CLKID_MPLL0>,
>> > - <&clkc CLKID_MPLL1>;
>> > - assigned-clock-parents = <0>, <0>, <0>;
>> > - assigned-clock-rates = <294912000>,
>> > - <270950400>,
>> > - <393216000>;
>> > status = "okay";
>> >
>> > dai-link-0 {
>> > @@ -365,6 +357,13 @@ &cecb_AO {
>> > };
>> >
>> > &clkc_audio {
>> > + assigned-clocks = <&clkc CLKID_MPLL2>,
>> > + <&clkc CLKID_MPLL0>,
>> > + <&clkc CLKID_MPLL1>;
>> > + assigned-clock-parents = <0>, <0>, <0>;
>> > + assigned-clock-rates = <294912000>,
>> > + <270950400>,
>> > + <393216000>;
>> > status = "okay";
>> > };
>>
>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] arm64: dts: meson-g12b-odroid-n2: move assigned-clocks
@ 2021-12-21 10:54 ` Jerome Brunet
0 siblings, 0 replies; 8+ messages in thread
From: Jerome Brunet @ 2021-12-21 10:54 UTC (permalink / raw)
To: Alexander Stein, Rob Herring, Neil Armstrong, Kevin Hilman,
Martin Blumenstingl
Cc: devicetree, linux-amlogic
On Sun 19 Dec 2021 at 10:56, Alexander Stein <alexander.stein@mailbox.org> wrote:
> Am Samstag, 18. Dezember 2021, 16:03:16 CET schrieb Jerome Brunet:
>>
>> On Sat 18 Dec 2021 at 15:26, Alexander Stein <alexander.stein@mailbox.org> wrote:
>>
>> > dtschema expects a 'clocks' property if 'assigned-clocks' is used, but
>> > 'sound' node does not.
>> > So move the MPLL[0-2] clock settings &clkc_audio which actually use them.
>>
>> No, this does not make sense.
>> The sound card needs the clocks set in such way - nothing else
>> The clock controller work just as well regarless of the clock rate
>>
>> Having a clock property or not does not change that
Also the documentation of assigned does not mandate that.
>
> Well, I checked what others did to fix this warning. So I did the same as in [1].
> Despite that, IMHO if you split 'assigned-clocks' for the same clock ´all
> over users who is gonna win?
1. This is explicitly forbidden by the assigned-clock binding documentation
2. Like other interfaces, it is likely a last write wins
The fact the ID assigned by the card and the one claimed controller are
the same is merely a coincidence. The ID assigned could very well have
been internal to the audio controller.
> Because the sound card needs the clocks set
> his way it is set, it is done in the same file.
If I push this logic further, I may as well put everything at root of DT,
or anywhere else, as long as it is in the same file and there is a clock
property for the schema. We could put it with uart, that would work ;)
(just kidding)
The cards needs these rate because of rate family we choose to support,
and how we choose to support them. This is where the assignment makes
sense.
>
> Best regards,
> Alexander
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4afb06afd76855932a2d19c983c013105f1cfb9a
>
>> > This fixes the dtschema warning:
>> > arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dt.yaml: sound: 'clocks' is a dependency of 'assigned-clocks'
>> >
>>
>> Then the schema needs fixing IMO
>>
>> > Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
>> > ---
>> > .../boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 15 +++++++--------
>> > 1 file changed, 7 insertions(+), 8 deletions(-)
>> >
>> > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
>> > index 9c05c83453f5..85257507206c 100644
>> > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
>> > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
>> > @@ -252,14 +252,6 @@ sound {
>> > "U19 INR", "ACODEC LORP",
>> > "Lineout", "U19 OUTL",
>> > "Lineout", "U19 OUTR";
>> > -
>> > - assigned-clocks = <&clkc CLKID_MPLL2>,
>> > - <&clkc CLKID_MPLL0>,
>> > - <&clkc CLKID_MPLL1>;
>> > - assigned-clock-parents = <0>, <0>, <0>;
>> > - assigned-clock-rates = <294912000>,
>> > - <270950400>,
>> > - <393216000>;
>> > status = "okay";
>> >
>> > dai-link-0 {
>> > @@ -365,6 +357,13 @@ &cecb_AO {
>> > };
>> >
>> > &clkc_audio {
>> > + assigned-clocks = <&clkc CLKID_MPLL2>,
>> > + <&clkc CLKID_MPLL0>,
>> > + <&clkc CLKID_MPLL1>;
>> > + assigned-clock-parents = <0>, <0>, <0>;
>> > + assigned-clock-rates = <294912000>,
>> > + <270950400>,
>> > + <393216000>;
>> > status = "okay";
>> > };
>>
>>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-12-21 12:34 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-18 14:26 [PATCH 1/1] arm64: dts: meson-g12b-odroid-n2: move assigned-clocks Alexander Stein
2021-12-18 14:26 ` Alexander Stein
2021-12-18 15:03 ` Jerome Brunet
2021-12-18 15:03 ` Jerome Brunet
2021-12-19 9:56 ` Alexander Stein
2021-12-19 9:56 ` Alexander Stein
2021-12-21 10:54 ` Jerome Brunet
2021-12-21 10:54 ` Jerome Brunet
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.