* [PATCH] sata_rcar: Remove ata_host_alloc() error printing
@ 2019-04-29 15:22 Geert Uytterhoeven
2019-04-30 7:59 ` Sergei Shtylyov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2019-04-29 15:22 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-ide, linux-renesas-soc, Geert Uytterhoeven
ata_host_alloc() can only fail due to memory allocation failures.
Hence there is no need to print a message, as the memory allocation core
code already takes care of that.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/ata/sata_rcar.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/ata/sata_rcar.c b/drivers/ata/sata_rcar.c
index 59b2317acea99e46..3495e1733a8e6756 100644
--- a/drivers/ata/sata_rcar.c
+++ b/drivers/ata/sata_rcar.c
@@ -909,7 +909,6 @@ static int sata_rcar_probe(struct platform_device *pdev)
host = ata_host_alloc(dev, 1);
if (!host) {
- dev_err(dev, "ata_host_alloc failed\n");
ret = -ENOMEM;
goto err_pm_put;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] sata_rcar: Remove ata_host_alloc() error printing
2019-04-29 15:22 [PATCH] sata_rcar: Remove ata_host_alloc() error printing Geert Uytterhoeven
@ 2019-04-30 7:59 ` Sergei Shtylyov
2019-05-09 12:59 ` Simon Horman
2019-05-09 17:19 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2019-04-30 7:59 UTC (permalink / raw)
To: Geert Uytterhoeven, Jens Axboe; +Cc: linux-ide, linux-renesas-soc
On 29.04.2019 18:22, Geert Uytterhoeven wrote:
> ata_host_alloc() can only fail due to memory allocation failures.
> Hence there is no need to print a message, as the memory allocation core
> code already takes care of that.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sata_rcar: Remove ata_host_alloc() error printing
2019-04-29 15:22 [PATCH] sata_rcar: Remove ata_host_alloc() error printing Geert Uytterhoeven
2019-04-30 7:59 ` Sergei Shtylyov
@ 2019-05-09 12:59 ` Simon Horman
2019-05-09 17:19 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2019-05-09 12:59 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Jens Axboe, linux-ide, linux-renesas-soc
On Mon, Apr 29, 2019 at 05:22:09PM +0200, Geert Uytterhoeven wrote:
> ata_host_alloc() can only fail due to memory allocation failures.
> Hence there is no need to print a message, as the memory allocation core
> code already takes care of that.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Jens, could you consider picking this one up?
> ---
> drivers/ata/sata_rcar.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/ata/sata_rcar.c b/drivers/ata/sata_rcar.c
> index 59b2317acea99e46..3495e1733a8e6756 100644
> --- a/drivers/ata/sata_rcar.c
> +++ b/drivers/ata/sata_rcar.c
> @@ -909,7 +909,6 @@ static int sata_rcar_probe(struct platform_device *pdev)
>
> host = ata_host_alloc(dev, 1);
> if (!host) {
> - dev_err(dev, "ata_host_alloc failed\n");
> ret = -ENOMEM;
> goto err_pm_put;
> }
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sata_rcar: Remove ata_host_alloc() error printing
2019-04-29 15:22 [PATCH] sata_rcar: Remove ata_host_alloc() error printing Geert Uytterhoeven
2019-04-30 7:59 ` Sergei Shtylyov
2019-05-09 12:59 ` Simon Horman
@ 2019-05-09 17:19 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2019-05-09 17:19 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: linux-ide, linux-renesas-soc
On 4/29/19 9:22 AM, Geert Uytterhoeven wrote:
> ata_host_alloc() can only fail due to memory allocation failures.
> Hence there is no need to print a message, as the memory allocation core
> code already takes care of that.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-09 17:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-29 15:22 [PATCH] sata_rcar: Remove ata_host_alloc() error printing Geert Uytterhoeven
2019-04-30 7:59 ` Sergei Shtylyov
2019-05-09 12:59 ` Simon Horman
2019-05-09 17:19 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.