All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: iwd@lists.01.org
Subject: Re: [PATCH 2/8] netdev: add netdev_get_station
Date: Mon, 11 Jan 2021 15:08:43 -0600	[thread overview]
Message-ID: <456b84ee-ab05-6a82-10a5-b00d20adedf7@gmail.com> (raw)
In-Reply-To: <0e4dd87f7c34ec5ffc5e7a3e04d3ce726bb98719.camel@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 652 bytes --]

Hi James,

>>> +int netdev_get_station(struct netdev *netdev, const uint8_t *mac,
>>
>> Do you want to add a convenience method to grab the current
>> station?  The mac
>> parameter is for cases where you might have multiple ones, like AP.
> 
> I could, although its not too bad just passing in handshake->aa... But
> if you want a current station API and a separate one for AP I don't
> mind either way.
> 

I was just thinking that you probably can keep this method and just add a 
wrapper (netdev_get_current_station or something) that would just call 
netdev_get_station appropriately.  But I'm fine either way.

Regards,
-Denis

  reply	other threads:[~2021-01-11 21:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-11 17:12 [PATCH 1/8] doc: diagnostic DBus interface definition James Prestwood
2021-01-11 17:12 ` [PATCH 2/8] netdev: add netdev_get_station James Prestwood
2021-01-11 20:49   ` Denis Kenzior
2021-01-11 20:54     ` James Prestwood
2021-01-11 21:08       ` Denis Kenzior [this message]
2021-01-11 17:12 ` [PATCH 3/8] netdev: update RSSI polling to use netdev_get_station James Prestwood
2021-01-11 17:12 ` [PATCH 4/8] netdev: parse rates in netdev_get_station James Prestwood
2021-01-11 17:12 ` [PATCH 5/8] dbus: add diagnostic interface definition James Prestwood
2021-01-11 20:52   ` Denis Kenzior
2021-01-11 17:12 ` [PATCH 6/8] netdev: parse expected throughput in netdev_get_station James Prestwood
2021-01-11 17:12 ` [PATCH 7/8] station: create StationDiagnostic interface James Prestwood
2021-01-11 21:04   ` Denis Kenzior
2021-01-11 17:12 ` [PATCH 8/8] test: add a script for GetDiagnostics James Prestwood
2021-01-11 20:51 ` [PATCH 1/8] doc: diagnostic DBus interface definition Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=456b84ee-ab05-6a82-10a5-b00d20adedf7@gmail.com \
    --to=denkenz@gmail.com \
    --cc=iwd@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.