From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: Kieran Bingham <kieran.bingham@ideasonboard.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCHv2 3/5] logger: Log to the FTrace buffer if tracing is enabled
Date: Mon, 13 Feb 2017 16:21:37 +0200 [thread overview]
Message-ID: <4577996.faKKJcSsZt@avalon> (raw)
In-Reply-To: <1480627909-19207-4-git-send-email-kieran.bingham+renesas@ideasonboard.com>
Hi Kieran,
Thank you for the patch.
On Thursday 01 Dec 2016 21:31:47 Kieran Bingham wrote:
> From: Kieran Bingham <kieran.bingham@ideasonboard.com>
>
> Extend the logger such that it will detect the tracing system, and also
> append print statement to this ring buffer.
>
> This provides the relevant logging output interspersed in the ftrace
> logs for an effective solution to identifying the actions that caused
> the traces to occur
>
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> scripts/logger.sh | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/logger.sh b/scripts/logger.sh
> index 8123f0c9f6e3..8412b0ba9a08 100755
> --- a/scripts/logger.sh
> +++ b/scripts/logger.sh
> @@ -6,6 +6,17 @@ now() {
>
> label=${1:+ [$1]}
>
> +TRACE_MARKER=/sys/kernel/debug/tracing/trace_marker
> +if [ -e $TRACE_MARKER ]; then
> + extra_log_files=$TRACE_MARKER
> +fi
> +
> while read line ; do
> - echo "$(now)$label $line"
> + newline="$(now)$label $line"
> +
> + echo "$newline"
> +
> + for f in $extra_log_files; do
> + echo "$newline" >> $f;
> + done;
> done
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2017-02-13 14:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 21:31 [PATCHv2 0/5] VSP-Tests: Add suspend resume tests and helpers Kieran Bingham
2016-12-01 21:31 ` [PATCHv2 1/5] scripts: Test suite runner Kieran Bingham
2017-02-13 13:15 ` Laurent Pinchart
2016-12-01 21:31 ` [PATCHv2 2/5] scripts: Provide bin2png.sh helper Kieran Bingham
2017-02-13 14:03 ` Laurent Pinchart
2017-02-13 14:17 ` Geert Uytterhoeven
2017-02-13 14:24 ` Laurent Pinchart
2017-02-20 17:47 ` Kieran Bingham
2017-02-20 20:45 ` Geert Uytterhoeven
2017-02-21 18:00 ` Kieran Bingham
2016-12-01 21:31 ` [PATCHv2 3/5] logger: Log to the FTrace buffer if tracing is enabled Kieran Bingham
2017-02-13 14:21 ` Laurent Pinchart [this message]
2016-12-01 21:31 ` [PATCHv2 4/5] tests: Test suspend/resume on idle pipelines Kieran Bingham
2016-12-01 21:31 ` [PATCHv2 5/5] tests: Test suspend/resume on active pipelines Kieran Bingham
2017-02-13 14:38 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4577996.faKKJcSsZt@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.