All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCHv2 2/5] scripts: Provide bin2png.sh helper
Date: Mon, 20 Feb 2017 21:45:34 +0100	[thread overview]
Message-ID: <CAMuHMdW658tmHBgU9az=YW3CLnB=+=jRFwV-8ChYiaDBbuvNXw@mail.gmail.com> (raw)
In-Reply-To: <7cc4fc1a-cd4b-a3ac-7450-48deffd30d27@ideasonboard.com>

Hi Kieran,

On Mon, Feb 20, 2017 at 6:47 PM, Kieran Bingham
<kieran.bingham@ideasonboard.com> wrote:
> This change breaks POSIX SH compliance, as reported by shellcheck:
>
> In scripts/bin2png.sh line 7:
>         local pnm=${file/%bin/pnm}
>                   ^-- SC2039: In POSIX sh, string replacement is not supported.
>
>
> In scripts/bin2png.sh line 8:
>         local png=${file/%bin/png}
>                   ^-- SC2039: In POSIX sh, string replacement is not supported.
>
> It also breaks on my system which uses a strict posix compliant shell :D

Does "local pnm=${file%bin}pnm" work?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2017-02-20 20:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-01 21:31 [PATCHv2 0/5] VSP-Tests: Add suspend resume tests and helpers Kieran Bingham
2016-12-01 21:31 ` [PATCHv2 1/5] scripts: Test suite runner Kieran Bingham
2017-02-13 13:15   ` Laurent Pinchart
2016-12-01 21:31 ` [PATCHv2 2/5] scripts: Provide bin2png.sh helper Kieran Bingham
2017-02-13 14:03   ` Laurent Pinchart
2017-02-13 14:17     ` Geert Uytterhoeven
2017-02-13 14:24       ` Laurent Pinchart
2017-02-20 17:47     ` Kieran Bingham
2017-02-20 20:45       ` Geert Uytterhoeven [this message]
2017-02-21 18:00         ` Kieran Bingham
2016-12-01 21:31 ` [PATCHv2 3/5] logger: Log to the FTrace buffer if tracing is enabled Kieran Bingham
2017-02-13 14:21   ` Laurent Pinchart
2016-12-01 21:31 ` [PATCHv2 4/5] tests: Test suspend/resume on idle pipelines Kieran Bingham
2016-12-01 21:31 ` [PATCHv2 5/5] tests: Test suspend/resume on active pipelines Kieran Bingham
2017-02-13 14:38   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdW658tmHBgU9az=YW3CLnB=+=jRFwV-8ChYiaDBbuvNXw@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.