* [PATCH] clk: samsung: exynos5433: Make use of the helper function devm_platform_ioremap_resource()
@ 2021-09-07 8:51 ` Cai Huoqing
0 siblings, 0 replies; 6+ messages in thread
From: Cai Huoqing @ 2021-09-07 8:51 UTC (permalink / raw)
To: caihuoqing
Cc: Sylwester Nawrocki, Tomasz Figa, Chanwoo Choi, Michael Turquette,
Stephen Boyd, Krzysztof Kozlowski, linux-samsung-soc, linux-clk,
linux-arm-kernel, linux-kernel
Use the devm_platform_ioremap_resource() helper instead of
calling platform_get_resource() and devm_ioremap_resource()
separately
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/clk/samsung/clk-exynos5433.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c
index f203074d858b..38bfffc5e5b3 100644
--- a/drivers/clk/samsung/clk-exynos5433.c
+++ b/drivers/clk/samsung/clk-exynos5433.c
@@ -5564,7 +5564,6 @@ static int __init exynos5433_cmu_probe(struct platform_device *pdev)
struct exynos5433_cmu_data *data;
struct samsung_clk_provider *ctx;
struct device *dev = &pdev->dev;
- struct resource *res;
void __iomem *reg_base;
int i;
@@ -5577,8 +5576,7 @@ static int __init exynos5433_cmu_probe(struct platform_device *pdev)
return -ENOMEM;
ctx = &data->ctx;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- reg_base = devm_ioremap_resource(dev, res);
+ reg_base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(reg_base))
return PTR_ERR(reg_base);
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: samsung: exynos5433: Make use of the helper function devm_platform_ioremap_resource()
2021-09-07 8:51 ` Cai Huoqing
@ 2021-09-07 12:28 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-07 12:28 UTC (permalink / raw)
To: Cai Huoqing
Cc: Sylwester Nawrocki, Tomasz Figa, Chanwoo Choi, Michael Turquette,
Stephen Boyd, linux-samsung-soc, linux-clk, linux-arm-kernel,
linux-kernel
On 07/09/2021 10:51, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> drivers/clk/samsung/clk-exynos5433.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: samsung: exynos5433: Make use of the helper function devm_platform_ioremap_resource()
@ 2021-09-07 12:28 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-07 12:28 UTC (permalink / raw)
To: Cai Huoqing
Cc: Sylwester Nawrocki, Tomasz Figa, Chanwoo Choi, Michael Turquette,
Stephen Boyd, linux-samsung-soc, linux-clk, linux-arm-kernel,
linux-kernel
On 07/09/2021 10:51, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> drivers/clk/samsung/clk-exynos5433.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: samsung: exynos5433: Make use of the helper function devm_platform_ioremap_resource()
2021-09-07 8:51 ` Cai Huoqing
@ 2021-09-13 16:13 ` Sylwester Nawrocki
-1 siblings, 0 replies; 6+ messages in thread
From: Sylwester Nawrocki @ 2021-09-13 16:13 UTC (permalink / raw)
To: Cai Huoqing
Cc: Tomasz Figa, Chanwoo Choi, Michael Turquette, Stephen Boyd,
Krzysztof Kozlowski, linux-samsung-soc, linux-clk,
linux-arm-kernel, linux-kernel
On 07.09.2021 10:51, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
Thanks for the patch. I have applied it with summary line shortened to
"clk: samsung: exynos5433: Make use of devm_platform_ioremap_resource()".
--
Regards,
Sylwester
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: samsung: exynos5433: Make use of the helper function devm_platform_ioremap_resource()
@ 2021-09-13 16:13 ` Sylwester Nawrocki
0 siblings, 0 replies; 6+ messages in thread
From: Sylwester Nawrocki @ 2021-09-13 16:13 UTC (permalink / raw)
To: Cai Huoqing
Cc: Tomasz Figa, Chanwoo Choi, Michael Turquette, Stephen Boyd,
Krzysztof Kozlowski, linux-samsung-soc, linux-clk,
linux-arm-kernel, linux-kernel
On 07.09.2021 10:51, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
Thanks for the patch. I have applied it with summary line shortened to
"clk: samsung: exynos5433: Make use of devm_platform_ioremap_resource()".
--
Regards,
Sylwester
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread