Fix XML output (with new libnetfilter_conntrack API)

Fix XML output (with new libnetfilter_conntrack API)

[Victor Stinner]

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

Hi,

I found a little mistake in new libnetfilter_conntrack API, in snprintf() code 
with XML output. I attached a patch to fix it.

Victor Stinner
http://www.inl.fr/

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: libnetfilter_conntrack_snprintf_xml.patch --]
[-- Type: text/x-diff; charset="us-ascii"; name="libnetfilter_conntrack_snprintf_xml.patch", Size: 654 bytes --]

Index: src/conntrack/snprintf_xml.c
===================================================================
--- src/conntrack/snprintf_xml.c	(révision 6716)
+++ src/conntrack/snprintf_xml.c	(copie de travail)
@@ -321,10 +321,10 @@
 			ret = snprintf(buf, len, "<flow type=\"new\">");
 			break;
 		case NFCT_T_UPDATE:
-			ret = snprintf(buf, len, "<flow type=\"update\"");
+			ret = snprintf(buf, len, "<flow type=\"update\">");
 			break;
 		case NFCT_T_DESTROY:
-			ret = snprintf(buf, len, "<flow type=\"destroy\"");
+			ret = snprintf(buf, len, "<flow type=\"destroy\">");
 			break;
 		default:
 			ret = snprintf(buf, len, "<flow>");

Re: Fix XML output (with new libnetfilter_conntrack API)

[Pablo Neira Ayuso]

Victor Stinner wrote:
> I found a little mistake in new libnetfilter_conntrack API, in snprintf() code 
> with XML output. I attached a patch to fix it.

Applied, thanks.

BTW, if you were familiar with XML stuff, I'd like to hear a second
opinion on the current layout.

-- 
The dawn of the fourth age of Linux firewalling is coming; a time of
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris