* [PATCH] ASoC: AMD: add missing include
@ 2016-01-11 12:13 ` Arnd Bergmann
0 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2016-01-11 12:13 UTC (permalink / raw)
To: broonie
Cc: lgirdwood, alsa-devel, linux-arm-kernel, linux-kernel,
Alex Deucher, Maruthi Srinivas Bayyavarapu,
Murali Krishna Vemuri
The newly added AMD acp driver is missing an include for linux/io.h
and fails to build on ARM:
sound/soc/amd/acp-pcm-dma.c: In function 'acp_reg_read':
sound/soc/amd/acp-pcm-dma.c:83:9: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
This adds the missing line.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
This build error also appeared today on linux-next with ARM randconfig
diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c
index cc8b841b69b6..fa0311e4faed 100644
--- a/sound/soc/amd/acp-pcm-dma.c
+++ b/sound/soc/amd/acp-pcm-dma.c
@@ -17,6 +17,7 @@
#include <linux/delay.h>
#include <linux/sizes.h>
#include <linux/pm_runtime.h>
+#include <linux/io.h>
#include <sound/soc.h>
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] ASoC: AMD: add missing include
@ 2016-01-11 12:13 ` Arnd Bergmann
0 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2016-01-11 12:13 UTC (permalink / raw)
To: broonie
Cc: alsa-devel, Maruthi Srinivas Bayyavarapu, lgirdwood,
linux-kernel, Alex Deucher, Murali Krishna Vemuri,
linux-arm-kernel
The newly added AMD acp driver is missing an include for linux/io.h
and fails to build on ARM:
sound/soc/amd/acp-pcm-dma.c: In function 'acp_reg_read':
sound/soc/amd/acp-pcm-dma.c:83:9: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
This adds the missing line.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
This build error also appeared today on linux-next with ARM randconfig
diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c
index cc8b841b69b6..fa0311e4faed 100644
--- a/sound/soc/amd/acp-pcm-dma.c
+++ b/sound/soc/amd/acp-pcm-dma.c
@@ -17,6 +17,7 @@
#include <linux/delay.h>
#include <linux/sizes.h>
#include <linux/pm_runtime.h>
+#include <linux/io.h>
#include <sound/soc.h>
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] ASoC: AMD: add missing include
@ 2016-01-11 12:13 ` Arnd Bergmann
0 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2016-01-11 12:13 UTC (permalink / raw)
To: linux-arm-kernel
The newly added AMD acp driver is missing an include for linux/io.h
and fails to build on ARM:
sound/soc/amd/acp-pcm-dma.c: In function 'acp_reg_read':
sound/soc/amd/acp-pcm-dma.c:83:9: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
This adds the missing line.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
This build error also appeared today on linux-next with ARM randconfig
diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c
index cc8b841b69b6..fa0311e4faed 100644
--- a/sound/soc/amd/acp-pcm-dma.c
+++ b/sound/soc/amd/acp-pcm-dma.c
@@ -17,6 +17,7 @@
#include <linux/delay.h>
#include <linux/sizes.h>
#include <linux/pm_runtime.h>
+#include <linux/io.h>
#include <sound/soc.h>
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: AMD: add missing include
2016-01-11 12:13 ` Arnd Bergmann
@ 2016-01-11 13:03 ` Mark Brown
-1 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2016-01-11 13:03 UTC (permalink / raw)
To: Arnd Bergmann
Cc: lgirdwood, alsa-devel, linux-arm-kernel, linux-kernel,
Alex Deucher, Maruthi Srinivas Bayyavarapu,
Murali Krishna Vemuri
[-- Attachment #1: Type: text/plain, Size: 198 bytes --]
On Mon, Jan 11, 2016 at 01:13:01PM +0100, Arnd Bergmann wrote:
> The newly added AMD acp driver is missing an include for linux/io.h
> and fails to build on ARM:
Guenter sent a fix for this first.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ASoC: AMD: add missing include
@ 2016-01-11 13:03 ` Mark Brown
0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2016-01-11 13:03 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jan 11, 2016 at 01:13:01PM +0100, Arnd Bergmann wrote:
> The newly added AMD acp driver is missing an include for linux/io.h
> and fails to build on ARM:
Guenter sent a fix for this first.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160111/e8289f5d/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-01-11 13:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-11 12:13 [PATCH] ASoC: AMD: add missing include Arnd Bergmann
2016-01-11 12:13 ` Arnd Bergmann
2016-01-11 12:13 ` Arnd Bergmann
2016-01-11 13:03 ` Mark Brown
2016-01-11 13:03 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.