All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Sriram Dash <sriram.dash@nxp.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	mathias.nyman@intel.com, gregkh@linuxfoundation.org,
	suresh.gupta@nxp.com, felipe.balbi@linux.intel.com,
	stern@rowland.harvard.edu, pku.leo@gmail.com
Subject: Re: [PATCH 3/3] usb: dwc3: host: Do not use dma_coerce_mask_and_coherent
Date: Tue, 25 Oct 2016 22:27:37 +0200	[thread overview]
Message-ID: <4598901.ugkIQYLvkL@wuerfel> (raw)
In-Reply-To: <1477392988-7253-4-git-send-email-sriram.dash@nxp.com>

On Tuesday, October 25, 2016 4:26:28 PM CEST Sriram Dash wrote:
> Do not use dma_coerce_mask_and_coherent for hcd.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

The patch is good, but please follow the usual rules for submitting
someone else's patch:

- As the first line, have "From: Arnd Bergmann <arnd@arndb.de>".
  "git format-patch" adds this automatically if you pass that
  address as the "--author" argument to "git commit".

- Add you "Signed-off-by" line at below mine (or any other lines)

I would also suggest a more elaborate changelog text, the
free-form text should explain why something is done, rather than
repeat the subject:

| The dma mask is correctly set up by the DT probe function, no
| need to override it any more.

	Arnd

  reply	other threads:[~2016-10-25 20:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-25 10:56 [PATCH 0/3] inherit dma configuration from parent dev Sriram Dash
2016-10-25 10:56 ` [PATCH 1/3] usb: dwc3: host: " Sriram Dash
2016-10-26  3:29   ` Peter Chen
2016-10-25 10:56 ` [PATCH 2/3] usb: dwc3: host: Do not use dma_set_coherent_mask Sriram Dash
2016-10-25 20:42   ` Arnd Bergmann
2016-10-27  5:29     ` Sriram Dash
2016-10-25 10:56 ` [PATCH 3/3] usb: dwc3: host: Do not use dma_coerce_mask_and_coherent Sriram Dash
2016-10-25 20:27   ` Arnd Bergmann [this message]
2016-10-27  5:28     ` Sriram Dash

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4598901.ugkIQYLvkL@wuerfel \
    --to=arnd@arndb.de \
    --cc=felipe.balbi@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=pku.leo@gmail.com \
    --cc=sriram.dash@nxp.com \
    --cc=stern@rowland.harvard.edu \
    --cc=suresh.gupta@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.