All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Magenheimer <dan.magenheimer@oracle.com>
To: Valdis.Kletnieks@vt.edu
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	jeremy@goop.org, hughd@google.com, ngupta@vflare.org,
	Konrad Wilk <konrad.wilk@oracle.com>,
	JBeulich@novell.com, Kurt Hackel <kurt.hackel@oracle.com>,
	npiggin@kernel.dk, akpm@linux-foundation.org, riel@redhat.com,
	hannes@cmpxchg.org, matthew@wil.cx,
	Chris Mason <chris.mason@oracle.com>,
	sjenning@linux.vnet.ibm.com, kamezawa.hiroyu@jp.fujitsu.com,
	jackdachef@gmail.com, cyclonusj@gmail.com,
	levinsasha928@gmail.com
Subject: RE: [PATCH V8 4/4] mm: frontswap: config and doc files
Date: Tue, 30 Aug 2011 14:51:39 -0700 (PDT)	[thread overview]
Message-ID: <4599ff4c-5273-4605-9a61-d26a9a6484fe@default> (raw)
In-Reply-To: <19213.1314737185@turing-police.cc.vt.edu>

> From: Valdis.Kletnieks@vt.edu [mailto:Valdis.Kletnieks@vt.edu]
> Subject: Re: [PATCH V8 4/4] mm: frontswap: config and doc files
> 
> On Mon, 29 Aug 2011 09:49:49 PDT, Dan Magenheimer said:
> 
> > --- linux/mm/Kconfig	2011-08-08 08:19:26.303686905 -0600
> > +++ frontswap/mm/Kconfig	2011-08-29 09:52:14.308745832 -0600
> > @@ -370,3 +370,20 @@ config CLEANCACHE
> >  	  in a negligible performance hit.
> >
> >  	  If unsure, say Y to enable cleancache
> > +
> > +config FRONTSWAP
> > +	bool "Enable frontswap to cache swap pages if tmem is present"
> > +	depends on SWAP
> > +	default n
> 
> > +
> > +	  If unsure, say Y to enable frontswap.
> 
> Am I the only guy who gets irked when the "default" doesn't match the
> "If unsure" suggestion?  :)  (and yes, I know we have guidelines for
> what the "default" should be...)

Hi Valdis --

Thanks for the review!

Count me as irked.  The default should be "y" because the
overhead is extremely tiny when not enabled at runtime by
a backend (though admittedly non-zero), but I got flamed by
Linus last time I tried that (for cleancache), so I'm not
going to try it for frontswap! :-)  The "if unsure" is the
best I can do for now to encourage distros to enable it.

Dan

WARNING: multiple messages have this Message-ID (diff)
From: Dan Magenheimer <dan.magenheimer@oracle.com>
To: Valdis.Kletnieks@vt.edu
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	jeremy@goop.org, hughd@google.com, ngupta@vflare.org,
	Konrad Wilk <konrad.wilk@oracle.com>,
	JBeulich@novell.com, Kurt Hackel <kurt.hackel@oracle.com>,
	npiggin@kernel.dk, akpm@linux-foundation.org, riel@redhat.com,
	hannes@cmpxchg.org, matthew@wil.cx,
	Chris Mason <chris.mason@oracle.com>,
	sjenning@linux.vnet.ibm.com, kamezawa.hiroyu@jp.fujitsu.com,
	jackdachef@gmail.com, cyclonusj@gmail.com,
	levinsasha928@gmail.com
Subject: RE: [PATCH V8 4/4] mm: frontswap: config and doc files
Date: Tue, 30 Aug 2011 14:51:39 -0700 (PDT)	[thread overview]
Message-ID: <4599ff4c-5273-4605-9a61-d26a9a6484fe@default> (raw)
In-Reply-To: <19213.1314737185@turing-police.cc.vt.edu>

> From: Valdis.Kletnieks@vt.edu [mailto:Valdis.Kletnieks@vt.edu]
> Subject: Re: [PATCH V8 4/4] mm: frontswap: config and doc files
> 
> On Mon, 29 Aug 2011 09:49:49 PDT, Dan Magenheimer said:
> 
> > --- linux/mm/Kconfig	2011-08-08 08:19:26.303686905 -0600
> > +++ frontswap/mm/Kconfig	2011-08-29 09:52:14.308745832 -0600
> > @@ -370,3 +370,20 @@ config CLEANCACHE
> >  	  in a negligible performance hit.
> >
> >  	  If unsure, say Y to enable cleancache
> > +
> > +config FRONTSWAP
> > +	bool "Enable frontswap to cache swap pages if tmem is present"
> > +	depends on SWAP
> > +	default n
> 
> > +
> > +	  If unsure, say Y to enable frontswap.
> 
> Am I the only guy who gets irked when the "default" doesn't match the
> "If unsure" suggestion?  :)  (and yes, I know we have guidelines for
> what the "default" should be...)

Hi Valdis --

Thanks for the review!

Count me as irked.  The default should be "y" because the
overhead is extremely tiny when not enabled at runtime by
a backend (though admittedly non-zero), but I got flamed by
Linus last time I tried that (for cleancache), so I'm not
going to try it for frontswap! :-)  The "if unsure" is the
best I can do for now to encourage distros to enable it.

Dan

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-08-30 23:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-29 16:49 [PATCH V8 4/4] mm: frontswap: config and doc files Dan Magenheimer
2011-08-29 16:49 ` Dan Magenheimer
2011-08-30 20:46 ` Valdis.Kletnieks
2011-08-30 21:51   ` Dan Magenheimer [this message]
2011-08-30 21:51     ` Dan Magenheimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4599ff4c-5273-4605-9a61-d26a9a6484fe@default \
    --to=dan.magenheimer@oracle.com \
    --cc=JBeulich@novell.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=akpm@linux-foundation.org \
    --cc=chris.mason@oracle.com \
    --cc=cyclonusj@gmail.com \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=jackdachef@gmail.com \
    --cc=jeremy@goop.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=konrad.wilk@oracle.com \
    --cc=kurt.hackel@oracle.com \
    --cc=levinsasha928@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=matthew@wil.cx \
    --cc=ngupta@vflare.org \
    --cc=npiggin@kernel.dk \
    --cc=riel@redhat.com \
    --cc=sjenning@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.