From: Gerd Hoffmann <kraxel@suse.de>
To: Markus Armbruster <armbru@redhat.com>
Cc: Xen devel list <xen-devel@lists.xensource.com>,
Keir Fraser <keir@xensource.com>
Subject: Re: 32-on-64: pvfb issue
Date: Wed, 24 Jan 2007 13:38:27 +0100 [thread overview]
Message-ID: <45B75343.1090409@suse.de> (raw)
In-Reply-To: <87sle0obnw.fsf@pike.pond.sub.org>
Hi,
>> @@ -560,10 +560,10 @@ int xenfb_attach_dom(struct xenfb *xenfb
>> if (xenfb_wait_for_frontend_initialised(&xenfb->kbd) < 0)
>> goto error;
>>
>> - if (xenfb_bind(&xenfb->fb) < 0)
>> - goto error;
>> if (xenfb_bind(&xenfb->kbd) < 0)
>> goto error;
>> + if (xenfb_bind(&xenfb->fb) < 0)
>> + goto error;
>>
>> if (xenfb_xs_scanf1(xsh, xenfb->fb.otherend, "feature-update",
>> "%d", &val) < 0)
>
> Why is this patch hunk necessary?
Oh, forgot to mention that, sorry. Only vfb has a "protocol" node, vkbd
hasn't. So binding fb last makes sure we have the protocol filled
correctly in the struct.
cheers,
Gerd
--
Gerd Hoffmann <kraxel@suse.de>
next prev parent reply other threads:[~2007-01-24 12:38 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-18 13:57 32-on-64: pvfb issue Gerd Hoffmann
2007-01-18 14:07 ` Keir Fraser
2007-01-18 15:00 ` Markus Armbruster
2007-01-18 15:35 ` Gerd Hoffmann
2007-01-18 15:53 ` Daniel P. Berrange
2007-01-18 16:34 ` Gerd Hoffmann
2007-01-18 16:55 ` Gerd Hoffmann
2007-01-18 17:05 ` Daniel P. Berrange
2007-01-18 18:31 ` Keir Fraser
2007-01-19 9:46 ` Gerd Hoffmann
2007-01-19 9:54 ` Gerd Hoffmann
2007-01-19 10:31 ` Markus Armbruster
2007-01-19 10:46 ` Gerd Hoffmann
2007-01-19 11:53 ` Markus Armbruster
2007-01-19 11:10 ` Keir Fraser
2007-01-19 11:43 ` Gerd Hoffmann
2007-01-19 12:01 ` Keir Fraser
2007-01-19 12:59 ` Gerd Hoffmann
2007-01-19 13:45 ` Keir Fraser
2007-01-19 15:08 ` Gerd Hoffmann
2007-01-19 15:22 ` Keir Fraser
2007-01-19 15:31 ` Gerd Hoffmann
2007-01-19 16:05 ` Keir Fraser
2007-01-20 0:09 ` [Patch] [VTPM_TOOLS] Add HVM support to vtpm_manager Scarlata, Vincent R
2007-01-22 7:50 ` 32-on-64: pvfb issue Gerd Hoffmann
2007-01-22 14:01 ` Gerd Hoffmann
2007-01-22 14:48 ` Keir Fraser
2007-01-23 12:53 ` Gerd Hoffmann
2007-01-23 15:07 ` Keir Fraser
2007-01-23 15:56 ` Gerd Hoffmann
2007-01-24 11:23 ` Gerd Hoffmann
2007-01-24 12:02 ` Keir Fraser
2007-01-24 12:24 ` Markus Armbruster
2007-01-24 12:38 ` Gerd Hoffmann [this message]
2007-01-24 14:24 ` Markus Armbruster
2007-01-24 15:25 ` Gerd Hoffmann
2007-01-25 13:16 ` 32-on-64 broken in unstable Gerd Hoffmann
2007-01-25 13:25 ` Keir Fraser
2007-01-25 13:34 ` Gerd Hoffmann
2007-01-22 15:22 ` 32-on-64: pvfb issue Markus Armbruster
2007-01-22 15:33 ` Gerd Hoffmann
2007-01-22 15:40 ` Keir Fraser
2007-01-19 16:06 ` Markus Armbruster
2007-01-22 7:56 ` Gerd Hoffmann
2007-01-19 10:43 ` Ian Campbell
2007-01-19 12:03 ` Markus Armbruster
2007-01-22 18:32 ` Does vt-x itself have perf. impact on Hypervisor w/o considering HVM? Liang Yang
2007-01-23 10:05 ` [Xen-users] " Petersson, Mats
2007-01-23 16:15 ` Liang Yang
2007-01-23 16:33 ` Petersson, Mats
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45B75343.1090409@suse.de \
--to=kraxel@suse.de \
--cc=armbru@redhat.com \
--cc=keir@xensource.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.