[PATCH] mmc: au1xmmc: return errors for unknown response types

[PATCH] mmc: au1xmmc: return errors for unknown response types

[Manuel Lauss]

au1xmmc: return error when encountering unhandled/unknown response type.

Signed-off-by: Manuel Lauss <mano@roarinelk.homelinux.net>

--- a/drivers/mmc/au1xmmc.c.orig	2007-01-25 09:56:10.851983000 +0100
+++ b/drivers/mmc/au1xmmc.c	2007-01-25 10:13:12.121983000 +0100
@@ -193,6 +194,8 @@ static int au1xmmc_send_command(struct a
 	u32 mmccmd = (cmd->opcode << SD_CMD_CI_SHIFT);
 
 	switch (mmc_resp_type(cmd)) {
+	case MMC_RSP_NONE:
+		break;
 	case MMC_RSP_R1:
 		mmccmd |= SD_CMD_RT_1;
 		break;
@@ -205,6 +208,10 @@ static int au1xmmc_send_command(struct a
 	case MMC_RSP_R3:
 		mmccmd |= SD_CMD_RT_3;
 		break;
+	default:
+		printk(KERN_INFO "au1xmmc: unhandled response type %02x\n",
+			mmc_resp_type(cmd));
+		return MMC_ERR_INVALID;
 	}
 
 	switch(cmd->opcode) {

Re: [PATCH] mmc: au1xmmc: return errors for unknown response types

[Pierre Ossman]

Manuel Lauss wrote:
> au1xmmc: return error when encountering unhandled/unknown response type.
> 
> Signed-off-by: Manuel Lauss <mano@roarinelk.homelinux.net>
> 

Thanks, applied.

-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org