* new -xen.c files in sparse tree
@ 2007-02-08 10:22 Jan Beulich
2007-02-08 15:30 ` Keir Fraser
0 siblings, 1 reply; 5+ messages in thread
From: Jan Beulich @ 2007-02-08 10:22 UTC (permalink / raw)
To: xen-devel
What is the purpose of adding arch/i386/kernel/alternative-xen.c, when the
delta to native is a single line?
Even more funny - arch/i386/kernel/intel_cacheinfo-xen.c doesn't show any
difference to native...
Shouldn't we try to reduce the number of such files, to ease maintaining them?
Jan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: new -xen.c files in sparse tree
2007-02-08 10:22 new -xen.c files in sparse tree Jan Beulich
@ 2007-02-08 15:30 ` Keir Fraser
2007-02-09 1:16 ` Horms
0 siblings, 1 reply; 5+ messages in thread
From: Keir Fraser @ 2007-02-08 15:30 UTC (permalink / raw)
To: Jan Beulich, xen-devel
Empty files can certainly be removed. Where there's any diff at all, it's a
matter of taste whether we have separate files or ifdef XEN.
-- Keir
On 8/2/07 10:22, "Jan Beulich" <jbeulich@novell.com> wrote:
> What is the purpose of adding arch/i386/kernel/alternative-xen.c, when the
> delta to native is a single line?
>
> Even more funny - arch/i386/kernel/intel_cacheinfo-xen.c doesn't show any
> difference to native...
>
> Shouldn't we try to reduce the number of such files, to ease maintaining them?
>
> Jan
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: new -xen.c files in sparse tree
2007-02-08 15:30 ` Keir Fraser
@ 2007-02-09 1:16 ` Horms
2007-02-09 16:12 ` Keir Fraser
0 siblings, 1 reply; 5+ messages in thread
From: Horms @ 2007-02-09 1:16 UTC (permalink / raw)
To: Keir Fraser; +Cc: xen-devel, Jan Beulich
On Thu, Feb 08, 2007 at 03:30:29PM +0000, Keir Fraser wrote:
> Empty files can certainly be removed. Where there's any diff at all, it's a
> matter of taste whether we have separate files or ifdef XEN.
IMHO there are two many ways of cooking this egg.
Patch vs Sparse + ifdef XEN vs separate file
Finding the code can be kind of tricky,
and working out the best way to implement a change seems to be a black art.
Can't this be simplified?
(I'll refrain from saxing axe sparse... oops, I didn't)
--
Horms
H: http://www.vergenet.net/~horms/
W: http://www.valinux.co.jp/en/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: new -xen.c files in sparse tree
2007-02-09 1:16 ` Horms
@ 2007-02-09 16:12 ` Keir Fraser
2007-02-10 2:56 ` Horms
0 siblings, 1 reply; 5+ messages in thread
From: Keir Fraser @ 2007-02-09 16:12 UTC (permalink / raw)
To: Horms; +Cc: xen-devel, Jan Beulich
On 9/2/07 1:16 am, "Horms" <horms@verge.net.au> wrote:
> IMHO there are two many ways of cooking this egg.
>
> Patch vs Sparse + ifdef XEN vs separate file
>
> Finding the code can be kind of tricky,
> and working out the best way to implement a change seems to be a black art.
>
> Can't this be simplified?
>
> (I'll refrain from saxing axe sparse... oops, I didn't)
Getting rid of the Linux tree from xen-unstable, and maintaining a full
Linux repo in its place, is still planned for the next release.
-- Keir
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: new -xen.c files in sparse tree
2007-02-09 16:12 ` Keir Fraser
@ 2007-02-10 2:56 ` Horms
0 siblings, 0 replies; 5+ messages in thread
From: Horms @ 2007-02-10 2:56 UTC (permalink / raw)
To: Keir Fraser; +Cc: xen-devel, Jan Beulich
On Fri, Feb 09, 2007 at 04:12:16PM +0000, Keir Fraser wrote:
>
>
>
> On 9/2/07 1:16 am, "Horms" <horms@verge.net.au> wrote:
>
> > IMHO there are two many ways of cooking this egg.
> >
> > Patch vs Sparse + ifdef XEN vs separate file
> >
> > Finding the code can be kind of tricky,
> > and working out the best way to implement a change seems to be a black art.
> >
> > Can't this be simplified?
> >
> > (I'll refrain from saxing axe sparse... oops, I didn't)
>
> Getting rid of the Linux tree from xen-unstable, and maintaining a full
> Linux repo in its place, is still planned for the next release.
Great.
--
Horms
H: http://www.vergenet.net/~horms/
W: http://www.valinux.co.jp/en/
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-02-10 2:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-08 10:22 new -xen.c files in sparse tree Jan Beulich
2007-02-08 15:30 ` Keir Fraser
2007-02-09 1:16 ` Horms
2007-02-09 16:12 ` Keir Fraser
2007-02-10 2:56 ` Horms
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.