* vgacon disable again
@ 2007-02-13 10:54 Gerd Hoffmann
2007-02-13 11:18 ` Gerd Hoffmann
0 siblings, 1 reply; 5+ messages in thread
From: Gerd Hoffmann @ 2007-02-13 10:54 UTC (permalink / raw)
To: Virtualization Mailing List
[-- Attachment #1: Type: text/plain, Size: 94 bytes --]
Hi,
The much easier fix is this one ;)
cheers,
Gerd
--
Gerd Hoffmann <kraxel@suse.de>
[-- Attachment #2: vgacon --]
[-- Type: text/plain, Size: 759 bytes --]
---
drivers/video/console/vgacon.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: paravirt-2.6.20-hg749/drivers/video/console/vgacon.c
===================================================================
--- paravirt-2.6.20-hg749.orig/drivers/video/console/vgacon.c
+++ paravirt-2.6.20-hg749/drivers/video/console/vgacon.c
@@ -372,7 +372,8 @@ static const char *vgacon_startup(void)
}
/* VGA16 modes are not handled by VGACON */
- if ((ORIG_VIDEO_MODE == 0x0D) || /* 320x200/4 */
+ if ((ORIG_VIDEO_MODE == 0x00) || /* not set */
+ (ORIG_VIDEO_MODE == 0x0D) || /* 320x200/4 */
(ORIG_VIDEO_MODE == 0x0E) || /* 640x200/4 */
(ORIG_VIDEO_MODE == 0x10) || /* 640x350/4 */
(ORIG_VIDEO_MODE == 0x12) || /* 640x480/4 */
[-- Attachment #3: Type: text/plain, Size: 165 bytes --]
_______________________________________________
Virtualization mailing list
Virtualization@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: vgacon disable again
2007-02-13 10:54 vgacon disable again Gerd Hoffmann
@ 2007-02-13 11:18 ` Gerd Hoffmann
2007-02-13 21:54 ` Jeremy Fitzhardinge
0 siblings, 1 reply; 5+ messages in thread
From: Gerd Hoffmann @ 2007-02-13 11:18 UTC (permalink / raw)
To: Virtualization Mailing List
Gerd Hoffmann wrote:
> Hi,
>
> The much easier fix is this one ;)
Oh, and it obsoletes vgacon-fix-zero-size.patch btw ...
cheers,
Gerd
--
Gerd Hoffmann <kraxel@suse.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: vgacon disable again
2007-02-13 11:18 ` Gerd Hoffmann
@ 2007-02-13 21:54 ` Jeremy Fitzhardinge
2007-02-14 8:07 ` Gerd Hoffmann
0 siblings, 1 reply; 5+ messages in thread
From: Jeremy Fitzhardinge @ 2007-02-13 21:54 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: Virtualization Mailing List
Gerd Hoffmann wrote:
> Oh, and it obsoletes vgacon-fix-zero-size.patch btw ...
>
Well, I think the zero-size allocation oops is a bug anyway. But is it
really necessary to disable VGA beyond that?
J
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: vgacon disable again
2007-02-13 21:54 ` Jeremy Fitzhardinge
@ 2007-02-14 8:07 ` Gerd Hoffmann
2007-02-14 10:52 ` Jeremy Fitzhardinge
0 siblings, 1 reply; 5+ messages in thread
From: Gerd Hoffmann @ 2007-02-14 8:07 UTC (permalink / raw)
To: Jeremy Fitzhardinge; +Cc: Virtualization Mailing List
Jeremy Fitzhardinge wrote:
> Gerd Hoffmann wrote:
>> Oh, and it obsoletes vgacon-fix-zero-size.patch btw ...
>>
>
> Well, I think the zero-size allocation oops is a bug anyway. But is it
> really necessary to disable VGA beyond that?
Yes, it is. Otherwise it oopses as soon as something is printed on
/dev/tty<any>. Quite early at boot with "console=tty1", otherwise as
soon as /sbin/getty starts on /dev/tty1. Oh, and the reason is it
thinks it has an EGA card with 0 lines and 0 columns because we never
ran the real-mode boot code and thus SCREEN_INFO isn't initialized. The
0x0 screen probably leads to the zero-sized buffer you are catching in
that patch.
cheers,
Gerd
--
Gerd Hoffmann <kraxel@suse.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-02-14 10:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-13 10:54 vgacon disable again Gerd Hoffmann
2007-02-13 11:18 ` Gerd Hoffmann
2007-02-13 21:54 ` Jeremy Fitzhardinge
2007-02-14 8:07 ` Gerd Hoffmann
2007-02-14 10:52 ` Jeremy Fitzhardinge
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.