* [PATCH] sata_mv: fix pci_enable_msi() error handling
@ 2007-02-24 6:12 Tejun Heo
2007-02-25 1:52 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2007-02-24 6:12 UTC (permalink / raw)
To: Jeff Garzik, linux-ide
intx should be turned on when pci_enable_msi() fails not when it
succeeds. Fix it.
Signed-off-by: Tejun Heo <htejun@gmail.com>
diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index 06867b9..d724bc7 100644
--- a/drivers/ata/sata_mv.c
+++ b/drivers/ata/sata_mv.c
@@ -2347,7 +2347,7 @@ static int mv_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
return rc;
/* Enable interrupts */
- if (msi && !pci_enable_msi(pdev))
+ if (msi && pci_enable_msi(pdev))
pci_intx(pdev, 1);
mv_dump_pci_cfg(pdev, 0x68);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sata_mv: fix pci_enable_msi() error handling
2007-02-24 6:12 [PATCH] sata_mv: fix pci_enable_msi() error handling Tejun Heo
@ 2007-02-25 1:52 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-02-25 1:52 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-ide
Tejun Heo wrote:
> intx should be turned on when pci_enable_msi() fails not when it
> succeeds. Fix it.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
>
> diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
> index 06867b9..d724bc7 100644
> --- a/drivers/ata/sata_mv.c
> +++ b/drivers/ata/sata_mv.c
> @@ -2347,7 +2347,7 @@ static int mv_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> return rc;
>
> /* Enable interrupts */
> - if (msi && !pci_enable_msi(pdev))
> + if (msi && pci_enable_msi(pdev))
> pci_intx(pdev, 1);
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-02-25 1:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-24 6:12 [PATCH] sata_mv: fix pci_enable_msi() error handling Tejun Heo
2007-02-25 1:52 ` Jeff Garzik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.