Should rm_work be moved after do_deploy, or is ${WORKDIR} not available in do_deploy?

Should rm_work be moved after do_deploy, or is ${WORKDIR} not available in do_deploy?

[Rod Whitby]

[Follow-ups to openembedded-devel@lists.openembedded.org only, please.]

A question for the OE core team representatives on the list:  Is
do_deploy prohibited from being able to get at things in ${WORKDIR}, or
should rm_work happen after do_deploy?

Details follow:

There is this neat rm_work.bbclass in OpenEmbedded which removes each
individual build/tmp/work/... directory as each package is successfully
built (this saves a *lot* of space, especially with the openmoko svnnow
paradigm which will quickly fill your disk with multiple build copies of
openmoko packages).

Unfortunately (at least with bitbake 1.6 head), rm_work is called before
do_deploy, so the do_deploy() function in OpenMoko's
sjf2410-linux-native.bb fails:

do_deploy() {
        install -d ${DEPLOY_DIR_IMAGE}
        install -m 0755 sjf2410 ${DEPLOY_DIR_IMAGE}/sjf2410
}

The sjf2410 executable no longer exists at that point, cause rm_work has
deleted it.

Should rm_work be moved to after do_deploy, or should
sjf2410-linux-native.bb (and all other packages that assume that the
contents of ${WORKDIR} are still available in do_deploy) be fixed?

(For example, the same problem occurs in ixp4xx-kernel ...)

-- Rod

Re: Should rm_work be moved after do_deploy, or is ${WORKDIR} not available in do_deploy?

[Rod Whitby]

Rod Whitby wrote:
> A question for the OE core team representatives on the list:  Is
> do_deploy prohibited from being able to get at things in ${WORKDIR}, or
> should rm_work happen after do_deploy?

Never mind - it was simply the fact that do_deploy is badly placed in
sjf2410-linux-native.bb, nothing to do with base OE or bitbake
functionality.

Reported as
http://bugzilla.openmoko.org/cgi-bin/bugzilla/show_bug.cgi?id=211
and work-around added to MokoMakefile.

Sorry for the noise.

-- Rod

Re: Should rm_work be moved after do_deploy, or is ${WORKDIR} not available in do_deploy?

[Richard Purdie]

On Sun, 2007-02-25 at 20:51 +1030, Rod Whitby wrote:
> Rod Whitby wrote:
> > A question for the OE core team representatives on the list:  Is
> > do_deploy prohibited from being able to get at things in ${WORKDIR}, or
> > should rm_work happen after do_deploy?
> 
> Never mind - it was simply the fact that do_deploy is badly placed in
> sjf2410-linux-native.bb, nothing to do with base OE or bitbake
> functionality.
> 
> Reported as
> http://bugzilla.openmoko.org/cgi-bin/bugzilla/show_bug.cgi?id=211
> and work-around added to MokoMakefile.
> 
> Sorry for the noise.

addtask deploy before do_build after do_compile

is actually correct as far as dependencies go but interacts badly with
rm_work.

This raises a long standing issue. do_rm_work should run as the last
task, just before do_build. Currently we have difficulty in inserting
that task into the task structure since the do_deploy isn't always
defined. The planned solution is to allow syntax like:

addtask rm_work after do_package do_deploy

and then lots of these tricky ordering issues can be solved in an easier
way. I've not remembered about this at the right time to implement it so
far though...

Cheers,

Richard