[PATCH] connman: mark connman-wait-online as SYSTEMD_PACKAGE

[PATCH] connman: mark connman-wait-online as SYSTEMD_PACKAGE

[André Draszik]

The connman-wait-online package currently isn't marked as
systemd-enabled package. This means it is impossible to
auto-enable the service during image creation or package
installation, as no preset files and no pkg_postinst()
snippet is being created.

This change should have been done as part of the
upgrade to v1.31

Note:
connman-wait-online is needed when connman is in use
in more complex network/interface setups for systemd's
network-online.target to report success.
systemd-networkd's systemd-networkd-wait-online.service
alone doesn't work in such scenarios and simply times
out, as it know nothing about the expected network/
interface configuration, meaning the target doesn't
boot successfully (systemctl list-units --failed),
and long delays are seen, caused by waiting for the
systemd-networkd-wait-online.service timeout.

Signed-off-by: André Draszik <git@andred.net>
---
 meta/recipes-connectivity/connman/connman.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
index ee00479926..fb38ab4fc1 100644
--- a/meta/recipes-connectivity/connman/connman.inc
+++ b/meta/recipes-connectivity/connman/connman.inc
@@ -59,7 +59,7 @@ INITSCRIPT_NAME = "connman"
 INITSCRIPT_PARAMS = "start 05 5 2 3 . stop 22 0 1 6 ."
 
 python __anonymous () {
-    systemd_packages = "${PN}"
+    systemd_packages = "${PN} ${PN}-wait-online"
     pkgconfig = d.getVar('PACKAGECONFIG')
     if ('openvpn' or 'vpnc' or 'l2tp' or 'pptp') in pkgconfig.split():
         systemd_packages += " ${PN}-vpn"
-- 
2.23.0.rc1

Re: [PATCH] connman: mark connman-wait-online as SYSTEMD_PACKAGE

[akuster808]

On 10/21/19 3:46 AM, André Draszik wrote:
> The connman-wait-online package currently isn't marked as
> systemd-enabled package. This means it is impossible to
> auto-enable the service during image creation or package
> installation, as no preset files and no pkg_postinst()
> snippet is being created.
>
> This change should have been done as part of the
> upgrade to v1.31

With backport to zeus?

- armin
>
> Note:
> connman-wait-online is needed when connman is in use
> in more complex network/interface setups for systemd's
> network-online.target to report success.
> systemd-networkd's systemd-networkd-wait-online.service
> alone doesn't work in such scenarios and simply times
> out, as it know nothing about the expected network/
> interface configuration, meaning the target doesn't
> boot successfully (systemctl list-units --failed),
> and long delays are seen, caused by waiting for the
> systemd-networkd-wait-online.service timeout.
>
> Signed-off-by: André Draszik <git@andred.net>
> ---
>  meta/recipes-connectivity/connman/connman.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
> index ee00479926..fb38ab4fc1 100644
> --- a/meta/recipes-connectivity/connman/connman.inc
> +++ b/meta/recipes-connectivity/connman/connman.inc
> @@ -59,7 +59,7 @@ INITSCRIPT_NAME = "connman"
>  INITSCRIPT_PARAMS = "start 05 5 2 3 . stop 22 0 1 6 ."
>  
>  python __anonymous () {
> -    systemd_packages = "${PN}"
> +    systemd_packages = "${PN} ${PN}-wait-online"
>      pkgconfig = d.getVar('PACKAGECONFIG')
>      if ('openvpn' or 'vpnc' or 'l2tp' or 'pptp') in pkgconfig.split():
>          systemd_packages += " ${PN}-vpn"

Re: [PATCH] connman: mark connman-wait-online as SYSTEMD_PACKAGE

[André Draszik]

On Mon, 2019-10-21 at 07:51 -0700, akuster808 wrote:
> 
> On 10/21/19 3:46 AM, André Draszik wrote:
> > The connman-wait-online package currently isn't marked as
> > systemd-enabled package. This means it is impossible to
> > auto-enable the service during image creation or package
> > installation, as no preset files and no pkg_postinst()
> > snippet is being created.
> > 
> > This change should have been done as part of the
> > upgrade to v1.31
> 
> With backport to zeus?

I'd say so (once merged).

Cheers,
Andre'

> 
> - armin
> > Note:
> > connman-wait-online is needed when connman is in use
> > in more complex network/interface setups for systemd's
> > network-online.target to report success.
> > systemd-networkd's systemd-networkd-wait-online.service
> > alone doesn't work in such scenarios and simply times
> > out, as it know nothing about the expected network/
> > interface configuration, meaning the target doesn't
> > boot successfully (systemctl list-units --failed),
> > and long delays are seen, caused by waiting for the
> > systemd-networkd-wait-online.service timeout.
> > 
> > Signed-off-by: André Draszik <git@andred.net>
> > ---
> >  meta/recipes-connectivity/connman/connman.inc | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
> > index ee00479926..fb38ab4fc1 100644
> > --- a/meta/recipes-connectivity/connman/connman.inc
> > +++ b/meta/recipes-connectivity/connman/connman.inc
> > @@ -59,7 +59,7 @@ INITSCRIPT_NAME = "connman"
> >  INITSCRIPT_PARAMS = "start 05 5 2 3 . stop 22 0 1 6 ."
> >  
> >  python __anonymous () {
> > -    systemd_packages = "${PN}"
> > +    systemd_packages = "${PN} ${PN}-wait-online"
> >      pkgconfig = d.getVar('PACKAGECONFIG')
> >      if ('openvpn' or 'vpnc' or 'l2tp' or 'pptp') in pkgconfig.split():
> >          systemd_packages += " ${PN}-vpn"