All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Rosin <peda@axentia.se>
To: Andrew Morton <akpm@linux-foundation.org>,
	kernel test robot <lkp@intel.com>
Cc: Rikard Falkeborn <rikard.falkeborn@gmail.com>,
	kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	Linux Memory Management List <linux-mm@kvack.org>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Kees Cook <keescook@chromium.org>
Subject: Re: include/linux/bits.h:25:21: error: first argument to '__builtin_choose_expr' not a constant
Date: Wed, 12 Aug 2020 15:37:38 +0200	[thread overview]
Message-ID: <45c8ced5-799b-759b-600f-f1ee752cf13d@axentia.se> (raw)
In-Reply-To: <20200810212756.04c006476aa9c663edb01f32@linux-foundation.org>

On 2020-08-11 06:27, Andrew Morton wrote:
> On Sat, 8 Aug 2020 08:03:38 +0800 kernel test robot <lkp@intel.com> wrote:
> 
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head:   30185b69a2d533c4ba6ca926b8390ce7de495e29
>> commit: 295bcca84916cb5079140a89fccb472bb8d1f6e2 linux/bits.h: add compile time sanity check of GENMASK inputs
>> date:   4 months ago
>> config: s390-randconfig-r001-20200808 (attached as .config)
>> compiler: s390-linux-gcc (GCC) 9.3.0
>> reproduce (this is a W=1 build):
>>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>         chmod +x ~/bin/make.cross
>>         git checkout 295bcca84916cb5079140a89fccb472bb8d1f6e2
>>         # save the attached .config to linux build tree
>>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390 
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> All errors (new ones prefixed by >>):
>>
>>    drivers/mux/mmio.c: In function 'mux_mmio_probe':
>>    drivers/mux/mmio.c:76:20: error: storage size of 'field' isn't known
>>       76 |   struct reg_field field;
>>          |                    ^~~~~
>>    In file included from include/linux/bits.h:23,
>>                     from include/linux/bitops.h:5,
>>                     from drivers/mux/mmio.c:8:
>>>> include/linux/bits.h:25:21: error: first argument to '__builtin_choose_expr' not a constant
> 
> I assume the first error is the cause of the second?
> 
> struct reg_field is only defined if CONFIG_REGMAP, and that is unset in
> this .config.  Perhaps drivers/mux/mmio.c should depend on
> CONFIG_REGMAP?  (cc Peter).
> 
> 

Thanks for the CC, and yes, that sounds about right. If it shouldn't
just "select REGMAP" instead?

I'm not sure when one should "select" and when one should "depends on"?

Cheers,
Peter

WARNING: multiple messages have this Message-ID (diff)
From: Peter Rosin <peda@axentia.se>
To: kbuild-all@lists.01.org
Subject: Re: include/linux/bits.h:25:21: error: first argument to '__builtin_choose_expr' not a constant
Date: Wed, 12 Aug 2020 15:37:38 +0200	[thread overview]
Message-ID: <45c8ced5-799b-759b-600f-f1ee752cf13d@axentia.se> (raw)
In-Reply-To: <20200810212756.04c006476aa9c663edb01f32@linux-foundation.org>

[-- Attachment #1: Type: text/plain, Size: 1983 bytes --]

On 2020-08-11 06:27, Andrew Morton wrote:
> On Sat, 8 Aug 2020 08:03:38 +0800 kernel test robot <lkp@intel.com> wrote:
> 
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head:   30185b69a2d533c4ba6ca926b8390ce7de495e29
>> commit: 295bcca84916cb5079140a89fccb472bb8d1f6e2 linux/bits.h: add compile time sanity check of GENMASK inputs
>> date:   4 months ago
>> config: s390-randconfig-r001-20200808 (attached as .config)
>> compiler: s390-linux-gcc (GCC) 9.3.0
>> reproduce (this is a W=1 build):
>>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>         chmod +x ~/bin/make.cross
>>         git checkout 295bcca84916cb5079140a89fccb472bb8d1f6e2
>>         # save the attached .config to linux build tree
>>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390 
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> All errors (new ones prefixed by >>):
>>
>>    drivers/mux/mmio.c: In function 'mux_mmio_probe':
>>    drivers/mux/mmio.c:76:20: error: storage size of 'field' isn't known
>>       76 |   struct reg_field field;
>>          |                    ^~~~~
>>    In file included from include/linux/bits.h:23,
>>                     from include/linux/bitops.h:5,
>>                     from drivers/mux/mmio.c:8:
>>>> include/linux/bits.h:25:21: error: first argument to '__builtin_choose_expr' not a constant
> 
> I assume the first error is the cause of the second?
> 
> struct reg_field is only defined if CONFIG_REGMAP, and that is unset in
> this .config.  Perhaps drivers/mux/mmio.c should depend on
> CONFIG_REGMAP?  (cc Peter).
> 
> 

Thanks for the CC, and yes, that sounds about right. If it shouldn't
just "select REGMAP" instead?

I'm not sure when one should "select" and when one should "depends on"?

Cheers,
Peter

  reply	other threads:[~2020-08-12 13:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-08  0:03 include/linux/bits.h:25:21: error: first argument to '__builtin_choose_expr' not a constant kernel test robot
2020-08-08  0:03 ` kernel test robot
2020-08-11  4:27 ` Andrew Morton
2020-08-11  4:27   ` Andrew Morton
2020-08-12 13:37   ` Peter Rosin [this message]
2020-08-12 13:37     ` Peter Rosin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45c8ced5-799b-759b-600f-f1ee752cf13d@axentia.se \
    --to=peda@axentia.se \
    --cc=akpm@linux-foundation.org \
    --cc=kbuild-all@lists.01.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=rikard.falkeborn@gmail.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.