All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <dada1@cosmosbay.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	virtualization@lists.osdl.org, Ingo Molnar <mingo@elte.hu>,
	Thomas Gleixner <tglx@linutronix.de>,
	john stultz <johnstul@us.ibm.com>,
	Zachary Amsden <zach@vmware.com>,
	James Morris <jmorris@namei.org>, Dan Hecht <dhecht@vmware.com>,
	Paul Mackerras <paulus@samba.org>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Prarit Bhargava <prarit@redhat.com>,
	Chris Lalancette <clalance@redhat.com>,
	Rick Lindsley <ricklind@us.ibm.com>
Subject: Re: [patch 1/2] Ignore stolen time in the softlockup watchdog
Date: Tue, 27 Mar 2007 09:00:49 +0200	[thread overview]
Message-ID: <4608C121.4050309@cosmosbay.com> (raw)
In-Reply-To: <20070327054106.664262413@goop.org>

Jeremy Fitzhardinge a écrit :

> +static DEFINE_PER_CPU(unsigned long long, touch_timestamp);

...

>  void touch_softlockup_watchdog(void)
>  {
> -	__raw_get_cpu_var(touch_timestamp) = jiffies;
> +	__raw_get_cpu_var(touch_timestamp) = sched_clock();
>  }

Not very clear if this is safe on 32bit, since this is not anymore atomic.

Maybe a comment would help ?



  reply	other threads:[~2007-03-27  7:00 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-27  5:38 [patch 0/2] softlockup watchdog improvements Jeremy Fitzhardinge
2007-03-27  5:38 ` Jeremy Fitzhardinge
2007-03-27  5:38 ` [patch 1/2] Ignore stolen time in the softlockup watchdog Jeremy Fitzhardinge
2007-03-27  7:00   ` Eric Dumazet [this message]
2007-03-27  7:12     ` Jeremy Fitzhardinge
2007-03-27  7:12       ` Jeremy Fitzhardinge
2007-03-27  7:50       ` Eric Dumazet
2007-03-27  7:50         ` Eric Dumazet
2007-03-27 14:39   ` Prarit Bhargava
2007-03-27 14:39     ` Prarit Bhargava
2007-03-27 16:37     ` Jeremy Fitzhardinge
2007-03-27 16:53       ` Prarit Bhargava
2007-03-27 16:53         ` Prarit Bhargava
2007-03-27 17:10         ` Jeremy Fitzhardinge
2007-03-27 17:10           ` Jeremy Fitzhardinge
2007-03-27 17:20           ` Prarit Bhargava
2007-03-27 17:20             ` Prarit Bhargava
2007-03-27  5:38 ` [patch 2/2] percpu enable flag for " Jeremy Fitzhardinge
2007-03-27  5:38   ` Jeremy Fitzhardinge
2007-03-27 14:42   ` Prarit Bhargava
2007-03-27 14:42     ` Prarit Bhargava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4608C121.4050309@cosmosbay.com \
    --to=dada1@cosmosbay.com \
    --cc=akpm@linux-foundation.org \
    --cc=clalance@redhat.com \
    --cc=dhecht@vmware.com \
    --cc=jeremy@goop.org \
    --cc=jmorris@namei.org \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=prarit@redhat.com \
    --cc=ricklind@us.ibm.com \
    --cc=schwidefsky@de.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=virtualization@lists.osdl.org \
    --cc=zach@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.