From: Jan Beulich <jbeulich@suse.com>
To: Ian Jackson <iwj@xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Julien Grall <julien@xen.org>
Subject: Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning
Date: Fri, 12 Mar 2021 16:59:00 +0100 [thread overview]
Message-ID: <46176065-8ae3-cb42-f031-aad12512d29e@suse.com> (raw)
In-Reply-To: <24651.15544.142804.468744@mariner.uk.xensource.com>
On 12.03.2021 11:04, Ian Jackson wrote:
> Julien Grall writes ("Re: [PATCH][4.15] gnttab: work around "may be used uninitialized" warning"):
>> This is pretty much what we are already doing slowly by initializing
>> values to shut up older compilers. I agree this is more limited, but we
>> also waive off diagnostics from every single compiler in that code
>> rather than just one version.
>>
>> Hence why I suggested dropping -Werror for older compiler. This is not
>> ideal but it would give us the ability to keep support for dinausor
>> compiler and not hamper our ability to take advantage of newer compiler
>> diagnostics.
>
> I agree with Julien. I think we should avoid adding these redundant
> initialisers for the reasons he gives.
>
>> The ideal solution is to drop support for older compiler (see my other
>> thread). But this sounds like a daunting task so far on x86...
>>
>> Anyway, I will not Nack the patch but will also not Ack it. I will let
>> another maintainer ack this patch.
>
> But this is outside my usual area so I won't nack it either.
But would you be willing to release-ack v2?
Jan
next prev parent reply other threads:[~2021-03-12 15:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 10:13 [PATCH][4.15] gnttab: work around "may be used uninitialized" warning Jan Beulich
2021-03-10 14:58 ` Julien Grall
2021-03-10 16:21 ` Jan Beulich
2021-03-10 17:52 ` Julien Grall
2021-03-11 8:09 ` Jan Beulich
2021-03-11 8:25 ` Roger Pau Monné
2021-03-11 8:33 ` Jan Beulich
2021-03-12 10:04 ` Ian Jackson
2021-03-12 10:13 ` Jan Beulich
2021-03-12 10:29 ` Ian Jackson
2021-03-12 11:05 ` Jan Beulich
2021-03-12 15:59 ` Jan Beulich [this message]
2021-03-12 16:30 ` Ian Jackson
2021-03-12 11:32 ` Andrew Cooper
2021-03-12 13:08 ` Jan Beulich
2021-03-12 13:18 ` Jan Beulich
2021-03-12 13:20 ` Andrew Cooper
2021-03-12 13:25 ` Andrew Cooper
2021-03-12 13:29 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46176065-8ae3-cb42-f031-aad12512d29e@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=iwj@xenproject.org \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.