All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: rockchip: add device_type property to rk3399 pcie node
@ 2021-01-22 18:05 ` Johan Jonker
  0 siblings, 0 replies; 6+ messages in thread
From: Johan Jonker @ 2021-01-22 18:05 UTC (permalink / raw)
  To: heiko; +Cc: robh+dt, linux-rockchip, devicetree, linux-arm-kernel, linux-kernel

A test with the command below gives for example this error:
/arch/arm64/boot/dts/rockchip/rk3399-rock960.dt.yaml:
pcie@f8000000: 'device_type' is a required property

Fix this by adding a device_type property to the rk3399 pcie node.

make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=~/.local/lib/python3.5/site-packages/dtschema/
schemas/pci/pci-bus.yaml

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3399.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index 28459d194..6c571fee8 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
@@ -252,6 +252,7 @@
 				<0 0 0 2 &pcie0_intc 1>,
 				<0 0 0 3 &pcie0_intc 2>,
 				<0 0 0 4 &pcie0_intc 3>;
+		device_type = "pci";
 		linux,pci-domain = <0>;
 		max-link-speed = <1>;
 		msi-map = <0x0 &its 0x0 0x1000>;
-- 
2.11.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] arm64: dts: rockchip: add device_type property to rk3399 pcie node
@ 2021-01-22 18:05 ` Johan Jonker
  0 siblings, 0 replies; 6+ messages in thread
From: Johan Jonker @ 2021-01-22 18:05 UTC (permalink / raw)
  To: heiko; +Cc: linux-rockchip, robh+dt, linux-kernel, linux-arm-kernel, devicetree

A test with the command below gives for example this error:
/arch/arm64/boot/dts/rockchip/rk3399-rock960.dt.yaml:
pcie@f8000000: 'device_type' is a required property

Fix this by adding a device_type property to the rk3399 pcie node.

make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=~/.local/lib/python3.5/site-packages/dtschema/
schemas/pci/pci-bus.yaml

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3399.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index 28459d194..6c571fee8 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
@@ -252,6 +252,7 @@
 				<0 0 0 2 &pcie0_intc 1>,
 				<0 0 0 3 &pcie0_intc 2>,
 				<0 0 0 4 &pcie0_intc 3>;
+		device_type = "pci";
 		linux,pci-domain = <0>;
 		max-link-speed = <1>;
 		msi-map = <0x0 &its 0x0 0x1000>;
-- 
2.11.0


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] arm64: dts: rockchip: add device_type property to rk3399 pcie node
@ 2021-01-22 18:05 ` Johan Jonker
  0 siblings, 0 replies; 6+ messages in thread
From: Johan Jonker @ 2021-01-22 18:05 UTC (permalink / raw)
  To: heiko; +Cc: linux-rockchip, robh+dt, linux-kernel, linux-arm-kernel, devicetree

A test with the command below gives for example this error:
/arch/arm64/boot/dts/rockchip/rk3399-rock960.dt.yaml:
pcie@f8000000: 'device_type' is a required property

Fix this by adding a device_type property to the rk3399 pcie node.

make ARCH=arm64 dtbs_check
DT_SCHEMA_FILES=~/.local/lib/python3.5/site-packages/dtschema/
schemas/pci/pci-bus.yaml

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3399.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index 28459d194..6c571fee8 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
@@ -252,6 +252,7 @@
 				<0 0 0 2 &pcie0_intc 1>,
 				<0 0 0 3 &pcie0_intc 2>,
 				<0 0 0 4 &pcie0_intc 3>;
+		device_type = "pci";
 		linux,pci-domain = <0>;
 		max-link-speed = <1>;
 		msi-map = <0x0 &its 0x0 0x1000>;
-- 
2.11.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: add device_type property to rk3399 pcie node
  2021-01-22 18:05 ` Johan Jonker
  (?)
@ 2021-01-25 23:54   ` Heiko Stuebner
  -1 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2021-01-25 23:54 UTC (permalink / raw)
  To: Johan Jonker
  Cc: robh+dt, linux-rockchip, devicetree, linux-arm-kernel, linux-kernel

Am Freitag, 22. Januar 2021, 19:05:59 CET schrieb Johan Jonker:
> A test with the command below gives for example this error:
> /arch/arm64/boot/dts/rockchip/rk3399-rock960.dt.yaml:
> pcie@f8000000: 'device_type' is a required property
> 
> Fix this by adding a device_type property to the rk3399 pcie node.
> 
> make ARCH=arm64 dtbs_check
> DT_SCHEMA_FILES=~/.local/lib/python3.5/site-packages/dtschema/
> schemas/pci/pci-bus.yaml
> 
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>

already done in
https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v5.11-armsoc/dtsfixes&id=43f20b1c6140896916f4e91aacc166830a7ba849



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: add device_type property to rk3399 pcie node
@ 2021-01-25 23:54   ` Heiko Stuebner
  0 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2021-01-25 23:54 UTC (permalink / raw)
  To: Johan Jonker
  Cc: linux-rockchip, robh+dt, linux-kernel, linux-arm-kernel, devicetree

Am Freitag, 22. Januar 2021, 19:05:59 CET schrieb Johan Jonker:
> A test with the command below gives for example this error:
> /arch/arm64/boot/dts/rockchip/rk3399-rock960.dt.yaml:
> pcie@f8000000: 'device_type' is a required property
> 
> Fix this by adding a device_type property to the rk3399 pcie node.
> 
> make ARCH=arm64 dtbs_check
> DT_SCHEMA_FILES=~/.local/lib/python3.5/site-packages/dtschema/
> schemas/pci/pci-bus.yaml
> 
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>

already done in
https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v5.11-armsoc/dtsfixes&id=43f20b1c6140896916f4e91aacc166830a7ba849



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: add device_type property to rk3399 pcie node
@ 2021-01-25 23:54   ` Heiko Stuebner
  0 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2021-01-25 23:54 UTC (permalink / raw)
  To: Johan Jonker
  Cc: linux-rockchip, robh+dt, linux-kernel, linux-arm-kernel, devicetree

Am Freitag, 22. Januar 2021, 19:05:59 CET schrieb Johan Jonker:
> A test with the command below gives for example this error:
> /arch/arm64/boot/dts/rockchip/rk3399-rock960.dt.yaml:
> pcie@f8000000: 'device_type' is a required property
> 
> Fix this by adding a device_type property to the rk3399 pcie node.
> 
> make ARCH=arm64 dtbs_check
> DT_SCHEMA_FILES=~/.local/lib/python3.5/site-packages/dtschema/
> schemas/pci/pci-bus.yaml
> 
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>

already done in
https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v5.11-armsoc/dtsfixes&id=43f20b1c6140896916f4e91aacc166830a7ba849



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-01-25 23:55 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-22 18:05 [PATCH] arm64: dts: rockchip: add device_type property to rk3399 pcie node Johan Jonker
2021-01-22 18:05 ` Johan Jonker
2021-01-22 18:05 ` Johan Jonker
2021-01-25 23:54 ` Heiko Stuebner
2021-01-25 23:54   ` Heiko Stuebner
2021-01-25 23:54   ` Heiko Stuebner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.