All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] ACPI / PCI: remove stale list_head in struct acpi_prt_entry
@ 2015-05-21 15:29 Hanjun Guo
  2015-05-22  2:06 ` Rafael J. Wysocki
  0 siblings, 1 reply; 2+ messages in thread
From: Hanjun Guo @ 2015-05-21 15:29 UTC (permalink / raw)
  To: Bjorn Helgaas, Rafael J. Wysocki
  Cc: linux-acpi, linux-pci, Hanjun Guo, Yinghai Lu, Yijing Wang

list_head "list" in struct acpi_prt_entry was used to connect
_PRT entries for PCI irq, but after commit 181380b702ee ("PCI/ACPI:
Don't cache _PRT, and don't associate them with bus numbers"),
the list head for _PRT entries was removed, but left "list" in
struct acpi_prt_entry which is useless and stale, remove it now.

Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
CC: Yinghai Lu <yinghai@kernel.org>
CC: Yijing Wang <wangyijing@huawei.com>
---

v2:
use the canonical commit reference format as Bjorn suggested.

 drivers/acpi/pci_irq.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c
index b1def41..03e4b6c 100644
--- a/drivers/acpi/pci_irq.c
+++ b/drivers/acpi/pci_irq.c
@@ -44,7 +44,6 @@
 ACPI_MODULE_NAME("pci_irq");
 
 struct acpi_prt_entry {
-	struct list_head	list;
 	struct acpi_pci_id	id;
 	u8			pin;
 	acpi_handle		link;
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] ACPI / PCI: remove stale list_head in struct acpi_prt_entry
  2015-05-21 15:29 [PATCH v2] ACPI / PCI: remove stale list_head in struct acpi_prt_entry Hanjun Guo
@ 2015-05-22  2:06 ` Rafael J. Wysocki
  0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2015-05-22  2:06 UTC (permalink / raw)
  To: Hanjun Guo; +Cc: Bjorn Helgaas, linux-acpi, linux-pci, Yinghai Lu, Yijing Wang

On Thursday, May 21, 2015 11:29:26 PM Hanjun Guo wrote:
> list_head "list" in struct acpi_prt_entry was used to connect
> _PRT entries for PCI irq, but after commit 181380b702ee ("PCI/ACPI:
> Don't cache _PRT, and don't associate them with bus numbers"),
> the list head for _PRT entries was removed, but left "list" in
> struct acpi_prt_entry which is useless and stale, remove it now.
> 
> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> CC: Yinghai Lu <yinghai@kernel.org>
> CC: Yijing Wang <wangyijing@huawei.com>
> ---
> 
> v2:
> use the canonical commit reference format as Bjorn suggested.

Queued up for 4.2, thanks!

>  drivers/acpi/pci_irq.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c
> index b1def41..03e4b6c 100644
> --- a/drivers/acpi/pci_irq.c
> +++ b/drivers/acpi/pci_irq.c
> @@ -44,7 +44,6 @@
>  ACPI_MODULE_NAME("pci_irq");
>  
>  struct acpi_prt_entry {
> -	struct list_head	list;
>  	struct acpi_pci_id	id;
>  	u8			pin;
>  	acpi_handle		link;
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-05-22  2:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-21 15:29 [PATCH v2] ACPI / PCI: remove stale list_head in struct acpi_prt_entry Hanjun Guo
2015-05-22  2:06 ` Rafael J. Wysocki

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.