Desynchronized ncommit

* Desynchronized ncommit
@ 2007-04-19 18:23 Chuck Lever
  2007-04-19 18:29 ` Trond Myklebust
  0 siblings, 1 reply; 3+ messages in thread
From: Chuck Lever @ 2007-04-19 18:23 UTC (permalink / raw)
  To: nfs

[-- Attachment #1: Type: text/plain, Size: 1159 bytes --]

I've noticed this message in my system log over the past few days:

Apr 17 10:14:04 schiele kernel: NFS: desynchronized value of nfs_i.ncommit.

It looks like it started appearing when the following patch was applied 
to 2.6.21-rc.  Any suggestions on what I can do to debug this further?

     NFS: Fix a list corruption problem

     We must remove the request from whatever list it is currently on 
before we
     can add it to the dirty list.

     Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

diff --git a/fs/nfs/write.c b/fs/nfs/write.c
index e5d7cac..ad2e91b 100644
--- a/fs/nfs/write.c
+++ b/fs/nfs/write.c
@@ -280,8 +280,10 @@ static int nfs_page_mark_flush(struct page *page)
                 spin_lock(req_lock);
         }
         spin_unlock(req_lock);
-       if (nfs_set_page_writeback(page) == 0)
+       if (nfs_set_page_writeback(page) == 0) {
+               nfs_list_remove_request(req);
                 nfs_mark_request_dirty(req);
+       }
         ret = test_bit(PG_NEED_FLUSH, &req->wb_flags);
         nfs_unlock_request(req);
         return ret;

[-- Attachment #2: chuck.lever.vcf --]
[-- Type: text/x-vcard, Size: 315 bytes --]

begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture: Linux Projects Group
adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA
email;internet:chuck dot lever at nospam oracle dot com
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
version:2.1
end:vcard


[-- Attachment #3: Type: text/plain, Size: 286 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

[-- Attachment #4: Type: text/plain, Size: 140 bytes --]

_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

^ permalink raw reply related	[flat|nested] 3+ messages in thread