From: "Chen, Rong A" <rong.a.chen@intel.com> To: Pavel Begunkov <asml.silence@gmail.com>, kernel test robot <lkp@intel.com>, Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Christoph Hellwig <hch@infradead.org> Subject: Re: [kbuild-all] Re: [PATCH v2 2/3] block: don't hide inode from block_device users Date: Fri, 15 Oct 2021 08:40:51 +0800 [thread overview] Message-ID: <46559402-1d69-455d-ad09-27f43f6c0a3a@intel.com> (raw) In-Reply-To: <ebe92ed4-6847-0ec0-d5e7-e3485ba7e049@gmail.com> On 10/13/2021 11:12 PM, Pavel Begunkov wrote: > On 10/13/21 16:03, kernel test robot wrote: >> Hi Pavel, >> >> I love your patch! Yet something to improve: >> >> [auto build test ERROR on v5.15-rc5] > > It's against for-5.16/block and there is no more block_ioctl() in > fops.c, should be fine Hi Pavel, Thanks for the feedback, we'll take a look. Best Regards, Rong Chen > > >> [cannot apply to axboe-block/for-next next-20211013] >> [If your patch is applied to the wrong git tree, kindly drop us a note. >> And when submitting patch, we suggest to use '--base' as documented in >> https://git-scm.com/docs/git-format-patch] >> >> url: >> https://github.com/0day-ci/linux/commits/Pavel-Begunkov/on-top-of-for-5-16-block/20211013-165953 >> >> base: 64570fbc14f8d7cb3fe3995f20e26bc25ce4b2cc >> config: hexagon-randconfig-r045-20211013 (attached as .config) >> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project >> b6a8c695542b2987eb9a203d5663a0740cb4725f) >> reproduce (this is a W=1 build): >> wget >> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross >> -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> # >> https://github.com/0day-ci/linux/commit/9e538de87cc869bd26a3ca78da49d1437ec8688c >> >> git remote add linux-review https://github.com/0day-ci/linux >> git fetch --no-tags linux-review >> Pavel-Begunkov/on-top-of-for-5-16-block/20211013-165953 >> git checkout 9e538de87cc869bd26a3ca78da49d1437ec8688c >> # save the attached .config to linux build tree >> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross >> W=1 ARCH=hexagon >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot <lkp@intel.com> >> >> All error/warnings (new ones prefixed by >>): >> >>>> block/fops.c:460:37: error: implicit declaration of function >>>> 'bdev_file_inode' [-Werror,-Wimplicit-function-declaration] >> struct block_device *bdev = I_BDEV(bdev_file_inode(file)); >> ^ >> block/fops.c:460:37: note: did you mean 'file_inode'? >> include/linux/fs.h:1348:29: note: 'file_inode' declared here >> static inline struct inode *file_inode(const struct file *f) >> ^ >>>> block/fops.c:460:37: warning: incompatible integer to pointer >>>> conversion passing 'int' to parameter of type 'struct inode *' >>>> [-Wint-conversion] >> struct block_device *bdev = I_BDEV(bdev_file_inode(file)); >> ^~~~~~~~~~~~~~~~~~~~~ >> include/linux/blkdev.h:1990:57: note: passing argument to >> parameter 'inode' here >> static inline struct block_device *I_BDEV(struct inode *inode) >> ^ >> 1 warning and 1 error generated. >> >> >> vim +/bdev_file_inode +460 block/fops.c >> >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 457 >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 458 static long >> block_ioctl(struct file *file, unsigned cmd, unsigned long arg) >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 459 { >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 @460 struct >> block_device *bdev = I_BDEV(bdev_file_inode(file)); >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 461 fmode_t mode = >> file->f_mode; >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 462 >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 463 /* >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 464 * O_NDELAY can >> be altered using fcntl(.., F_SETFL, ..), so we have >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 465 * to updated it >> before every ioctl. >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 466 */ >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 467 if >> (file->f_flags & O_NDELAY) >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 468 mode |= >> FMODE_NDELAY; >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 469 else >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 470 mode &= >> ~FMODE_NDELAY; >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 471 >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 472 return >> blkdev_ioctl(bdev, mode, cmd, arg); >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 473 } >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 474 >> >> --- >> 0-DAY CI Kernel Test Service, Intel Corporation >> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org >> >
WARNING: multiple messages have this Message-ID (diff)
From: Chen, Rong A <rong.a.chen@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH v2 2/3] block: don't hide inode from block_device users Date: Fri, 15 Oct 2021 08:40:51 +0800 [thread overview] Message-ID: <46559402-1d69-455d-ad09-27f43f6c0a3a@intel.com> (raw) In-Reply-To: <ebe92ed4-6847-0ec0-d5e7-e3485ba7e049@gmail.com> [-- Attachment #1: Type: text/plain, Size: 5031 bytes --] On 10/13/2021 11:12 PM, Pavel Begunkov wrote: > On 10/13/21 16:03, kernel test robot wrote: >> Hi Pavel, >> >> I love your patch! Yet something to improve: >> >> [auto build test ERROR on v5.15-rc5] > > It's against for-5.16/block and there is no more block_ioctl() in > fops.c, should be fine Hi Pavel, Thanks for the feedback, we'll take a look. Best Regards, Rong Chen > > >> [cannot apply to axboe-block/for-next next-20211013] >> [If your patch is applied to the wrong git tree, kindly drop us a note. >> And when submitting patch, we suggest to use '--base' as documented in >> https://git-scm.com/docs/git-format-patch] >> >> url: >> https://github.com/0day-ci/linux/commits/Pavel-Begunkov/on-top-of-for-5-16-block/20211013-165953 >> >> base: 64570fbc14f8d7cb3fe3995f20e26bc25ce4b2cc >> config: hexagon-randconfig-r045-20211013 (attached as .config) >> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project >> b6a8c695542b2987eb9a203d5663a0740cb4725f) >> reproduce (this is a W=1 build): >> wget >> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross >> -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> # >> https://github.com/0day-ci/linux/commit/9e538de87cc869bd26a3ca78da49d1437ec8688c >> >> git remote add linux-review https://github.com/0day-ci/linux >> git fetch --no-tags linux-review >> Pavel-Begunkov/on-top-of-for-5-16-block/20211013-165953 >> git checkout 9e538de87cc869bd26a3ca78da49d1437ec8688c >> # save the attached .config to linux build tree >> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross >> W=1 ARCH=hexagon >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot <lkp@intel.com> >> >> All error/warnings (new ones prefixed by >>): >> >>>> block/fops.c:460:37: error: implicit declaration of function >>>> 'bdev_file_inode' [-Werror,-Wimplicit-function-declaration] >> struct block_device *bdev = I_BDEV(bdev_file_inode(file)); >> ^ >> block/fops.c:460:37: note: did you mean 'file_inode'? >> include/linux/fs.h:1348:29: note: 'file_inode' declared here >> static inline struct inode *file_inode(const struct file *f) >> ^ >>>> block/fops.c:460:37: warning: incompatible integer to pointer >>>> conversion passing 'int' to parameter of type 'struct inode *' >>>> [-Wint-conversion] >> struct block_device *bdev = I_BDEV(bdev_file_inode(file)); >> ^~~~~~~~~~~~~~~~~~~~~ >> include/linux/blkdev.h:1990:57: note: passing argument to >> parameter 'inode' here >> static inline struct block_device *I_BDEV(struct inode *inode) >> ^ >> 1 warning and 1 error generated. >> >> >> vim +/bdev_file_inode +460 block/fops.c >> >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 457 >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 458 static long >> block_ioctl(struct file *file, unsigned cmd, unsigned long arg) >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 459 { >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 @460 struct >> block_device *bdev = I_BDEV(bdev_file_inode(file)); >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 461 fmode_t mode = >> file->f_mode; >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 462 >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 463 /* >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 464 * O_NDELAY can >> be altered using fcntl(.., F_SETFL, ..), so we have >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 465 * to updated it >> before every ioctl. >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 466 */ >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 467 if >> (file->f_flags & O_NDELAY) >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 468 mode |= >> FMODE_NDELAY; >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 469 else >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 470 mode &= >> ~FMODE_NDELAY; >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 471 >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 472 return >> blkdev_ioctl(bdev, mode, cmd, arg); >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 473 } >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 474 >> >> --- >> 0-DAY CI Kernel Test Service, Intel Corporation >> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org >> >
next prev parent reply other threads:[~2021-10-15 0:40 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-13 8:57 [PATCH v2 0/3] on top of for-5.16/block Pavel Begunkov 2021-10-13 8:57 ` [PATCH v2 1/3] block: cache bdev in struct file for raw bdev IO Pavel Begunkov 2021-10-13 15:19 ` Christoph Hellwig 2021-10-13 8:57 ` [PATCH v2 2/3] block: don't hide inode from block_device users Pavel Begunkov 2021-10-13 14:03 ` kernel test robot 2021-10-13 14:03 ` kernel test robot 2021-10-13 15:03 ` kernel test robot 2021-10-13 15:03 ` kernel test robot 2021-10-13 15:12 ` Pavel Begunkov 2021-10-13 15:12 ` Pavel Begunkov 2021-10-15 0:40 ` Chen, Rong A [this message] 2021-10-15 0:40 ` Chen, Rong A 2021-10-13 15:25 ` Christoph Hellwig 2021-10-13 18:44 ` Pavel Begunkov 2021-10-14 4:51 ` Christoph Hellwig 2021-10-14 9:35 ` Pavel Begunkov 2021-10-13 8:57 ` [PATCH v2 3/3] blk-mq: optimise *end_request non-stat path Pavel Begunkov 2021-10-13 15:30 ` Christoph Hellwig 2021-10-13 9:15 ` [PATCH v2 0/3] on top of for-5.16/block Pavel Begunkov 2021-10-13 15:53 ` (subset) " Jens Axboe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=46559402-1d69-455d-ad09-27f43f6c0a3a@intel.com \ --to=rong.a.chen@intel.com \ --cc=asml.silence@gmail.com \ --cc=axboe@kernel.dk \ --cc=hch@infradead.org \ --cc=kbuild-all@lists.01.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lkp@intel.com \ --cc=llvm@lists.linux.dev \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.