* [PATCH] gpio: renesas: Simplify .request/.rfree callbacks
@ 2022-08-02 10:06 Pali Rohár
2022-08-03 6:48 ` Stefan Roese
2023-05-16 19:03 ` Pali Rohár
0 siblings, 2 replies; 9+ messages in thread
From: Pali Rohár @ 2022-08-02 10:06 UTC (permalink / raw)
To: Stefan Roese; +Cc: u-boot
Remove identify wrapper functions.
Signed-off-by: Pali Rohár <pali@kernel.org>
---
drivers/gpio/gpio-rcar.c | 15 ++-------------
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
index 138801850d3e..ba00bb459679 100644
--- a/drivers/gpio/gpio-rcar.c
+++ b/drivers/gpio/gpio-rcar.c
@@ -130,20 +130,9 @@ static int rcar_gpio_get_function(struct udevice *dev, unsigned offset)
return GPIOF_INPUT;
}
-static int rcar_gpio_request(struct udevice *dev, unsigned offset,
- const char *label)
-{
- return pinctrl_gpio_request(dev, offset, label);
-}
-
-static int rcar_gpio_free(struct udevice *dev, unsigned offset)
-{
- return pinctrl_gpio_free(dev, offset);
-}
-
static const struct dm_gpio_ops rcar_gpio_ops = {
- .request = rcar_gpio_request,
- .rfree = rcar_gpio_free,
+ .request = pinctrl_gpio_request,
+ .rfree = pinctrl_gpio_free,
.direction_input = rcar_gpio_direction_input,
.direction_output = rcar_gpio_direction_output,
.get_value = rcar_gpio_get_value,
--
2.20.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] gpio: renesas: Simplify .request/.rfree callbacks
2022-08-02 10:06 [PATCH] gpio: renesas: Simplify .request/.rfree callbacks Pali Rohár
@ 2022-08-03 6:48 ` Stefan Roese
2022-09-02 19:56 ` Pali Rohár
2023-05-16 19:03 ` Pali Rohár
1 sibling, 1 reply; 9+ messages in thread
From: Stefan Roese @ 2022-08-03 6:48 UTC (permalink / raw)
To: Pali Rohár; +Cc: u-boot
On 02.08.22 12:06, Pali Rohár wrote:
> Remove identify wrapper functions.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
> ---
> drivers/gpio/gpio-rcar.c | 15 ++-------------
> 1 file changed, 2 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
> index 138801850d3e..ba00bb459679 100644
> --- a/drivers/gpio/gpio-rcar.c
> +++ b/drivers/gpio/gpio-rcar.c
> @@ -130,20 +130,9 @@ static int rcar_gpio_get_function(struct udevice *dev, unsigned offset)
> return GPIOF_INPUT;
> }
>
> -static int rcar_gpio_request(struct udevice *dev, unsigned offset,
> - const char *label)
> -{
> - return pinctrl_gpio_request(dev, offset, label);
> -}
> -
> -static int rcar_gpio_free(struct udevice *dev, unsigned offset)
> -{
> - return pinctrl_gpio_free(dev, offset);
> -}
> -
> static const struct dm_gpio_ops rcar_gpio_ops = {
> - .request = rcar_gpio_request,
> - .rfree = rcar_gpio_free,
> + .request = pinctrl_gpio_request,
> + .rfree = pinctrl_gpio_free,
> .direction_input = rcar_gpio_direction_input,
> .direction_output = rcar_gpio_direction_output,
> .get_value = rcar_gpio_get_value,
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] gpio: renesas: Simplify .request/.rfree callbacks
2022-08-03 6:48 ` Stefan Roese
@ 2022-09-02 19:56 ` Pali Rohár
2022-10-09 12:34 ` Pali Rohár
0 siblings, 1 reply; 9+ messages in thread
From: Pali Rohár @ 2022-09-02 19:56 UTC (permalink / raw)
To: Stefan Roese; +Cc: u-boot
On Wednesday 03 August 2022 08:48:39 Stefan Roese wrote:
> On 02.08.22 12:06, Pali Rohár wrote:
> > Remove identify wrapper functions.
> >
> > Signed-off-by: Pali Rohár <pali@kernel.org>
>
> Reviewed-by: Stefan Roese <sr@denx.de>
Any more comments? Or could it be merged?
> Thanks,
> Stefan
>
> > ---
> > drivers/gpio/gpio-rcar.c | 15 ++-------------
> > 1 file changed, 2 insertions(+), 13 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
> > index 138801850d3e..ba00bb459679 100644
> > --- a/drivers/gpio/gpio-rcar.c
> > +++ b/drivers/gpio/gpio-rcar.c
> > @@ -130,20 +130,9 @@ static int rcar_gpio_get_function(struct udevice *dev, unsigned offset)
> > return GPIOF_INPUT;
> > }
> > -static int rcar_gpio_request(struct udevice *dev, unsigned offset,
> > - const char *label)
> > -{
> > - return pinctrl_gpio_request(dev, offset, label);
> > -}
> > -
> > -static int rcar_gpio_free(struct udevice *dev, unsigned offset)
> > -{
> > - return pinctrl_gpio_free(dev, offset);
> > -}
> > -
> > static const struct dm_gpio_ops rcar_gpio_ops = {
> > - .request = rcar_gpio_request,
> > - .rfree = rcar_gpio_free,
> > + .request = pinctrl_gpio_request,
> > + .rfree = pinctrl_gpio_free,
> > .direction_input = rcar_gpio_direction_input,
> > .direction_output = rcar_gpio_direction_output,
> > .get_value = rcar_gpio_get_value,
>
> Viele Grüße,
> Stefan Roese
>
> --
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] gpio: renesas: Simplify .request/.rfree callbacks
2022-09-02 19:56 ` Pali Rohár
@ 2022-10-09 12:34 ` Pali Rohár
2022-11-01 22:57 ` Pali Rohár
0 siblings, 1 reply; 9+ messages in thread
From: Pali Rohár @ 2022-10-09 12:34 UTC (permalink / raw)
To: Stefan Roese; +Cc: u-boot
On Friday 02 September 2022 21:56:07 Pali Rohár wrote:
> On Wednesday 03 August 2022 08:48:39 Stefan Roese wrote:
> > On 02.08.22 12:06, Pali Rohár wrote:
> > > Remove identify wrapper functions.
> > >
> > > Signed-off-by: Pali Rohár <pali@kernel.org>
> >
> > Reviewed-by: Stefan Roese <sr@denx.de>
>
> Any more comments? Or could it be merged?
PING after another month?
> > Thanks,
> > Stefan
> >
> > > ---
> > > drivers/gpio/gpio-rcar.c | 15 ++-------------
> > > 1 file changed, 2 insertions(+), 13 deletions(-)
> > >
> > > diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
> > > index 138801850d3e..ba00bb459679 100644
> > > --- a/drivers/gpio/gpio-rcar.c
> > > +++ b/drivers/gpio/gpio-rcar.c
> > > @@ -130,20 +130,9 @@ static int rcar_gpio_get_function(struct udevice *dev, unsigned offset)
> > > return GPIOF_INPUT;
> > > }
> > > -static int rcar_gpio_request(struct udevice *dev, unsigned offset,
> > > - const char *label)
> > > -{
> > > - return pinctrl_gpio_request(dev, offset, label);
> > > -}
> > > -
> > > -static int rcar_gpio_free(struct udevice *dev, unsigned offset)
> > > -{
> > > - return pinctrl_gpio_free(dev, offset);
> > > -}
> > > -
> > > static const struct dm_gpio_ops rcar_gpio_ops = {
> > > - .request = rcar_gpio_request,
> > > - .rfree = rcar_gpio_free,
> > > + .request = pinctrl_gpio_request,
> > > + .rfree = pinctrl_gpio_free,
> > > .direction_input = rcar_gpio_direction_input,
> > > .direction_output = rcar_gpio_direction_output,
> > > .get_value = rcar_gpio_get_value,
> >
> > Viele Grüße,
> > Stefan Roese
> >
> > --
> > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> > Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] gpio: renesas: Simplify .request/.rfree callbacks
2022-10-09 12:34 ` Pali Rohár
@ 2022-11-01 22:57 ` Pali Rohár
2022-11-02 8:58 ` Stefan Roese
0 siblings, 1 reply; 9+ messages in thread
From: Pali Rohár @ 2022-11-01 22:57 UTC (permalink / raw)
To: Stefan Roese; +Cc: u-boot
On Sunday 09 October 2022 14:34:55 Pali Rohár wrote:
> On Friday 02 September 2022 21:56:07 Pali Rohár wrote:
> > On Wednesday 03 August 2022 08:48:39 Stefan Roese wrote:
> > > On 02.08.22 12:06, Pali Rohár wrote:
> > > > Remove identify wrapper functions.
> > > >
> > > > Signed-off-by: Pali Rohár <pali@kernel.org>
> > >
> > > Reviewed-by: Stefan Roese <sr@denx.de>
> >
> > Any more comments? Or could it be merged?
>
> PING after another month?
PING?
> > > Thanks,
> > > Stefan
> > >
> > > > ---
> > > > drivers/gpio/gpio-rcar.c | 15 ++-------------
> > > > 1 file changed, 2 insertions(+), 13 deletions(-)
> > > >
> > > > diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
> > > > index 138801850d3e..ba00bb459679 100644
> > > > --- a/drivers/gpio/gpio-rcar.c
> > > > +++ b/drivers/gpio/gpio-rcar.c
> > > > @@ -130,20 +130,9 @@ static int rcar_gpio_get_function(struct udevice *dev, unsigned offset)
> > > > return GPIOF_INPUT;
> > > > }
> > > > -static int rcar_gpio_request(struct udevice *dev, unsigned offset,
> > > > - const char *label)
> > > > -{
> > > > - return pinctrl_gpio_request(dev, offset, label);
> > > > -}
> > > > -
> > > > -static int rcar_gpio_free(struct udevice *dev, unsigned offset)
> > > > -{
> > > > - return pinctrl_gpio_free(dev, offset);
> > > > -}
> > > > -
> > > > static const struct dm_gpio_ops rcar_gpio_ops = {
> > > > - .request = rcar_gpio_request,
> > > > - .rfree = rcar_gpio_free,
> > > > + .request = pinctrl_gpio_request,
> > > > + .rfree = pinctrl_gpio_free,
> > > > .direction_input = rcar_gpio_direction_input,
> > > > .direction_output = rcar_gpio_direction_output,
> > > > .get_value = rcar_gpio_get_value,
> > >
> > > Viele Grüße,
> > > Stefan Roese
> > >
> > > --
> > > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> > > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> > > Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] gpio: renesas: Simplify .request/.rfree callbacks
2022-11-01 22:57 ` Pali Rohár
@ 2022-11-02 8:58 ` Stefan Roese
2022-11-21 17:39 ` Pali Rohár
2022-11-25 21:31 ` Marek Vasut
0 siblings, 2 replies; 9+ messages in thread
From: Stefan Roese @ 2022-11-02 8:58 UTC (permalink / raw)
To: Pali Rohár; +Cc: u-boot, Marek Vasut
Hi Pali,
added Marek to Cc
On 01.11.22 23:57, Pali Rohár wrote:
> On Sunday 09 October 2022 14:34:55 Pali Rohár wrote:
>> On Friday 02 September 2022 21:56:07 Pali Rohár wrote:
>>> On Wednesday 03 August 2022 08:48:39 Stefan Roese wrote:
>>>> On 02.08.22 12:06, Pali Rohár wrote:
>>>>> Remove identify wrapper functions.
>>>>>
>>>>> Signed-off-by: Pali Rohár <pali@kernel.org>
>>>>
>>>> Reviewed-by: Stefan Roese <sr@denx.de>
>>>
>>> Any more comments? Or could it be merged?
>>
>> PING after another month?
>
> PING?
Marek, could you please take a look? This patch is delegated to you
in patchworks:
http://patchwork.ozlabs.org/project/uboot/patch/20220802100655.17965-1-pali@kernel.org/
Thanks,
Stefan
>>>> Thanks,
>>>> Stefan
>>>>
>>>>> ---
>>>>> drivers/gpio/gpio-rcar.c | 15 ++-------------
>>>>> 1 file changed, 2 insertions(+), 13 deletions(-)
>>>>>
>>>>> diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
>>>>> index 138801850d3e..ba00bb459679 100644
>>>>> --- a/drivers/gpio/gpio-rcar.c
>>>>> +++ b/drivers/gpio/gpio-rcar.c
>>>>> @@ -130,20 +130,9 @@ static int rcar_gpio_get_function(struct udevice *dev, unsigned offset)
>>>>> return GPIOF_INPUT;
>>>>> }
>>>>> -static int rcar_gpio_request(struct udevice *dev, unsigned offset,
>>>>> - const char *label)
>>>>> -{
>>>>> - return pinctrl_gpio_request(dev, offset, label);
>>>>> -}
>>>>> -
>>>>> -static int rcar_gpio_free(struct udevice *dev, unsigned offset)
>>>>> -{
>>>>> - return pinctrl_gpio_free(dev, offset);
>>>>> -}
>>>>> -
>>>>> static const struct dm_gpio_ops rcar_gpio_ops = {
>>>>> - .request = rcar_gpio_request,
>>>>> - .rfree = rcar_gpio_free,
>>>>> + .request = pinctrl_gpio_request,
>>>>> + .rfree = pinctrl_gpio_free,
>>>>> .direction_input = rcar_gpio_direction_input,
>>>>> .direction_output = rcar_gpio_direction_output,
>>>>> .get_value = rcar_gpio_get_value,
>>>>
>>>> Viele Grüße,
>>>> Stefan Roese
>>>>
>>>> --
>>>> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
>>>> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>>>> Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] gpio: renesas: Simplify .request/.rfree callbacks
2022-11-02 8:58 ` Stefan Roese
@ 2022-11-21 17:39 ` Pali Rohár
2022-11-25 21:31 ` Marek Vasut
1 sibling, 0 replies; 9+ messages in thread
From: Pali Rohár @ 2022-11-21 17:39 UTC (permalink / raw)
To: Tom Rini, Stefan Roese; +Cc: u-boot, Marek Vasut
+ Tom
On Wednesday 02 November 2022 09:58:10 Stefan Roese wrote:
> Hi Pali,
>
> added Marek to Cc
>
> On 01.11.22 23:57, Pali Rohár wrote:
> > On Sunday 09 October 2022 14:34:55 Pali Rohár wrote:
> > > On Friday 02 September 2022 21:56:07 Pali Rohár wrote:
> > > > On Wednesday 03 August 2022 08:48:39 Stefan Roese wrote:
> > > > > On 02.08.22 12:06, Pali Rohár wrote:
> > > > > > Remove identify wrapper functions.
> > > > > >
> > > > > > Signed-off-by: Pali Rohár <pali@kernel.org>
> > > > >
> > > > > Reviewed-by: Stefan Roese <sr@denx.de>
> > > >
> > > > Any more comments? Or could it be merged?
> > >
> > > PING after another month?
> >
> > PING?
>
> Marek, could you please take a look? This patch is delegated to you
> in patchworks:
>
> http://patchwork.ozlabs.org/project/uboot/patch/20220802100655.17965-1-pali@kernel.org/
>
> Thanks,
> Stefan
>
> > > > > Thanks,
> > > > > Stefan
> > > > >
> > > > > > ---
> > > > > > drivers/gpio/gpio-rcar.c | 15 ++-------------
> > > > > > 1 file changed, 2 insertions(+), 13 deletions(-)
> > > > > >
> > > > > > diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
> > > > > > index 138801850d3e..ba00bb459679 100644
> > > > > > --- a/drivers/gpio/gpio-rcar.c
> > > > > > +++ b/drivers/gpio/gpio-rcar.c
> > > > > > @@ -130,20 +130,9 @@ static int rcar_gpio_get_function(struct udevice *dev, unsigned offset)
> > > > > > return GPIOF_INPUT;
> > > > > > }
> > > > > > -static int rcar_gpio_request(struct udevice *dev, unsigned offset,
> > > > > > - const char *label)
> > > > > > -{
> > > > > > - return pinctrl_gpio_request(dev, offset, label);
> > > > > > -}
> > > > > > -
> > > > > > -static int rcar_gpio_free(struct udevice *dev, unsigned offset)
> > > > > > -{
> > > > > > - return pinctrl_gpio_free(dev, offset);
> > > > > > -}
> > > > > > -
> > > > > > static const struct dm_gpio_ops rcar_gpio_ops = {
> > > > > > - .request = rcar_gpio_request,
> > > > > > - .rfree = rcar_gpio_free,
> > > > > > + .request = pinctrl_gpio_request,
> > > > > > + .rfree = pinctrl_gpio_free,
> > > > > > .direction_input = rcar_gpio_direction_input,
> > > > > > .direction_output = rcar_gpio_direction_output,
> > > > > > .get_value = rcar_gpio_get_value,
> > > > >
> > > > > Viele Grüße,
> > > > > Stefan Roese
> > > > >
> > > > > --
> > > > > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> > > > > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> > > > > Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
>
> Viele Grüße,
> Stefan Roese
>
> --
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] gpio: renesas: Simplify .request/.rfree callbacks
2022-11-02 8:58 ` Stefan Roese
2022-11-21 17:39 ` Pali Rohár
@ 2022-11-25 21:31 ` Marek Vasut
1 sibling, 0 replies; 9+ messages in thread
From: Marek Vasut @ 2022-11-25 21:31 UTC (permalink / raw)
To: Stefan Roese, Pali Rohár; +Cc: u-boot
On 11/2/22 09:58, Stefan Roese wrote:
> Hi Pali,
Hello Stefan,
> added Marek to Cc
Thank you.
> On 01.11.22 23:57, Pali Rohár wrote:
>> On Sunday 09 October 2022 14:34:55 Pali Rohár wrote:
>>> On Friday 02 September 2022 21:56:07 Pali Rohár wrote:
>>>> On Wednesday 03 August 2022 08:48:39 Stefan Roese wrote:
>>>>> On 02.08.22 12:06, Pali Rohár wrote:
>>>>>> Remove identify wrapper functions.
>>>>>>
>>>>>> Signed-off-by: Pali Rohár <pali@kernel.org>
>>>>>
>>>>> Reviewed-by: Stefan Roese <sr@denx.de>
>>>>
>>>> Any more comments? Or could it be merged?
>>>
>>> PING after another month?
>>
>> PING?
>
> Marek, could you please take a look? This patch is delegated to you
> in patchworks:
>
> http://patchwork.ozlabs.org/project/uboot/patch/20220802100655.17965-1-pali@kernel.org/
It would be better if the patch author added me to CC, that could've
prevented those frustrated pings with no response.
>>>>>> diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
>>>>>> index 138801850d3e..ba00bb459679 100644
>>>>>> --- a/drivers/gpio/gpio-rcar.c
>>>>>> +++ b/drivers/gpio/gpio-rcar.c
>>>>>> @@ -130,20 +130,9 @@ static int rcar_gpio_get_function(struct
>>>>>> udevice *dev, unsigned offset)
>>>>>> return GPIOF_INPUT;
>>>>>> }
>>>>>> -static int rcar_gpio_request(struct udevice *dev, unsigned offset,
>>>>>> - const char *label)
>>>>>> -{
>>>>>> - return pinctrl_gpio_request(dev, offset, label);
>>>>>> -}
>>>>>> -
>>>>>> -static int rcar_gpio_free(struct udevice *dev, unsigned offset)
>>>>>> -{
>>>>>> - return pinctrl_gpio_free(dev, offset);
>>>>>> -}
>>>>>> -
>>>>>> static const struct dm_gpio_ops rcar_gpio_ops = {
>>>>>> - .request = rcar_gpio_request,
>>>>>> - .rfree = rcar_gpio_free,
>>>>>> + .request = pinctrl_gpio_request,
>>>>>> + .rfree = pinctrl_gpio_free,
>>>>>> .direction_input = rcar_gpio_direction_input,
>>>>>> .direction_output = rcar_gpio_direction_output,
>>>>>> .get_value = rcar_gpio_get_value,
The patch is obviously OK,
Reviewed-by: Marek Vasut <marex@denx.de>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] gpio: renesas: Simplify .request/.rfree callbacks
2022-08-02 10:06 [PATCH] gpio: renesas: Simplify .request/.rfree callbacks Pali Rohár
2022-08-03 6:48 ` Stefan Roese
@ 2023-05-16 19:03 ` Pali Rohár
1 sibling, 0 replies; 9+ messages in thread
From: Pali Rohár @ 2023-05-16 19:03 UTC (permalink / raw)
To: u-boot
PING?
Another patch mentioned today which stay there for more than 8 months?
On Tuesday 02 August 2022 12:06:55 Pali Rohár wrote:
> Remove identify wrapper functions.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
> drivers/gpio/gpio-rcar.c | 15 ++-------------
> 1 file changed, 2 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
> index 138801850d3e..ba00bb459679 100644
> --- a/drivers/gpio/gpio-rcar.c
> +++ b/drivers/gpio/gpio-rcar.c
> @@ -130,20 +130,9 @@ static int rcar_gpio_get_function(struct udevice *dev, unsigned offset)
> return GPIOF_INPUT;
> }
>
> -static int rcar_gpio_request(struct udevice *dev, unsigned offset,
> - const char *label)
> -{
> - return pinctrl_gpio_request(dev, offset, label);
> -}
> -
> -static int rcar_gpio_free(struct udevice *dev, unsigned offset)
> -{
> - return pinctrl_gpio_free(dev, offset);
> -}
> -
> static const struct dm_gpio_ops rcar_gpio_ops = {
> - .request = rcar_gpio_request,
> - .rfree = rcar_gpio_free,
> + .request = pinctrl_gpio_request,
> + .rfree = pinctrl_gpio_free,
> .direction_input = rcar_gpio_direction_input,
> .direction_output = rcar_gpio_direction_output,
> .get_value = rcar_gpio_get_value,
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-05-16 19:03 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-02 10:06 [PATCH] gpio: renesas: Simplify .request/.rfree callbacks Pali Rohár
2022-08-03 6:48 ` Stefan Roese
2022-09-02 19:56 ` Pali Rohár
2022-10-09 12:34 ` Pali Rohár
2022-11-01 22:57 ` Pali Rohár
2022-11-02 8:58 ` Stefan Roese
2022-11-21 17:39 ` Pali Rohár
2022-11-25 21:31 ` Marek Vasut
2023-05-16 19:03 ` Pali Rohár
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.