* [PATCH -next] platform: x86: fix silead_dmi build error and depends
@ 2017-01-31 0:44 Randy Dunlap
2017-01-31 8:39 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2017-01-31 0:44 UTC (permalink / raw)
To: Platform Driver, Darren Hart, Andy Shevchenko; +Cc: Hans de Goede, LKML
From: Randy Dunlap <rdunlap@infradead.org>
This driver cannot be built as a loadable module, so it should not
be built unless I2C=y and INPUT=y.
Fixes this build error:
drivers/built-in.o: In function `silead_ts_dmi_init':
silead_dmi.c:(.init.text+0xf00e): undefined reference to `i2c_bus_type'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Hans de Goede <hdegoede@redhat.com>
---
drivers/platform/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
I don't see why the "depends on INPUT" was there at all,
but I modified its requirement anyway. Maybe it can be removed...
--- linux-next-20170130.orig/drivers/platform/x86/Kconfig
+++ linux-next-20170130/drivers/platform/x86/Kconfig
@@ -1079,7 +1079,7 @@ config INTEL_TURBO_MAX_3
config SILEAD_DMI
bool "Tablets with Silead touchscreens"
- depends on ACPI && DMI && I2C && INPUT
+ depends on ACPI && DMI && I2C=y && INPUT=y
---help---
Certain ACPI based tablets with Silead touchscreens do not have
enough data in ACPI tables for the touchscreen driver to handle
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] platform: x86: fix silead_dmi build error and depends
2017-01-31 0:44 [PATCH -next] platform: x86: fix silead_dmi build error and depends Randy Dunlap
@ 2017-01-31 8:39 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2017-01-31 8:39 UTC (permalink / raw)
To: Randy Dunlap, Platform Driver, Darren Hart, Andy Shevchenko; +Cc: LKML
Hi,
On 31-01-17 01:44, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> This driver cannot be built as a loadable module, so it should not
> be built unless I2C=y and INPUT=y.
>
> Fixes this build error:
> drivers/built-in.o: In function `silead_ts_dmi_init':
> silead_dmi.c:(.init.text+0xf00e): undefined reference to `i2c_bus_type'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Hans de Goede <hdegoede@redhat.com>
Thank you for catching this. However the depends on INPUT is not
necessary at all (likely a copy and paste error during development)
can you please do a v2 dropping the input dependency all together ?
Regards,
Hans
> ---
> drivers/platform/x86/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> I don't see why the "depends on INPUT" was there at all,
> but I modified its requirement anyway. Maybe it can be removed...
>
> --- linux-next-20170130.orig/drivers/platform/x86/Kconfig
> +++ linux-next-20170130/drivers/platform/x86/Kconfig
> @@ -1079,7 +1079,7 @@ config INTEL_TURBO_MAX_3
>
> config SILEAD_DMI
> bool "Tablets with Silead touchscreens"
> - depends on ACPI && DMI && I2C && INPUT
> + depends on ACPI && DMI && I2C=y && INPUT=y
> ---help---
> Certain ACPI based tablets with Silead touchscreens do not have
> enough data in ACPI tables for the touchscreen driver to handle
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-31 8:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-31 0:44 [PATCH -next] platform: x86: fix silead_dmi build error and depends Randy Dunlap
2017-01-31 8:39 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.