* [PATCH] usb: host: USB_XHCI_RZV2M depends on USB_GADGET
@ 2023-02-05 2:12 Tom Rix
2023-02-05 8:52 ` Biju Das
0 siblings, 1 reply; 3+ messages in thread
From: Tom Rix @ 2023-02-05 2:12 UTC (permalink / raw)
To: gregkh, arnd, linus.walleij, artur.bujdoso, miquel.raynal,
colin.i.king, biju.das.jz, tmaimon77
Cc: linux-usb, linux-kernel, Tom Rix
A rand config causes this link error
ld: drivers/usb/host/xhci-rzv2m.o: in function `xhci_rzv2m_init_quirk':
xhci-rzv2m.c:(.text+0x13): undefined reference to `rzv2m_usb3drd_reset'
xhci_rzv2m_init_quirk build is controlled by USB_XHCI_RZV2M
rzv2m_usb3drd_reset build is controlled by USB_RZV2M_USB3DRD
USE_XHCI_RZV2M does select USB_RZV2M_USB3DRD, but USB_RZV2M_USB3DRD
depends on USB_GADGET, so now does USE_XHCI_RZV2M.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/usb/host/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index 2b80ce9587c1..2dd9e95a5b86 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -100,6 +100,7 @@ config USB_XHCI_RZV2M
tristate "xHCI support for Renesas RZ/V2M SoC"
depends on USB_XHCI_PLATFORM
depends on ARCH_R9A09G011 || COMPILE_TEST
+ depends on USB_GADGET
select USB_RZV2M_USB3DRD
help
Say 'Y' to enable the support for the xHCI host controller
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] usb: host: USB_XHCI_RZV2M depends on USB_GADGET
2023-02-05 2:12 [PATCH] usb: host: USB_XHCI_RZV2M depends on USB_GADGET Tom Rix
@ 2023-02-05 8:52 ` Biju Das
2023-02-05 14:26 ` Tom Rix
0 siblings, 1 reply; 3+ messages in thread
From: Biju Das @ 2023-02-05 8:52 UTC (permalink / raw)
To: Tom Rix, gregkh, arnd, linus.walleij, artur.bujdoso,
miquel.raynal, colin.i.king, tmaimon77
Cc: linux-usb, linux-kernel
Hi Tom,
Thanks for the patch.
Arnd send a patch for refactoring the USB_XHCI_RZV2M KConfig dependencies related to USB_GADGET on [1] and
is in usb-next. Do you see this issue after applying[1]?
[1] https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id=ec5499d338ece9db9b7590649d3cfcc4d7f9603d
Cheers,
Biju
> -----Original Message-----
> From: Tom Rix <trix@redhat.com>
> Sent: Sunday, February 5, 2023 2:12 AM
> To: gregkh@linuxfoundation.org; arnd@arndb.de; linus.walleij@linaro.org;
> artur.bujdoso@gmail.com; miquel.raynal@bootlin.com; colin.i.king@gmail.com;
> Biju Das <biju.das.jz@bp.renesas.com>; tmaimon77@gmail.com
> Cc: linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; Tom Rix
> <trix@redhat.com>
> Subject: [PATCH] usb: host: USB_XHCI_RZV2M depends on USB_GADGET
>
> A rand config causes this link error
> ld: drivers/usb/host/xhci-rzv2m.o: in function `xhci_rzv2m_init_quirk':
> xhci-rzv2m.c:(.text+0x13): undefined reference to `rzv2m_usb3drd_reset'
>
> xhci_rzv2m_init_quirk build is controlled by USB_XHCI_RZV2M
> rzv2m_usb3drd_reset build is controlled by USB_RZV2M_USB3DRD
>
> USE_XHCI_RZV2M does select USB_RZV2M_USB3DRD, but USB_RZV2M_USB3DRD depends
> on USB_GADGET, so now does USE_XHCI_RZV2M.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/usb/host/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index
> 2b80ce9587c1..2dd9e95a5b86 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -100,6 +100,7 @@ config USB_XHCI_RZV2M
> tristate "xHCI support for Renesas RZ/V2M SoC"
> depends on USB_XHCI_PLATFORM
> depends on ARCH_R9A09G011 || COMPILE_TEST
> + depends on USB_GADGET
> select USB_RZV2M_USB3DRD
> help
> Say 'Y' to enable the support for the xHCI host controller
> --
> 2.27.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: host: USB_XHCI_RZV2M depends on USB_GADGET
2023-02-05 8:52 ` Biju Das
@ 2023-02-05 14:26 ` Tom Rix
0 siblings, 0 replies; 3+ messages in thread
From: Tom Rix @ 2023-02-05 14:26 UTC (permalink / raw)
To: Biju Das, gregkh, arnd, linus.walleij, artur.bujdoso,
miquel.raynal, colin.i.king, tmaimon77
Cc: linux-usb, linux-kernel
On 2/5/23 12:52 AM, Biju Das wrote:
> Hi Tom,
>
> Thanks for the patch.
>
> Arnd send a patch for refactoring the USB_XHCI_RZV2M KConfig dependencies related to USB_GADGET on [1] and
> is in usb-next. Do you see this issue after applying[1]?
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id=ec5499d338ece9db9b7590649d3cfcc4d7f9603d
From reviewing, it will likely work.
Tom
> Cheers,
> Biju
>
>> -----Original Message-----
>> From: Tom Rix <trix@redhat.com>
>> Sent: Sunday, February 5, 2023 2:12 AM
>> To: gregkh@linuxfoundation.org; arnd@arndb.de; linus.walleij@linaro.org;
>> artur.bujdoso@gmail.com; miquel.raynal@bootlin.com; colin.i.king@gmail.com;
>> Biju Das <biju.das.jz@bp.renesas.com>; tmaimon77@gmail.com
>> Cc: linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; Tom Rix
>> <trix@redhat.com>
>> Subject: [PATCH] usb: host: USB_XHCI_RZV2M depends on USB_GADGET
>>
>> A rand config causes this link error
>> ld: drivers/usb/host/xhci-rzv2m.o: in function `xhci_rzv2m_init_quirk':
>> xhci-rzv2m.c:(.text+0x13): undefined reference to `rzv2m_usb3drd_reset'
>>
>> xhci_rzv2m_init_quirk build is controlled by USB_XHCI_RZV2M
>> rzv2m_usb3drd_reset build is controlled by USB_RZV2M_USB3DRD
>>
>> USE_XHCI_RZV2M does select USB_RZV2M_USB3DRD, but USB_RZV2M_USB3DRD depends
>> on USB_GADGET, so now does USE_XHCI_RZV2M.
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>> ---
>> drivers/usb/host/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index
>> 2b80ce9587c1..2dd9e95a5b86 100644
>> --- a/drivers/usb/host/Kconfig
>> +++ b/drivers/usb/host/Kconfig
>> @@ -100,6 +100,7 @@ config USB_XHCI_RZV2M
>> tristate "xHCI support for Renesas RZ/V2M SoC"
>> depends on USB_XHCI_PLATFORM
>> depends on ARCH_R9A09G011 || COMPILE_TEST
>> + depends on USB_GADGET
>> select USB_RZV2M_USB3DRD
>> help
>> Say 'Y' to enable the support for the xHCI host controller
>> --
>> 2.27.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-05 14:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-05 2:12 [PATCH] usb: host: USB_XHCI_RZV2M depends on USB_GADGET Tom Rix
2023-02-05 8:52 ` Biju Das
2023-02-05 14:26 ` Tom Rix
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.