All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Suman Anna <s-anna@ti.com>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>,
	Kishon Vijay Abraham <kishon@ti.com>
Subject: Re: [PATCH] soc: ti: pruss: fix referenced node in error message
Date: Sat, 20 Nov 2021 08:53:51 +0100	[thread overview]
Message-ID: <469b98e1-7500-0912-54c3-945c193f086a@siemens.com> (raw)
In-Reply-To: <1cbf299b-cc4f-cab6-62ef-db7c19aa0876@siemens.com>

On 01.09.21 17:03, Jan Kiszka wrote:
> On 23.06.21 17:51, Suman Anna wrote:
>> On 6/21/21 1:08 PM, Jan Kiszka wrote:
>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>
>>> So far, "(null)" is reported for the node that is missing clocks.
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Acked-by: Suman Anna <s-anna@ti.com>
>>
>>> ---
>>>  drivers/soc/ti/pruss.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c
>>> index f22ac1edbdd0..afc8aae68035 100644
>>> --- a/drivers/soc/ti/pruss.c
>>> +++ b/drivers/soc/ti/pruss.c
>>> @@ -129,7 +129,7 @@ static int pruss_clk_init(struct pruss *pruss, struct device_node *cfg_node)
>>>  
>>>  	clks_np = of_get_child_by_name(cfg_node, "clocks");
>>>  	if (!clks_np) {
>>> -		dev_err(dev, "%pOF is missing its 'clocks' node\n", clks_np);
>>> +		dev_err(dev, "%pOF is missing its 'clocks' node\n", cfg_node);
>>>  		return -ENODEV;
>>>  	}
>>>  
>>>
>>
> 
> This was not merged yet. Is it queued somewhere?
> 
> Jan
> 

Second reminder - still not seeing this in upstream.

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux

WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Suman Anna <s-anna@ti.com>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>,
	Kishon Vijay Abraham <kishon@ti.com>
Subject: Re: [PATCH] soc: ti: pruss: fix referenced node in error message
Date: Sat, 20 Nov 2021 08:53:51 +0100	[thread overview]
Message-ID: <469b98e1-7500-0912-54c3-945c193f086a@siemens.com> (raw)
In-Reply-To: <1cbf299b-cc4f-cab6-62ef-db7c19aa0876@siemens.com>

On 01.09.21 17:03, Jan Kiszka wrote:
> On 23.06.21 17:51, Suman Anna wrote:
>> On 6/21/21 1:08 PM, Jan Kiszka wrote:
>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>>
>>> So far, "(null)" is reported for the node that is missing clocks.
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Acked-by: Suman Anna <s-anna@ti.com>
>>
>>> ---
>>>  drivers/soc/ti/pruss.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c
>>> index f22ac1edbdd0..afc8aae68035 100644
>>> --- a/drivers/soc/ti/pruss.c
>>> +++ b/drivers/soc/ti/pruss.c
>>> @@ -129,7 +129,7 @@ static int pruss_clk_init(struct pruss *pruss, struct device_node *cfg_node)
>>>  
>>>  	clks_np = of_get_child_by_name(cfg_node, "clocks");
>>>  	if (!clks_np) {
>>> -		dev_err(dev, "%pOF is missing its 'clocks' node\n", clks_np);
>>> +		dev_err(dev, "%pOF is missing its 'clocks' node\n", cfg_node);
>>>  		return -ENODEV;
>>>  	}
>>>  
>>>
>>
> 
> This was not merged yet. Is it queued somewhere?
> 
> Jan
> 

Second reminder - still not seeing this in upstream.

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-11-20  7:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-21 18:08 [PATCH] soc: ti: pruss: fix referenced node in error message Jan Kiszka
2021-06-21 18:08 ` Jan Kiszka
2021-06-23 15:51 ` Suman Anna
2021-06-23 15:51   ` Suman Anna
2021-09-01 15:03   ` Jan Kiszka
2021-09-01 15:03     ` Jan Kiszka
2021-11-20  7:53     ` Jan Kiszka [this message]
2021-11-20  7:53       ` Jan Kiszka
2021-11-22 15:30       ` Suman Anna
2021-11-22 15:30         ` Suman Anna
2021-11-23  2:04 ` Nishanth Menon
2021-11-23  2:04   ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=469b98e1-7500-0912-54c3-945c193f086a@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=grzegorz.jaszczyk@linaro.org \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s-anna@ti.com \
    --cc=ssantosh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.