Yoctoproject.org cgit tags CSS

Yoctoproject.org cgit tags CSS

[Anders Montonen]

Hi,

Since some time, the tags in the log view of yoctoproject.org’s cgit have not been highlighted correctly. The problem seems to be that in the HTML, tags are given the class “tag-annotated-deco”, which doesn’t exist in the CSS. The CSS does have a “tag-deco” style which is probably what’s intended.

Regards,
Anders Montonen

Re: [yocto] Yoctoproject.org cgit tags CSS

[Michael Halstead]

[-- Attachment #1: Type: text/plain, Size: 651 bytes --]

I've copied the style into the new class name. Please let me know if this
looks correct to you.

On Mon, Nov 9, 2020 at 12:29 PM Anders Montonen <Anders.Montonen@iki.fi>
wrote:

> Hi,
>
> Since some time, the tags in the log view of yoctoproject.org’s cgit have
> not been highlighted correctly. The problem seems to be that in the HTML,
> tags are given the class “tag-annotated-deco”, which doesn’t exist in the
> CSS. The CSS does have a “tag-deco” style which is probably what’s intended.
>
> Regards,
> Anders Montonen
> 
>
>

-- 
Michael Halstead
Linux Foundation / Yocto Project
Systems Operations Engineer

[-- Attachment #2: Type: text/html, Size: 1122 bytes --]

Re: [yocto] Yoctoproject.org cgit tags CSS

[Alexander Kanavin]

[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]

I am not seeing a change - the tags are still not highlighted (e.g. commit
on top):
http://git.yoctoproject.org/cgit.cgi/poky/log/?h=yocto-3.2

This file still contains only the old name:
http://git.yoctoproject.org/cgit/cgit.css

Alex

On Tue, 10 Nov 2020 at 08:24, Michael Halstead <
mhalstead@linuxfoundation.org> wrote:

> I've copied the style into the new class name. Please let me know if this
> looks correct to you.
>
> On Mon, Nov 9, 2020 at 12:29 PM Anders Montonen <Anders.Montonen@iki.fi>
> wrote:
>
>> Hi,
>>
>> Since some time, the tags in the log view of yoctoproject.org’s cgit
>> have not been highlighted correctly. The problem seems to be that in the
>> HTML, tags are given the class “tag-annotated-deco”, which doesn’t exist in
>> the CSS. The CSS does have a “tag-deco” style which is probably what’s
>> intended.
>>
>> Regards,
>> Anders Montonen
>>
>>
>>
>
> --
> Michael Halstead
> Linux Foundation / Yocto Project
> Systems Operations Engineer
>
> 
>
>

[-- Attachment #2: Type: text/html, Size: 1957 bytes --]

Re: [yocto] Yoctoproject.org cgit tags CSS

[Anders Montonen]

[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]

Hi,

The tags now show as white text on yellow background, which is unreadable. I think you must copy "table.list td a.tag-deco” too, to set the text color.
Btw, this is probably the same as <https://bugzilla.yoctoproject.org/show_bug.cgi?id=13668>.

Regards,
Anders Montonen

> On 10 Nov 2020, at 9:24, Michael Halstead <mhalstead@linuxfoundation.org> wrote:
> 
> I've copied the style into the new class name. Please let me know if this looks correct to you.
> 
> On Mon, Nov 9, 2020 at 12:29 PM Anders Montonen <Anders.Montonen@iki.fi <mailto:Anders.Montonen@iki.fi>> wrote:
> Hi,
> 
> Since some time, the tags in the log view of yoctoproject.org <http://yoctoproject.org/>’s cgit have not been highlighted correctly. The problem seems to be that in the HTML, tags are given the class “tag-annotated-deco”, which doesn’t exist in the CSS. The CSS does have a “tag-deco” style which is probably what’s intended.
> 
> Regards,
> Anders Montonen
> 
> 
> 
> 
> -- 
> Michael Halstead
> Linux Foundation / Yocto Project
> Systems Operations Engineer
> 
> 
> 


[-- Attachment #2: Type: text/html, Size: 2365 bytes --]

Re: [yocto] Yoctoproject.org cgit tags CSS

[Anders Montonen]

[-- Attachment #1: Type: text/plain, Size: 1461 bytes --]

Hi,

The previous change also seems to have broken the tag highlighting for the light theme.

Regards,
Anders Montonen

> On 10 Nov 2020, at 10:52, Anders Montonen <Anders.Montonen@iki.fi> wrote:
> 
> Hi,
> 
> The tags now show as white text on yellow background, which is unreadable. I think you must copy "table.list td a.tag-deco” too, to set the text color.
> Btw, this is probably the same as <https://bugzilla.yoctoproject.org/show_bug.cgi?id=13668 <https://bugzilla.yoctoproject.org/show_bug.cgi?id=13668>>.
> 
> Regards,
> Anders Montonen
> 
>> On 10 Nov 2020, at 9:24, Michael Halstead <mhalstead@linuxfoundation.org <mailto:mhalstead@linuxfoundation.org>> wrote:
>> 
>> I've copied the style into the new class name. Please let me know if this looks correct to you.
>> 
>> On Mon, Nov 9, 2020 at 12:29 PM Anders Montonen <Anders.Montonen@iki.fi <mailto:Anders.Montonen@iki.fi>> wrote:
>> Hi,
>> 
>> Since some time, the tags in the log view of yoctoproject.org <http://yoctoproject.org/>’s cgit have not been highlighted correctly. The problem seems to be that in the HTML, tags are given the class “tag-annotated-deco”, which doesn’t exist in the CSS. The CSS does have a “tag-deco” style which is probably what’s intended.
>> 
>> Regards,
>> Anders Montonen
>> 
>> 
>> 
>> 
>> -- 
>> Michael Halstead
>> Linux Foundation / Yocto Project
>> Systems Operations Engineer
>> 
>> 
>> 
> 
> 
> 


[-- Attachment #2: Type: text/html, Size: 6088 bytes --]