From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "neal_liu@aspeedtech.com" <neal_liu@aspeedtech.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"balbi@kernel.org" <balbi@kernel.org>
Subject: Re: [PATCH] usb: gadget: aspeed_udc: fix handling of tx_len == 0
Date: Fri, 24 Jun 2022 16:39:50 +1000 [thread overview]
Message-ID: <46f88070d8f6f47f55310e964a4576cadbc810f4.camel@kernel.crashing.org> (raw)
In-Reply-To: <20220624063457.GG11460@kadam>
(switching back to my normal "community" email)
On Fri, 2022-06-24 at 09:34 +0300, Dan Carpenter wrote:
> > Hrm... what is that driver ? I've missed it ... is the code lifted
> > from
> > aspeed-vhub ? If yes, should we instead make it a common code base
> > ?
> > And if there are bug fixes on one they might apply to the other as
> > well...
>
>
> No, I'm the person who introduced the bug so it's unique to this
> driver.
Ok thanks. That said, the code looks fairly similar to the vhub code,
so my comment stands, if this is the same IP block, which it appears to
be, the driver should be common.
IE. The vhub is made of a virtual hub with a bunch of UDCs underneath,
this appears to address the ast2600 "new" standalone (no hub) variant
of said UDC if I'm not mistaken.
The way I structured the code in vhub, it shouldn't be overly difficult
to make it standalone. I wrote (and maintain) aspeed-vhub and would be
happy to work on this if I got sent an ast2600 board.
Cheers,
Ben.
next prev parent reply other threads:[~2022-06-24 6:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 14:50 [PATCH] usb: gadget: aspeed_udc: fix handling of tx_len == 0 Dan Carpenter
2022-06-23 1:41 ` Neal Liu
2022-06-23 6:43 ` Dan Carpenter
2022-06-23 7:22 ` Dan Carpenter
2022-06-23 7:52 ` Neal Liu
2022-06-23 7:55 ` Dan Carpenter
2022-06-23 8:37 ` Neal Liu
2022-06-24 6:17 ` Herrenschmidt, Benjamin
2022-06-24 6:34 ` Dan Carpenter
2022-06-24 6:39 ` Benjamin Herrenschmidt [this message]
2022-06-24 7:46 ` Neal Liu
2022-06-27 1:30 ` Benjamin Herrenschmidt
2022-06-28 7:17 ` Neal Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46f88070d8f6f47f55310e964a4576cadbc810f4.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=balbi@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-usb@vger.kernel.org \
--cc=neal_liu@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.