All of lore.kernel.org
 help / color / mirror / Atom feed
From: Neal Liu <neal_liu@aspeedtech.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Dan Carpenter <dan.carpenter@oracle.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>,
	"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
	"balbi@kernel.org" <balbi@kernel.org>
Subject: RE: [PATCH] usb: gadget: aspeed_udc: fix handling of tx_len == 0
Date: Tue, 28 Jun 2022 07:17:41 +0000	[thread overview]
Message-ID: <HK0PR06MB3202F5E3C643A4943BB521A480B89@HK0PR06MB3202.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <c960c2e02ddeacd527442e0b3b0db532c9017e1b.camel@kernel.crashing.org>

> On Fri, 2022-06-24 at 07:46 +0000, Neal Liu wrote:
> > >
> > Hi Ben, This UDC is the independent IP. The ast2600 board can run
> > aspeed-vhub & aspeed_udc simultaneously with different USB port.
> > I think it's no need to restruct the code in vhub.
> 
> But is it a copy of the same base IP block ? IE, is the fundamental HW interface
> of the independent UDC operating the same way with the same register layout
> as one of the ports of the vHUB ?
> 
> I don't like having multiple drivers for the same hardware... if it's different
> enough, then let's keep it separate, but if not, we should definitely split the udc
> from the existing vhub code so that the same driver can operate standalone or
> beneath a vhub.
> 

Based on ast2600 hardware design, it's similar, but not exactly the same.
I need more time to extract the differences and evaluate it if it could utilize vhub.

> Cheers,
> Ben.


      reply	other threads:[~2022-06-28  7:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-22 14:50 [PATCH] usb: gadget: aspeed_udc: fix handling of tx_len == 0 Dan Carpenter
2022-06-23  1:41 ` Neal Liu
2022-06-23  6:43   ` Dan Carpenter
2022-06-23  7:22     ` Dan Carpenter
2022-06-23  7:52       ` Neal Liu
2022-06-23  7:55         ` Dan Carpenter
2022-06-23  8:37           ` Neal Liu
2022-06-24  6:17     ` Herrenschmidt, Benjamin
2022-06-24  6:34       ` Dan Carpenter
2022-06-24  6:39         ` Benjamin Herrenschmidt
2022-06-24  7:46           ` Neal Liu
2022-06-27  1:30             ` Benjamin Herrenschmidt
2022-06-28  7:17               ` Neal Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=HK0PR06MB3202F5E3C643A4943BB521A480B89@HK0PR06MB3202.apcprd06.prod.outlook.com \
    --to=neal_liu@aspeedtech.com \
    --cc=balbi@kernel.org \
    --cc=benh@kernel.crashing.org \
    --cc=dan.carpenter@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.