From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 10/12] usb: r8a66597-hcd: Convert to clk_prepare/unprepare
Date: Sat, 09 Nov 2013 14:12:05 +0000 [thread overview]
Message-ID: <4726188.sxDyZ3Q5gt@avalon> (raw)
In-Reply-To: <526F842E.1010607@renesas.com>
Hi Greg,
On Tuesday 29 October 2013 18:47:26 Shimoda, Yoshihiro wrote:
> Hi Laurent-san,
>
> (2013/10/29 7:49), Laurent Pinchart wrote:
> > Turn clk_enable() and clk_disable() calls into clk_prepare_enable() and
> > clk_disable_unprepare() to get ready for the migration to the common
> > clock framework.
> >
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > Cc: linux-usb@vger.kernel.org
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
>
> Thank you for the patch.
>
> Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Could you please pick this patch up ?
> > ---
> >
> > drivers/usb/host/r8a66597-hcd.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/usb/host/r8a66597-hcd.c
> > b/drivers/usb/host/r8a66597-hcd.c index 2ad004a..a2fdd85 100644
> > --- a/drivers/usb/host/r8a66597-hcd.c
> > +++ b/drivers/usb/host/r8a66597-hcd.c
> > @@ -95,7 +95,7 @@ static int r8a66597_clock_enable(struct r8a66597
> > *r8a66597)>
> > int i = 0;
> >
> > if (r8a66597->pdata->on_chip) {
> >
> > - clk_enable(r8a66597->clk);
> > + clk_prepare_enable(r8a66597->clk);
> >
> > do {
> >
> > r8a66597_write(r8a66597, SCKE, SYSCFG0);
> > tmp = r8a66597_read(r8a66597, SYSCFG0);
> >
> > @@ -139,7 +139,7 @@ static void r8a66597_clock_disable(struct r8a66597
> > *r8a66597)>
> > udelay(1);
> >
> > if (r8a66597->pdata->on_chip) {
> >
> > - clk_disable(r8a66597->clk);
> > + clk_disable_unprepare(r8a66597->clk);
> >
> > } else {
> >
> > r8a66597_bclr(r8a66597, PLLC, SYSCFG0);
> > r8a66597_bclr(r8a66597, XCKE, SYSCFG0);
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 10/12] usb: r8a66597-hcd: Convert to clk_prepare/unprepare
Date: Sat, 09 Nov 2013 15:12:05 +0100 [thread overview]
Message-ID: <4726188.sxDyZ3Q5gt@avalon> (raw)
In-Reply-To: <526F842E.1010607@renesas.com>
Hi Greg,
On Tuesday 29 October 2013 18:47:26 Shimoda, Yoshihiro wrote:
> Hi Laurent-san,
>
> (2013/10/29 7:49), Laurent Pinchart wrote:
> > Turn clk_enable() and clk_disable() calls into clk_prepare_enable() and
> > clk_disable_unprepare() to get ready for the migration to the common
> > clock framework.
> >
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > Cc: linux-usb at vger.kernel.org
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
>
> Thank you for the patch.
>
> Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Could you please pick this patch up ?
> > ---
> >
> > drivers/usb/host/r8a66597-hcd.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/usb/host/r8a66597-hcd.c
> > b/drivers/usb/host/r8a66597-hcd.c index 2ad004a..a2fdd85 100644
> > --- a/drivers/usb/host/r8a66597-hcd.c
> > +++ b/drivers/usb/host/r8a66597-hcd.c
> > @@ -95,7 +95,7 @@ static int r8a66597_clock_enable(struct r8a66597
> > *r8a66597)>
> > int i = 0;
> >
> > if (r8a66597->pdata->on_chip) {
> >
> > - clk_enable(r8a66597->clk);
> > + clk_prepare_enable(r8a66597->clk);
> >
> > do {
> >
> > r8a66597_write(r8a66597, SCKE, SYSCFG0);
> > tmp = r8a66597_read(r8a66597, SYSCFG0);
> >
> > @@ -139,7 +139,7 @@ static void r8a66597_clock_disable(struct r8a66597
> > *r8a66597)>
> > udelay(1);
> >
> > if (r8a66597->pdata->on_chip) {
> >
> > - clk_disable(r8a66597->clk);
> > + clk_disable_unprepare(r8a66597->clk);
> >
> > } else {
> >
> > r8a66597_bclr(r8a66597, PLLC, SYSCFG0);
> > r8a66597_bclr(r8a66597, XCKE, SYSCFG0);
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-11-09 14:12 UTC|newest]
Thread overview: 202+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-28 22:49 [PATCH 00/12] Prepare various SH/R Mobile/Car drivers for CCF migration Laurent Pinchart
2013-10-28 22:49 ` Laurent Pinchart
2013-10-28 22:49 ` Laurent Pinchart
2013-10-28 22:49 ` [PATCH 01/12] clocksource: sh_cmt: Add clk_prepare/unprepare support Laurent Pinchart
2013-10-28 22:49 ` Laurent Pinchart
2013-10-28 22:49 ` Laurent Pinchart
2013-10-29 5:55 ` Simon Horman
2013-10-29 5:55 ` Simon Horman
2013-10-29 5:55 ` Simon Horman
2013-10-29 9:55 ` Laurent Pinchart
2013-10-29 9:55 ` Laurent Pinchart
2013-10-29 9:55 ` Laurent Pinchart
2013-10-30 0:10 ` Simon Horman
2013-10-30 0:10 ` Simon Horman
2013-10-30 0:10 ` Simon Horman
2013-10-30 0:13 ` Laurent Pinchart
2013-10-30 0:13 ` Laurent Pinchart
2013-10-30 0:13 ` Laurent Pinchart
2013-10-30 0:27 ` Simon Horman
2013-10-30 0:27 ` Simon Horman
2013-10-30 0:27 ` Simon Horman
2013-10-28 22:49 ` [PATCH 02/12] clocksource: sh_mtu2: " Laurent Pinchart
2013-10-28 22:49 ` Laurent Pinchart
2013-10-28 22:49 ` Laurent Pinchart
2013-10-29 5:55 ` Simon Horman
2013-10-29 5:55 ` Simon Horman
2013-10-29 5:55 ` Simon Horman
2013-10-29 11:15 ` Sergei Shtylyov
2013-10-29 11:15 ` Sergei Shtylyov
2013-10-29 11:15 ` Sergei Shtylyov
2013-10-29 13:24 ` Laurent Pinchart
2013-10-29 13:24 ` Laurent Pinchart
2013-10-29 13:24 ` Laurent Pinchart
2013-10-29 14:30 ` [PATCH v2 1/2] clocksource: sh_mtu2: Release clock when sh_mtu2_register() fails Laurent Pinchart
2013-10-29 14:30 ` Laurent Pinchart
2013-10-29 14:30 ` Laurent Pinchart
2013-10-29 14:30 ` [PATCH v2 2/2] clocksource: sh_mtu2: Add clk_prepare/unprepare support Laurent Pinchart
2013-10-29 14:30 ` Laurent Pinchart
2013-10-29 14:30 ` Laurent Pinchart
2013-10-31 5:23 ` Simon Horman
2013-10-31 5:23 ` Simon Horman
2013-10-31 5:23 ` Simon Horman
2013-11-08 10:10 ` Daniel Lezcano
2013-11-08 10:10 ` Daniel Lezcano
2013-11-08 10:10 ` Daniel Lezcano
2013-10-31 5:23 ` [PATCH v2 1/2] clocksource: sh_mtu2: Release clock when sh_mtu2_register() fails Simon Horman
2013-10-31 5:23 ` Simon Horman
2013-10-31 5:23 ` Simon Horman
2013-11-08 10:10 ` Daniel Lezcano
2013-11-08 10:10 ` Daniel Lezcano
2013-11-08 10:10 ` Daniel Lezcano
2013-10-28 22:49 ` [PATCH 03/12] clocksource: sh_tmu: Add clk_prepare/unprepare support Laurent Pinchart
2013-10-28 22:49 ` Laurent Pinchart
2013-10-28 22:49 ` Laurent Pinchart
2013-10-29 5:55 ` Simon Horman
2013-10-29 5:55 ` Simon Horman
2013-10-29 5:55 ` Simon Horman
2013-10-29 11:17 ` Sergei Shtylyov
2013-10-29 11:17 ` Sergei Shtylyov
2013-10-29 11:17 ` Sergei Shtylyov
2013-10-29 14:31 ` [PATCH v2 1/2] clocksource: sh_tmu: Release clock when sh_tmu_register() fails Laurent Pinchart
2013-10-29 14:31 ` Laurent Pinchart
2013-10-29 14:31 ` Laurent Pinchart
2013-10-29 14:31 ` [PATCH v2 2/2] clocksource: sh_tmu: Add clk_prepare/unprepare support Laurent Pinchart
2013-10-29 14:31 ` Laurent Pinchart
2013-10-29 14:31 ` Laurent Pinchart
2013-10-31 5:24 ` Simon Horman
2013-10-31 5:24 ` Simon Horman
2013-10-31 5:24 ` Simon Horman
2013-11-07 13:40 ` Daniel Lezcano
2013-11-07 13:40 ` Daniel Lezcano
2013-11-07 13:40 ` Daniel Lezcano
2013-11-08 5:22 ` Simon Horman
2013-11-08 5:22 ` Simon Horman
2013-11-08 5:22 ` Simon Horman
2013-11-08 10:10 ` Daniel Lezcano
2013-11-08 10:10 ` Daniel Lezcano
2013-11-08 10:10 ` Daniel Lezcano
2013-10-31 5:23 ` [PATCH v2 1/2] clocksource: sh_tmu: Release clock when sh_tmu_register() fails Simon Horman
2013-10-31 5:23 ` Simon Horman
2013-10-31 5:23 ` Simon Horman
2013-11-08 10:10 ` Daniel Lezcano
2013-11-08 10:10 ` Daniel Lezcano
2013-11-08 10:10 ` Daniel Lezcano
2013-10-28 22:49 ` [PATCH 04/12] sata_rcar: Convert to clk_prepare/unprepare Laurent Pinchart
2013-10-28 22:49 ` Laurent Pinchart
2013-10-28 22:49 ` Laurent Pinchart
2013-10-29 18:41 ` Tejun Heo
2013-10-29 18:41 ` Tejun Heo
2013-10-29 18:41 ` Tejun Heo
2013-10-28 22:49 ` [PATCH 05/12] drm: shmob_drm: " Laurent Pinchart
2013-10-28 22:49 ` Laurent Pinchart
2013-10-28 22:49 ` Laurent Pinchart
2013-11-09 12:51 ` Laurent Pinchart
2013-11-11 8:55 ` Thierry Reding
2013-11-11 12:55 ` Laurent Pinchart
2013-10-28 22:49 ` [PATCH 06/12] i2c: sh_mobile: " Laurent Pinchart
2013-10-28 22:49 ` Laurent Pinchart
2013-10-28 22:49 ` Laurent Pinchart
2013-10-29 5:02 ` Wolfram Sang
2013-10-29 5:02 ` Wolfram Sang
2013-10-29 5:02 ` Wolfram Sang
2013-10-29 5:58 ` Simon Horman
2013-10-29 5:58 ` Simon Horman
2013-10-29 5:58 ` Simon Horman
2013-10-29 9:41 ` Laurent Pinchart
2013-10-29 9:41 ` Laurent Pinchart
2013-10-29 9:41 ` Laurent Pinchart
2013-10-31 11:49 ` Wolfram Sang
2013-10-31 11:49 ` Wolfram Sang
2013-10-31 11:49 ` Wolfram Sang
2013-10-28 22:49 ` [PATCH 07/12] mmc: sh_mmcif: " Laurent Pinchart
2013-10-28 22:49 ` Laurent Pinchart
2013-10-28 22:49 ` Laurent Pinchart
2013-10-29 8:10 ` Guennadi Liakhovetski
2013-10-29 8:10 ` Guennadi Liakhovetski
2013-10-29 8:10 ` Guennadi Liakhovetski
2013-10-30 22:23 ` Guennadi Liakhovetski
2013-10-30 22:23 ` Guennadi Liakhovetski
2013-10-30 22:23 ` Guennadi Liakhovetski
2013-10-30 23:13 ` Laurent Pinchart
2013-10-30 23:13 ` Laurent Pinchart
2013-10-30 23:13 ` Laurent Pinchart
2013-10-30 23:27 ` Ulf Hansson
2013-10-30 23:27 ` Ulf Hansson
2013-10-30 23:27 ` Ulf Hansson
2013-10-30 23:48 ` Laurent Pinchart
2013-10-30 23:48 ` Laurent Pinchart
2013-10-30 23:48 ` Laurent Pinchart
2013-10-28 22:49 ` [PATCH 08/12] mmc: sh_mobile_sdhi: " Laurent Pinchart
2013-10-28 22:49 ` Laurent Pinchart
2013-10-28 22:49 ` Laurent Pinchart
2013-10-29 8:09 ` Guennadi Liakhovetski
2013-10-29 8:09 ` Guennadi Liakhovetski
2013-10-29 8:09 ` Guennadi Liakhovetski
2013-11-09 12:56 ` Laurent Pinchart
2013-11-09 12:56 ` Laurent Pinchart
2013-11-09 12:56 ` Laurent Pinchart
2013-11-26 2:02 ` Laurent Pinchart
2013-11-26 2:02 ` Laurent Pinchart
2013-11-26 2:02 ` Laurent Pinchart
2013-12-11 12:01 ` Laurent Pinchart
2013-12-11 12:01 ` Laurent Pinchart
2013-12-11 12:01 ` Laurent Pinchart
2013-12-12 1:29 ` Chris Ball
2013-12-12 1:29 ` Chris Ball
2013-12-12 1:29 ` Chris Ball
2013-12-12 2:16 ` Laurent Pinchart
2013-12-12 2:16 ` Laurent Pinchart
2013-12-12 2:16 ` Laurent Pinchart
2013-12-12 2:25 ` Chris Ball
2013-12-12 2:25 ` Chris Ball
2013-12-12 2:25 ` Chris Ball
2013-12-14 1:05 ` Simon Horman
2013-12-14 1:05 ` Simon Horman
2013-12-14 1:05 ` Simon Horman
2013-10-28 22:49 ` [PATCH 09/12] usb: gadget: r8a66597-udc: " Laurent Pinchart
2013-10-28 22:49 ` Laurent Pinchart
2013-10-29 9:47 ` Shimoda, Yoshihiro
2013-10-29 9:47 ` Shimoda, Yoshihiro
2013-11-09 14:09 ` Laurent Pinchart
2013-11-09 14:09 ` Laurent Pinchart
2013-11-11 19:53 ` Felipe Balbi
2013-11-11 19:53 ` Felipe Balbi
2013-11-26 1:59 ` Laurent Pinchart
2013-11-26 1:59 ` Laurent Pinchart
2013-11-26 2:12 ` Felipe Balbi
2013-11-26 2:12 ` Felipe Balbi
2013-11-26 2:16 ` Laurent Pinchart
2013-11-26 2:16 ` Laurent Pinchart
2013-11-26 19:54 ` Felipe Balbi
2013-11-26 19:54 ` Felipe Balbi
2013-11-26 21:43 ` Laurent Pinchart
2013-11-26 21:43 ` Laurent Pinchart
2013-10-28 22:49 ` [PATCH 10/12] usb: r8a66597-hcd: " Laurent Pinchart
2013-10-28 22:49 ` Laurent Pinchart
2013-10-29 9:47 ` Shimoda, Yoshihiro
2013-10-29 9:47 ` Shimoda, Yoshihiro
2013-11-09 14:12 ` Laurent Pinchart [this message]
2013-11-09 14:12 ` Laurent Pinchart
2013-11-09 16:10 ` Greg Kroah-Hartman
2013-11-09 16:10 ` Greg Kroah-Hartman
2013-11-26 2:00 ` Laurent Pinchart
2013-11-26 2:00 ` Laurent Pinchart
2013-11-26 2:36 ` Greg Kroah-Hartman
2013-11-26 2:36 ` Greg Kroah-Hartman
2013-11-26 14:08 ` Laurent Pinchart
2013-11-26 14:08 ` Laurent Pinchart
2013-11-28 8:20 ` Simon Horman
2013-11-28 8:20 ` Simon Horman
2013-10-28 22:49 ` [PATCH 11/12] fbdev: shmobile-hdmi: " Laurent Pinchart
2013-10-28 22:49 ` Laurent Pinchart
2013-10-31 10:48 ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-31 10:48 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-09 14:13 ` Laurent Pinchart
2013-11-09 14:13 ` Laurent Pinchart
2013-11-11 13:34 ` Tomi Valkeinen
2013-11-11 13:34 ` Tomi Valkeinen
2013-10-28 22:49 ` [PATCH 12/12] fbdev: shmobile-lcdcfb: " Laurent Pinchart
2013-10-28 22:49 ` Laurent Pinchart
2013-10-31 10:47 ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-31 10:47 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4726188.sxDyZ3Q5gt@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.