From: Arnd Bergmann <arnd@arndb.de>
To: liviu.dudau@arm.com
Cc: Rongrong Zou <zourongrong@huawei.com>,
Rongrong Zou <zourongrong@gmail.com>,
devicetree@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
Corey Minyard <minyard@acm.org>,
gregkh@linuxfoundation.org, Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, linuxarm@huawei.com,
benh@kernel.crashing.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 3/3] ARM64 LPC: update binding doc
Date: Tue, 12 Jan 2016 23:52:48 +0100 [thread overview]
Message-ID: <4731036.9QlepWb5cE@wuerfel> (raw)
In-Reply-To: <20160112151335.GS13633@e106497-lin.cambridge.arm.com>
On Tuesday 12 January 2016 15:13:35 liviu.dudau@arm.com wrote:
> > int of_address_to_resource(struct device_node *dev, int index,
> > struct resource *r)
> > {
> > ...
> > /* flags can be get here, without ranges property reqired.
> > * if the reg = <0x0 0xe4 4>, I can get flag of IORESOURCE_MEM,
> > * if the reg = <0x1 0xe4 4>, I can get flag of IORESOURCE_IO,
>
> That is strange, the parent node has #address-cells = <2> so the first two numbers should be part
> of the address and not influence the flags. Can you add some debugging in of_get_address() and
> try to figure out what bus is used in *flags = bus->get_flags(prop) ?
>
>
This is the standard ISA binding. The first cell is the address space
(IO or MEM), the second cell is the address within that space. This
is similar to how PCI works.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 3/3] ARM64 LPC: update binding doc
Date: Tue, 12 Jan 2016 23:52:48 +0100 [thread overview]
Message-ID: <4731036.9QlepWb5cE@wuerfel> (raw)
In-Reply-To: <20160112151335.GS13633@e106497-lin.cambridge.arm.com>
On Tuesday 12 January 2016 15:13:35 liviu.dudau at arm.com wrote:
> > int of_address_to_resource(struct device_node *dev, int index,
> > struct resource *r)
> > {
> > ...
> > /* flags can be get here, without ranges property reqired.
> > * if the reg = <0x0 0xe4 4>, I can get flag of IORESOURCE_MEM,
> > * if the reg = <0x1 0xe4 4>, I can get flag of IORESOURCE_IO,
>
> That is strange, the parent node has #address-cells = <2> so the first two numbers should be part
> of the address and not influence the flags. Can you add some debugging in of_get_address() and
> try to figure out what bus is used in *flags = bus->get_flags(prop) ?
>
>
This is the standard ISA binding. The first cell is the address space
(IO or MEM), the second cell is the address within that space. This
is similar to how PCI works.
Arnd
next prev parent reply other threads:[~2016-01-12 22:53 UTC|newest]
Thread overview: 111+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-29 13:33 [PATCH v1 0/3] ARM64 LPC: legacy ISA I/O support Rongrong Zou
2015-12-29 13:33 ` [PATCH v1 1/3] ARM64 LPC: indirect ISA PORT IO introduced Rongrong Zou
2015-12-29 13:47 ` Arnd Bergmann
2015-12-29 14:26 ` Rongrong Zou
2015-12-29 14:35 ` Arnd Bergmann
2015-12-30 1:24 ` Rongrong Zou
2015-12-30 8:59 ` Arnd Bergmann
2015-12-30 9:28 ` Rongrong Zou
2015-12-30 9:42 ` Arnd Bergmann
2016-01-04 10:11 ` Will Deacon
2016-01-04 10:27 ` Rongrong Zou
2016-01-04 10:27 ` Rongrong Zou
2015-12-29 13:33 ` [PATCH v1 2/3] ARM64 LPC: LPC driver implementation Rongrong Zou
2015-12-29 13:51 ` Arnd Bergmann
2015-12-29 14:03 ` Rongrong Zou
2015-12-29 14:11 ` Arnd Bergmann
2015-12-29 13:33 ` [PATCH v1 3/3] ARM64 LPC: update binding doc Rongrong Zou
2015-12-29 13:52 ` Arnd Bergmann
2015-12-30 9:06 ` Arnd Bergmann
2015-12-31 14:12 ` Rongrong Zou
2015-12-31 14:12 ` Rongrong Zou
2015-12-31 14:40 ` Arnd Bergmann
[not found] ` <CABTftiT1+AmrNjiAie-T6on-oWA4Zz73+Tj2pQrixMT3o475uw@mail.gmail.com>
2016-01-03 12:24 ` Rongrong Zou
2016-01-03 12:24 ` Rongrong Zou
2016-01-03 12:24 ` Rongrong Zou
2016-01-04 11:13 ` Arnd Bergmann
2016-01-04 11:13 ` Arnd Bergmann
2016-01-04 11:13 ` Arnd Bergmann
2016-01-04 16:04 ` Rongrong Zou
2016-01-04 16:04 ` Rongrong Zou
2016-01-04 16:04 ` Rongrong Zou
2016-01-04 16:34 ` Arnd Bergmann
2016-01-04 16:34 ` Arnd Bergmann
2016-01-04 16:34 ` Arnd Bergmann
2016-01-05 11:59 ` Rongrong Zou
2016-01-05 11:59 ` Rongrong Zou
2016-01-05 11:59 ` Rongrong Zou
2016-01-05 12:19 ` Arnd Bergmann
2016-01-05 12:19 ` Arnd Bergmann
2016-01-06 13:36 ` Rongrong Zou
2016-01-06 13:36 ` Rongrong Zou
2016-01-06 13:36 ` Rongrong Zou
2016-01-07 3:37 ` Rongrong Zou
2016-01-07 3:37 ` Rongrong Zou
2016-01-07 3:37 ` Rongrong Zou
2016-01-10 9:29 ` Rolland Chau
2016-01-10 9:29 ` Rolland Chau
2016-01-10 13:38 ` Rongrong Zou
2016-01-10 13:38 ` Rongrong Zou
2016-01-10 13:38 ` Rongrong Zou
2016-01-11 16:14 ` liviu.dudau
2016-01-11 16:14 ` liviu.dudau at arm.com
2016-01-11 16:14 ` liviu.dudau-5wv7dgnIgG8
2016-01-12 2:39 ` Rongrong Zou
2016-01-12 2:39 ` Rongrong Zou
2016-01-12 9:07 ` liviu.dudau
2016-01-12 9:07 ` liviu.dudau at arm.com
2016-01-12 9:25 ` Rongrong Zou
2016-01-12 9:25 ` Rongrong Zou
2016-01-12 9:25 ` Rongrong Zou
2016-01-12 10:14 ` liviu.dudau
2016-01-12 10:14 ` liviu.dudau at arm.com
2016-01-12 11:05 ` Rongrong Zou
2016-01-12 11:05 ` Rongrong Zou
2016-01-12 11:05 ` Rongrong Zou
2016-01-12 11:27 ` liviu.dudau
2016-01-12 11:27 ` liviu.dudau at arm.com
2016-01-12 11:27 ` liviu.dudau-5wv7dgnIgG8
2016-01-12 11:56 ` Rongrong Zou
2016-01-12 11:56 ` Rongrong Zou
2016-01-12 11:56 ` Rongrong Zou
2016-01-12 15:13 ` liviu.dudau
2016-01-12 15:13 ` liviu.dudau at arm.com
2016-01-12 15:13 ` liviu.dudau-5wv7dgnIgG8
2016-01-12 22:52 ` Arnd Bergmann [this message]
2016-01-12 22:52 ` Arnd Bergmann
2016-01-13 5:53 ` Benjamin Herrenschmidt
2016-01-13 5:53 ` Benjamin Herrenschmidt
2016-01-13 5:53 ` Benjamin Herrenschmidt
2016-01-13 6:34 ` Rongrong Zou
2016-01-13 6:34 ` Rongrong Zou
2016-01-13 6:34 ` Rongrong Zou
2016-01-13 9:26 ` Arnd Bergmann
2016-01-13 9:26 ` Arnd Bergmann
2016-01-13 9:26 ` Arnd Bergmann
2016-01-13 10:10 ` liviu.dudau
2016-01-13 10:10 ` liviu.dudau at arm.com
2016-01-13 10:10 ` liviu.dudau-5wv7dgnIgG8
2016-01-13 10:18 ` Arnd Bergmann
2016-01-13 10:18 ` Arnd Bergmann
2016-01-13 10:32 ` liviu.dudau
2016-01-13 10:32 ` liviu.dudau at arm.com
2016-01-13 10:32 ` liviu.dudau-5wv7dgnIgG8
2016-01-12 22:54 ` Arnd Bergmann
2016-01-12 22:54 ` Arnd Bergmann
2016-01-13 10:09 ` liviu.dudau
2016-01-13 10:09 ` liviu.dudau at arm.com
2016-01-13 10:09 ` liviu.dudau-5wv7dgnIgG8
2016-01-13 10:29 ` Arnd Bergmann
2016-01-13 10:29 ` Arnd Bergmann
2016-01-13 10:29 ` Arnd Bergmann
2016-01-13 11:06 ` Rongrong Zou
2016-01-13 11:06 ` Rongrong Zou
2016-01-13 11:25 ` liviu.dudau
2016-01-13 11:25 ` liviu.dudau at arm.com
2016-01-13 23:29 ` Benjamin Herrenschmidt
2016-01-14 2:03 ` Rongrong Zou
2016-01-14 3:39 ` Benjamin Herrenschmidt
2016-01-14 4:42 ` Rongrong Zou
2016-01-14 11:25 ` Benjamin Herrenschmidt
2016-01-14 13:11 ` Rongrong Zou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4731036.9QlepWb5cE@wuerfel \
--to=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liviu.dudau@arm.com \
--cc=minyard@acm.org \
--cc=will.deacon@arm.com \
--cc=zourongrong@gmail.com \
--cc=zourongrong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.