All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Philipp Zabel <p.zabel@pengutronix.de>,
	linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, "Roc He" <hepeng@zidoo.tv>,
	蒋丽琴 <jiang.liqin@geniatech.com>
Subject: Re: [PATCH 3/5] reset: Add Realtek RTD1295 driver
Date: Wed, 16 Aug 2017 14:09:21 +0200	[thread overview]
Message-ID: <47359100-edf7-5aa4-a3ee-1250c8a84c5e@suse.de> (raw)
In-Reply-To: <1502876699.7596.3.camel@pengutronix.de>

Hi Philipp,

Am 16.08.2017 um 11:44 schrieb Philipp Zabel:
> On Wed, 2017-08-16 at 02:38 +0200, Andreas Färber wrote:
>> Add a per-register reset controller driver. This deals with the fact
>> that not all registers are adjoined.
> 
> the way you handle the non-contiguous reset registers, this looks like
> a candidate to join the recently discussed reset-simple driver [1].
> Could you check if that would fit?

Thanks, I appreciate the idea, and it looks like you already have the
active-low logic in place.

Are you okay with keeping the first three as separate nodes, or would
you rather want one node to cover the first three registers, plus two
separate ones for the non-contiguous cases? Or is the simple driver
supposed to cover gaps, too? Then we could go with just two nodes. (I
found it weird to have reset and then reset4, so I went with separate
ones as seen downstream.)

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

WARNING: multiple messages have this Message-ID (diff)
From: afaerber@suse.de (Andreas Färber)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] reset: Add Realtek RTD1295 driver
Date: Wed, 16 Aug 2017 14:09:21 +0200	[thread overview]
Message-ID: <47359100-edf7-5aa4-a3ee-1250c8a84c5e@suse.de> (raw)
In-Reply-To: <1502876699.7596.3.camel@pengutronix.de>

Hi Philipp,

Am 16.08.2017 um 11:44 schrieb Philipp Zabel:
> On Wed, 2017-08-16 at 02:38 +0200, Andreas F?rber wrote:
>> Add a per-register reset controller driver. This deals with the fact
>> that not all registers are adjoined.
> 
> the way you handle the non-contiguous reset registers, this looks like
> a candidate to join the recently discussed reset-simple driver [1].
> Could you check if that would fit?

Thanks, I appreciate the idea, and it looks like you already have the
active-low logic in place.

Are you okay with keeping the first three as separate nodes, or would
you rather want one node to cover the first three registers, plus two
separate ones for the non-contiguous cases? Or is the simple driver
supposed to cover gaps, too? Then we could go with just two nodes. (I
found it weird to have reset and then reset4, so I went with separate
ones as seen downstream.)

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)

  reply	other threads:[~2017-08-16 12:09 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-16  0:38 [PATCH 0/5] arm64: Realtek RTD1295 reset controllers Andreas Färber
2017-08-16  0:38 ` Andreas Färber
2017-08-16  0:38 ` Andreas Färber
2017-08-16  0:38 ` [PATCH 1/5] dt-bindings: reset: Add Realtek RTD1295 Andreas Färber
2017-08-16  0:38   ` Andreas Färber
2017-08-16  0:38   ` Andreas Färber
2017-08-17 21:44   ` Rob Herring
2017-08-17 21:44     ` Rob Herring
2017-08-16  0:38 ` [PATCH 2/5] arm64: dts: realtek: Add RTD1295 reset controller nodes Andreas Färber
2017-08-16  0:38   ` Andreas Färber
2017-08-16  0:38 ` [PATCH 3/5] reset: Add Realtek RTD1295 driver Andreas Färber
2017-08-16  0:38   ` Andreas Färber
2017-08-16  9:44   ` Philipp Zabel
2017-08-16  9:44     ` Philipp Zabel
2017-08-16 12:09     ` Andreas Färber [this message]
2017-08-16 12:09       ` Andreas Färber
2017-08-16 15:33       ` Philipp Zabel
2017-08-16 15:33         ` Philipp Zabel
2017-08-16  0:38 ` [PATCH 4/5] arm64: dts: realtek: Add RTD1295 UART resets Andreas Färber
2017-08-16  0:38   ` Andreas Färber
2017-08-16  0:38 ` [PATCH 5/5] arm64: dts: realtek: Adopt RTD1295 reset constants Andreas Färber
2017-08-16  0:38   ` Andreas Färber
2017-08-16  0:38   ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47359100-edf7-5aa4-a3ee-1250c8a84c5e@suse.de \
    --to=afaerber@suse.de \
    --cc=hepeng@zidoo.tv \
    --cc=jiang.liqin@geniatech.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.