From: Nicolas Ferre <nicolas.ferre@microchip.com> To: Sergey Shtylyov <s.shtylyov@omp.ru>, <linux-usb@vger.kernel.org>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, Alan Stern <stern@rowland.harvard.edu> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>, Ludovic Desroches <ludovic.desroches@microchip.com>, <linux-arm-kernel@lists.infradead.org>, Cristian Birsan <Cristian.Birsan@microchip.com>, Claudiu Beznea <Claudiu.Beznea@microchip.com> Subject: Re: [PATCH v3 2/6] usb: host: ehci-atmel: fix deferred probing Date: Fri, 15 Apr 2022 16:55:33 +0200 [thread overview] Message-ID: <4749e012-924e-0b40-4b7b-5ecb54856657@microchip.com> (raw) In-Reply-To: <20211210204634.8182-3-s.shtylyov@omp.ru> On 10/12/2021 at 21:46, Sergey Shtylyov wrote: > The driver overrides the error codes and IRQ0 returned by platform_get_irq() > to -ENODEV, so if it returns -EPROBE_DEFER, the driver will fail the probe > permanently instead of the deferred probing. Switch to propagating the error > codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now > can safely ignore it... > > Fixes: 9ec36cafe43b ("of/irq: do irq resolution in platform_get_irq") > Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> > Acked-by: Alan Stern <stern@rowland.harvard.edu> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> Thanks, best regards, Nicolas > --- > Changes in version 3: > - corrected the "Fixes:" tag; > - added Alan's ACK. > > Changes in version 2: > - removed the check for IRQ0, updated the patch description accordingly. > > drivers/usb/host/ehci-atmel.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/host/ehci-atmel.c b/drivers/usb/host/ehci-atmel.c > index 05d41fd65f25..bc3fdb588e6b 100644 > --- a/drivers/usb/host/ehci-atmel.c > +++ b/drivers/usb/host/ehci-atmel.c > @@ -104,8 +104,8 @@ static int ehci_atmel_drv_probe(struct platform_device *pdev) > pr_debug("Initializing Atmel-SoC USB Host Controller\n"); > > irq = platform_get_irq(pdev, 0); > - if (irq <= 0) { > - retval = -ENODEV; > + if (irq < 0) { > + retval = irq; > goto fail_create_hcd; > } > > -- > 2.26.3 > -- Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@microchip.com> To: Sergey Shtylyov <s.shtylyov@omp.ru>, <linux-usb@vger.kernel.org>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, Alan Stern <stern@rowland.harvard.edu> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>, Ludovic Desroches <ludovic.desroches@microchip.com>, <linux-arm-kernel@lists.infradead.org>, Cristian Birsan <Cristian.Birsan@microchip.com>, Claudiu Beznea <Claudiu.Beznea@microchip.com> Subject: Re: [PATCH v3 2/6] usb: host: ehci-atmel: fix deferred probing Date: Fri, 15 Apr 2022 16:55:33 +0200 [thread overview] Message-ID: <4749e012-924e-0b40-4b7b-5ecb54856657@microchip.com> (raw) In-Reply-To: <20211210204634.8182-3-s.shtylyov@omp.ru> On 10/12/2021 at 21:46, Sergey Shtylyov wrote: > The driver overrides the error codes and IRQ0 returned by platform_get_irq() > to -ENODEV, so if it returns -EPROBE_DEFER, the driver will fail the probe > permanently instead of the deferred probing. Switch to propagating the error > codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now > can safely ignore it... > > Fixes: 9ec36cafe43b ("of/irq: do irq resolution in platform_get_irq") > Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> > Acked-by: Alan Stern <stern@rowland.harvard.edu> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> Thanks, best regards, Nicolas > --- > Changes in version 3: > - corrected the "Fixes:" tag; > - added Alan's ACK. > > Changes in version 2: > - removed the check for IRQ0, updated the patch description accordingly. > > drivers/usb/host/ehci-atmel.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/host/ehci-atmel.c b/drivers/usb/host/ehci-atmel.c > index 05d41fd65f25..bc3fdb588e6b 100644 > --- a/drivers/usb/host/ehci-atmel.c > +++ b/drivers/usb/host/ehci-atmel.c > @@ -104,8 +104,8 @@ static int ehci_atmel_drv_probe(struct platform_device *pdev) > pr_debug("Initializing Atmel-SoC USB Host Controller\n"); > > irq = platform_get_irq(pdev, 0); > - if (irq <= 0) { > - retval = -ENODEV; > + if (irq < 0) { > + retval = irq; > goto fail_create_hcd; > } > > -- > 2.26.3 > -- Nicolas Ferre _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-15 14:55 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-10 20:46 [PATCH v3 0/6] Fix deferred probing in the USB host/gadget drivers Sergey Shtylyov 2021-12-10 20:46 ` [PATCH v3 1/6] usb: gadget: udc: gr: fix deferred probing Sergey Shtylyov 2021-12-13 14:11 ` Greg Kroah-Hartman 2021-12-13 15:21 ` Sergey Shtylyov 2021-12-10 20:46 ` [PATCH v3 2/6] usb: host: ehci-atmel: " Sergey Shtylyov 2021-12-10 20:46 ` Sergey Shtylyov 2022-04-15 14:55 ` Nicolas Ferre [this message] 2022-04-15 14:55 ` Nicolas Ferre 2021-12-10 20:46 ` [PATCH v3 3/6] usb: host: ehci-orion: " Sergey Shtylyov 2021-12-10 20:46 ` [PATCH v3 4/6] usb: host: ohci-da8xx: " Sergey Shtylyov 2021-12-10 20:46 ` [PATCH v3 5/6] usb: host: ohci-nxp: " Sergey Shtylyov 2021-12-10 20:46 ` [PATCH v3 6/6] usb: musb: core: " Sergey Shtylyov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4749e012-924e-0b40-4b7b-5ecb54856657@microchip.com \ --to=nicolas.ferre@microchip.com \ --cc=Claudiu.Beznea@microchip.com \ --cc=Cristian.Birsan@microchip.com \ --cc=alexandre.belloni@bootlin.com \ --cc=gregkh@linuxfoundation.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-usb@vger.kernel.org \ --cc=ludovic.desroches@microchip.com \ --cc=s.shtylyov@omp.ru \ --cc=stern@rowland.harvard.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.