* [PATCH] libdevmapper: enable native support.
@ 2017-05-03 10:59 Ismo Puustinen
2017-05-03 11:26 ` Peter Kjellerstedt
0 siblings, 1 reply; 3+ messages in thread
From: Ismo Puustinen @ 2017-05-03 10:59 UTC (permalink / raw)
To: openembedded-devel
Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com>
---
meta-oe/recipes-support/lvm2/libdevmapper_2.02.166.bb | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/meta-oe/recipes-support/lvm2/libdevmapper_2.02.166.bb b/meta-oe/recipes-support/lvm2/libdevmapper_2.02.166.bb
index 462e8fb..37c0a97 100644
--- a/meta-oe/recipes-support/lvm2/libdevmapper_2.02.166.bb
+++ b/meta-oe/recipes-support/lvm2/libdevmapper_2.02.166.bb
@@ -28,4 +28,6 @@ do_install_append() {
rm -rf ${D}${datadir}
}
-RRECOMMENDS_${PN} += "lvm2-udevrules"
+RRECOMMENDS_${PN}_class-target += "lvm2-udevrules"
+
+BBCLASSEXTEND = "native nativesdk"
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] libdevmapper: enable native support.
2017-05-03 10:59 [PATCH] libdevmapper: enable native support Ismo Puustinen
@ 2017-05-03 11:26 ` Peter Kjellerstedt
2017-05-03 12:26 ` Puustinen, Ismo
0 siblings, 1 reply; 3+ messages in thread
From: Peter Kjellerstedt @ 2017-05-03 11:26 UTC (permalink / raw)
To: Ismo Puustinen, openembedded-devel
> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org
> [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of
> Ismo Puustinen
> Sent: den 3 maj 2017 13:00
> To: openembedded-devel@lists.openembedded.org
> Subject: [oe] [PATCH] libdevmapper: enable native support.
>
> Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com>
> ---
> meta-oe/recipes-support/lvm2/libdevmapper_2.02.166.bb | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-support/lvm2/libdevmapper_2.02.166.bb
> b/meta-oe/recipes-support/lvm2/libdevmapper_2.02.166.bb
> index 462e8fb..37c0a97 100644
> --- a/meta-oe/recipes-support/lvm2/libdevmapper_2.02.166.bb
> +++ b/meta-oe/recipes-support/lvm2/libdevmapper_2.02.166.bb
> @@ -28,4 +28,6 @@ do_install_append() {
> rm -rf ${D}${datadir}
> }
>
> -RRECOMMENDS_${PN} += "lvm2-udevrules"
> +RRECOMMENDS_${PN}_class-target += "lvm2-udevrules"
That should be either:
RRECOMMENDS_${PN}_append_class-target = " lvm2-udevrules"
or:
RRECOMMENDS_${PN}_class-target = "lvm2-udevrules"
Using FOO_class-target += "..." gives the impression that it adds to
FOO, but it does not, it adds to FOO_class-target which then completely
replaces FOO for target builds. E.g., with the following two definitions:
FOO = "foo"
FOO_class-target += "bar"
then ${FOO} will be "bar" for target builds and "foo" for all other
builds. It will never be "foo bar".
> +BBCLASSEXTEND = "native nativesdk"
> --
> 2.9.3
//Peter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libdevmapper: enable native support.
2017-05-03 11:26 ` Peter Kjellerstedt
@ 2017-05-03 12:26 ` Puustinen, Ismo
0 siblings, 0 replies; 3+ messages in thread
From: Puustinen, Ismo @ 2017-05-03 12:26 UTC (permalink / raw)
To: peter.kjellerstedt, openembedded-devel
On Wed, 2017-05-03 at 11:26 +0000, Peter Kjellerstedt wrote:
> > -----Original Message-----
> > From: openembedded-devel-bounces@lists.openembedded.org
> > [mailto:openembedded-devel-bounces@lists.openembedded.org] On
> > Behalf Of
> > Ismo Puustinen
> > Sent: den 3 maj 2017 13:00
> > To: openembedded-devel@lists.openembedded.org
> > Subject: [oe] [PATCH] libdevmapper: enable native support.
> >
> > Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com>
> > ---
> > meta-oe/recipes-support/lvm2/libdevmapper_2.02.166.bb | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta-oe/recipes-support/lvm2/libdevmapper_2.02.166.bb
> > b/meta-oe/recipes-support/lvm2/libdevmapper_2.02.166.bb
> > index 462e8fb..37c0a97 100644
> > --- a/meta-oe/recipes-support/lvm2/libdevmapper_2.02.166.bb
> > +++ b/meta-oe/recipes-support/lvm2/libdevmapper_2.02.166.bb
> > @@ -28,4 +28,6 @@ do_install_append() {
> > rm -rf ${D}${datadir}
> > }
> >
> > -RRECOMMENDS_${PN} += "lvm2-udevrules"
> > +RRECOMMENDS_${PN}_class-target += "lvm2-udevrules"
>
> That should be either:
>
> RRECOMMENDS_${PN}_append_class-target = " lvm2-udevrules"
>
> or:
>
> RRECOMMENDS_${PN}_class-target = "lvm2-udevrules"
>
> Using FOO_class-target += "..." gives the impression that it adds to
> FOO, but it does not, it adds to FOO_class-target which then
> completely
> replaces FOO for target builds. E.g., with the following two
> definitions:
>
> FOO = "foo"
> FOO_class-target += "bar"
>
> then ${FOO} will be "bar" for target builds and "foo" for all other
> builds. It will never be "foo bar".
>
> > +BBCLASSEXTEND = "native nativesdk"
> > --
> > 2.9.3
>
> //Peter
Good point. I'll prepare a second version of the patch. I found it bit
surprising that RRECOMMENDS is even a thing for native recipes...
Ismo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-03 12:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-03 10:59 [PATCH] libdevmapper: enable native support Ismo Puustinen
2017-05-03 11:26 ` Peter Kjellerstedt
2017-05-03 12:26 ` Puustinen, Ismo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.