* [PATCH 1/4] [media] mmp: add register definition for marvell ccic
@ 2012-09-28 13:47 Albert Wang
2012-09-29 17:25 ` Guennadi Liakhovetski
0 siblings, 1 reply; 3+ messages in thread
From: Albert Wang @ 2012-09-28 13:47 UTC (permalink / raw)
To: corbet, g.liakhovetski; +Cc: linux-media, Libin Yang, Albert Wang
From: Libin Yang <lbyang@marvell.com>
This patch adds the definition of CCIC1/2 Clock Reset register address
Signed-off-by: Albert Wang <twang13@marvell.com>
Signed-off-by: Libin Yang <lbyang@marvell.com>
---
arch/arm/mach-mmp/include/mach/regs-apmu.h | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-mmp/include/mach/regs-apmu.h b/arch/arm/mach-mmp/include/mach/regs-apmu.h
index 7af8deb..f2cf231 100755
--- a/arch/arm/mach-mmp/include/mach/regs-apmu.h
+++ b/arch/arm/mach-mmp/include/mach/regs-apmu.h
@@ -16,7 +16,8 @@
/* Clock Reset Control */
#define APMU_IRE APMU_REG(0x048)
#define APMU_LCD APMU_REG(0x04c)
-#define APMU_CCIC APMU_REG(0x050)
+#define APMU_CCIC_RST APMU_REG(0x050)
+#define APMU_CCIC2_RST APMU_REG(0x0f4)
#define APMU_SDH0 APMU_REG(0x054)
#define APMU_SDH1 APMU_REG(0x058)
#define APMU_USB APMU_REG(0x05c)
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/4] [media] mmp: add register definition for marvell ccic
2012-09-28 13:47 [PATCH 1/4] [media] mmp: add register definition for marvell ccic Albert Wang
@ 2012-09-29 17:25 ` Guennadi Liakhovetski
2012-10-05 13:14 ` Albert Wang
0 siblings, 1 reply; 3+ messages in thread
From: Guennadi Liakhovetski @ 2012-09-29 17:25 UTC (permalink / raw)
To: Albert Wang; +Cc: corbet, linux-media, Libin Yang
On Fri, 28 Sep 2012, Albert Wang wrote:
> From: Libin Yang <lbyang@marvell.com>
>
> This patch adds the definition of CCIC1/2 Clock Reset register address
>
> Signed-off-by: Albert Wang <twang13@marvell.com>
> Signed-off-by: Libin Yang <lbyang@marvell.com>
> ---
> arch/arm/mach-mmp/include/mach/regs-apmu.h | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-mmp/include/mach/regs-apmu.h b/arch/arm/mach-mmp/include/mach/regs-apmu.h
> index 7af8deb..f2cf231 100755
> --- a/arch/arm/mach-mmp/include/mach/regs-apmu.h
> +++ b/arch/arm/mach-mmp/include/mach/regs-apmu.h
> @@ -16,7 +16,8 @@
> /* Clock Reset Control */
> #define APMU_IRE APMU_REG(0x048)
> #define APMU_LCD APMU_REG(0x04c)
> -#define APMU_CCIC APMU_REG(0x050)
> +#define APMU_CCIC_RST APMU_REG(0x050)
> +#define APMU_CCIC2_RST APMU_REG(0x0f4)
Assuming APMU_CCIC hasn't been used until now, changing its name is ok,
but I think, registers in this list are ordered by their addresses, so,
your addition should go between
#define APMU_SDH3 APMU_REG(0x0ec)
#define APMU_ETH APMU_REG(0x0fc)
Thanks
Guennadi
> #define APMU_SDH0 APMU_REG(0x054)
> #define APMU_SDH1 APMU_REG(0x058)
> #define APMU_USB APMU_REG(0x05c)
> --
> 1.7.0.4
>
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH 1/4] [media] mmp: add register definition for marvell ccic
2012-09-29 17:25 ` Guennadi Liakhovetski
@ 2012-10-05 13:14 ` Albert Wang
0 siblings, 0 replies; 3+ messages in thread
From: Albert Wang @ 2012-10-05 13:14 UTC (permalink / raw)
To: Guennadi Liakhovetski; +Cc: corbet, linux-media, Libin Yang
>From: Guennadi Liakhovetski [mailto:g.liakhovetski@gmx.de]
>Sent: Sunday, 30 September, 2012 01:26
>To: Albert Wang
>Cc: corbet@lwn.net; linux-media@vger.kernel.org; Libin Yang
>Subject: Re: [PATCH 1/4] [media] mmp: add register definition for marvell ccic
>
>On Fri, 28 Sep 2012, Albert Wang wrote:
>
>> From: Libin Yang <lbyang@marvell.com>
>>
>> This patch adds the definition of CCIC1/2 Clock Reset register address
>>
>> Signed-off-by: Albert Wang <twang13@marvell.com>
>> Signed-off-by: Libin Yang <lbyang@marvell.com>
>> ---
>> arch/arm/mach-mmp/include/mach/regs-apmu.h | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-mmp/include/mach/regs-apmu.h
>> b/arch/arm/mach-mmp/include/mach/regs-apmu.h
>> index 7af8deb..f2cf231 100755
>> --- a/arch/arm/mach-mmp/include/mach/regs-apmu.h
>> +++ b/arch/arm/mach-mmp/include/mach/regs-apmu.h
>> @@ -16,7 +16,8 @@
>> /* Clock Reset Control */
>> #define APMU_IRE APMU_REG(0x048)
>> #define APMU_LCD APMU_REG(0x04c)
>> -#define APMU_CCIC APMU_REG(0x050)
>> +#define APMU_CCIC_RST APMU_REG(0x050)
>> +#define APMU_CCIC2_RST APMU_REG(0x0f4)
>
>Assuming APMU_CCIC hasn't been used until now, changing its name is ok, but I think,
>registers in this list are ordered by their addresses, so, your addition should go between
>
>#define APMU_SDH3 APMU_REG(0x0ec)
>#define APMU_ETH APMU_REG(0x0fc)
>
Sorry for late response.
Sure, you are right, we will change it in Version 2
>Thanks
>Guennadi
>
>> #define APMU_SDH0 APMU_REG(0x054)
>> #define APMU_SDH1 APMU_REG(0x058)
>> #define APMU_USB APMU_REG(0x05c)
>> --
>> 1.7.0.4
>>
>
>---
>Guennadi Liakhovetski, Ph.D.
>Freelance Open-Source Software Developer
>http://www.open-technology.de/
Thanks
Albert Wang
86-21-61092656
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-05 13:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-28 13:47 [PATCH 1/4] [media] mmp: add register definition for marvell ccic Albert Wang
2012-09-29 17:25 ` Guennadi Liakhovetski
2012-10-05 13:14 ` Albert Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.