* [PATCH 0/4] MIPS: generic: Fixes for Ranchu platform
@ 2018-02-02 22:14 James Hogan
2018-02-02 22:14 ` [PATCH 1/4] MIPS: generic: Fix machine compatible matching James Hogan
` (3 more replies)
0 siblings, 4 replies; 11+ messages in thread
From: James Hogan @ 2018-02-02 22:14 UTC (permalink / raw)
To: Ralf Baechle, linux-mips
Cc: Aleksandar Markovic, Goran Ferenc, Miodrag Dinic, James Hogan,
Paul Burton, Matt Redfearn
These are a few fixes for the Ranchu platform which is now applied to my
4.16 branch, which should fix boot on non-Ranchu "generic" platforms.
Fixes: eed0eabd12ef ("MIPS: generic: Introduce generic DT-based board support")
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Miodrag Dinic <miodrag.dinic@mips.com>
Cc: Goran Ferenc <goran.ferenc@mips.com>
Cc: Aleksandar Markovic <aleksandar.markovic@mips.com>
Cc: Paul Burton <paul.burton@mips.com>
Cc: Matt Redfearn <matt.redfearn@mips.com>
Cc: linux-mips@linux-mips.org
James Hogan (4):
MIPS: generic: Fix machine compatible matching
MIPS: generic: Fix ranchu_of_match[] termination
MIPS: generic: Fix Makefile alignment
MIPS: generic: Don't claim PC parport/serio
arch/mips/Kconfig | 4 ++--
arch/mips/generic/Makefile | 2 +-
arch/mips/generic/board-ranchu.c | 1 +
arch/mips/include/asm/machine.h | 2 +-
4 files changed, 5 insertions(+), 4 deletions(-)
base-commit: 6045f241b48f07b2fb80905bf49671f457a8c037
--
git-series 0.9.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 1/4] MIPS: generic: Fix machine compatible matching
2018-02-02 22:14 [PATCH 0/4] MIPS: generic: Fixes for Ranchu platform James Hogan
@ 2018-02-02 22:14 ` James Hogan
2018-02-07 16:27 ` Aleksandar Markovic
2018-02-02 22:14 ` [PATCH 2/4] MIPS: generic: Fix ranchu_of_match[] termination James Hogan
` (2 subsequent siblings)
3 siblings, 1 reply; 11+ messages in thread
From: James Hogan @ 2018-02-02 22:14 UTC (permalink / raw)
To: Ralf Baechle, linux-mips
Cc: Aleksandar Markovic, Goran Ferenc, Miodrag Dinic, James Hogan
We now have a platform (Ranchu) in the "generic" platform which matches
based on the FDT compatible string using mips_machine_is_compatible(),
however that function doesn't stop at a blank struct
of_device_id::compatible as that is an array in the struct, not a
pointer to a string.
Fix the loop completion to check the first byte of the compatible array
rather than the address of the compatible array in the struct.
Fixes: eed0eabd12ef ("MIPS: generic: Introduce generic DT-based board support")
Signed-off-by: James Hogan <jhogan@kernel.org>
Reviewed-by: Paul Burton <paul.burton@mips.com>
Reviewed-by: Matt Redfearn <matt.redfearn@mips.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
---
arch/mips/include/asm/machine.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/include/asm/machine.h b/arch/mips/include/asm/machine.h
index e0d9b373d415..f83879dadd1e 100644
--- a/arch/mips/include/asm/machine.h
+++ b/arch/mips/include/asm/machine.h
@@ -52,7 +52,7 @@ mips_machine_is_compatible(const struct mips_machine *mach, const void *fdt)
if (!mach->matches)
return NULL;
- for (match = mach->matches; match->compatible; match++) {
+ for (match = mach->matches; match->compatible[0]; match++) {
if (fdt_node_check_compatible(fdt, 0, match->compatible) == 0)
return match;
}
--
git-series 0.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 2/4] MIPS: generic: Fix ranchu_of_match[] termination
2018-02-02 22:14 [PATCH 0/4] MIPS: generic: Fixes for Ranchu platform James Hogan
2018-02-02 22:14 ` [PATCH 1/4] MIPS: generic: Fix machine compatible matching James Hogan
@ 2018-02-02 22:14 ` James Hogan
2018-02-07 16:27 ` Aleksandar Markovic
2018-02-02 22:14 ` [PATCH 3/4] MIPS: generic: Fix Makefile alignment James Hogan
2018-02-02 22:14 ` [PATCH 4/4] MIPS: generic: Don't claim PC parport/serio James Hogan
3 siblings, 1 reply; 11+ messages in thread
From: James Hogan @ 2018-02-02 22:14 UTC (permalink / raw)
To: Ralf Baechle, linux-mips
Cc: Aleksandar Markovic, Goran Ferenc, Miodrag Dinic, James Hogan
ranchu_of_match[] has no terminating element to end the search for a
matching compatible string when the first and only element does not
match, so add one now.
Fixes: f2d0b0d5c171 ("MIPS: ranchu: Add Ranchu as a new generic-based board")
Signed-off-by: James Hogan <jhogan@kernel.org>
Reviewed-by: Paul Burton <paul.burton@mips.com>
Reviewed-by: Matt Redfearn <matt.redfearn@mips.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Miodrag Dinic <miodrag.dinic@mips.com>
Cc: Goran Ferenc <goran.ferenc@mips.com>
Cc: Aleksandar Markovic <aleksandar.markovic@mips.com>
Cc: linux-mips@linux-mips.org
---
arch/mips/generic/board-ranchu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/mips/generic/board-ranchu.c b/arch/mips/generic/board-ranchu.c
index ea451b89bb53..59a8c18fa2cc 100644
--- a/arch/mips/generic/board-ranchu.c
+++ b/arch/mips/generic/board-ranchu.c
@@ -84,6 +84,7 @@ static const struct of_device_id ranchu_of_match[] __initconst = {
{
.compatible = "mti,ranchu",
},
+ {}
};
MIPS_MACHINE(ranchu) = {
--
git-series 0.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 3/4] MIPS: generic: Fix Makefile alignment
2018-02-02 22:14 [PATCH 0/4] MIPS: generic: Fixes for Ranchu platform James Hogan
2018-02-02 22:14 ` [PATCH 1/4] MIPS: generic: Fix machine compatible matching James Hogan
2018-02-02 22:14 ` [PATCH 2/4] MIPS: generic: Fix ranchu_of_match[] termination James Hogan
@ 2018-02-02 22:14 ` James Hogan
2018-02-07 16:27 ` Aleksandar Markovic
2018-02-02 22:14 ` [PATCH 4/4] MIPS: generic: Don't claim PC parport/serio James Hogan
3 siblings, 1 reply; 11+ messages in thread
From: James Hogan @ 2018-02-02 22:14 UTC (permalink / raw)
To: Ralf Baechle, linux-mips
Cc: Aleksandar Markovic, Goran Ferenc, Miodrag Dinic, James Hogan
Fix whitespace of generic platform Makefile so that obj-y values align.
Fixes: f2d0b0d5c171 ("MIPS: ranchu: Add Ranchu as a new generic-based board")
Signed-off-by: James Hogan <jhogan@kernel.org>
Reviewed-by: Paul Burton <paul.burton@mips.com>
Reviewed-by: Matt Redfearn <matt.redfearn@mips.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Miodrag Dinic <miodrag.dinic@mips.com>
Cc: Goran Ferenc <goran.ferenc@mips.com>
Cc: Aleksandar Markovic <aleksandar.markovic@mips.com>
Cc: linux-mips@linux-mips.org
---
arch/mips/generic/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/generic/Makefile b/arch/mips/generic/Makefile
index 5fb60c86537b..5c31e0c4697d 100644
--- a/arch/mips/generic/Makefile
+++ b/arch/mips/generic/Makefile
@@ -15,4 +15,4 @@ obj-y += proc.o
obj-$(CONFIG_YAMON_DT_SHIM) += yamon-dt.o
obj-$(CONFIG_LEGACY_BOARD_SEAD3) += board-sead3.o
obj-$(CONFIG_KEXEC) += kexec.o
-obj-$(CONFIG_VIRT_BOARD_RANCHU) += board-ranchu.o
+obj-$(CONFIG_VIRT_BOARD_RANCHU) += board-ranchu.o
--
git-series 0.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 4/4] MIPS: generic: Don't claim PC parport/serio
2018-02-02 22:14 [PATCH 0/4] MIPS: generic: Fixes for Ranchu platform James Hogan
` (2 preceding siblings ...)
2018-02-02 22:14 ` [PATCH 3/4] MIPS: generic: Fix Makefile alignment James Hogan
@ 2018-02-02 22:14 ` James Hogan
2018-02-07 16:27 ` Aleksandar Markovic
3 siblings, 1 reply; 11+ messages in thread
From: James Hogan @ 2018-02-02 22:14 UTC (permalink / raw)
To: Ralf Baechle, linux-mips
Cc: Aleksandar Markovic, Goran Ferenc, Miodrag Dinic, James Hogan,
Paul Burton
None of the supported MIPS generic platforms can have the PC parallel
port or PC serial port (and we don't yet have to be concerned with
Malta which does), and enabling the PC serial driver will result in a
panic from i8042_flush during boot. Therefore conditionalise the MIPS
selection of ARCH_MIGHT_HAVE_PC_{PARPORT,SERIO} on !MIPS_GENERIC.
This particularly matters since commit f2d0b0d5c171 ("MIPS: ranchu: Add
Ranchu as a new generic-based board"), which adds a board fragment which
enables INPUT_KEYBOARD. That implicitly enables KEYBOARD_ATKBD which
then selects SERIO_I8042 if ARCH_MIGHT_HAVE_PC_SERIO.
We can always select it from specific platforms later.
Fixes: f2d0b0d5c171 ("MIPS: ranchu: Add Ranchu as a new generic-based board")
Signed-off-by: James Hogan <jhogan@kernel.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Miodrag Dinic <miodrag.dinic@mips.com>
Cc: Goran Ferenc <goran.ferenc@mips.com>
Cc: Aleksandar Markovic <aleksandar.markovic@mips.com>
Cc: Paul Burton <paul.burton@mips.com>
Cc: linux-mips@linux-mips.org
---
Does anybody actually know which MIPS platforms can have these PC
devices?
---
arch/mips/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index f83f51fc2f82..ee30596380fd 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -7,8 +7,8 @@ config MIPS
select ARCH_DISCARD_MEMBLOCK
select ARCH_HAS_ELF_RANDOMIZE
select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST
- select ARCH_MIGHT_HAVE_PC_PARPORT
- select ARCH_MIGHT_HAVE_PC_SERIO
+ select ARCH_MIGHT_HAVE_PC_PARPORT if !MIPS_GENERIC
+ select ARCH_MIGHT_HAVE_PC_SERIO if !MIPS_GENERIC
select ARCH_SUPPORTS_UPROBES
select ARCH_USE_BUILTIN_BSWAP
select ARCH_USE_CMPXCHG_LOCKREF if 64BIT
--
git-series 0.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* RE: [PATCH 1/4] MIPS: generic: Fix machine compatible matching
2018-02-02 22:14 ` [PATCH 1/4] MIPS: generic: Fix machine compatible matching James Hogan
@ 2018-02-07 16:27 ` Aleksandar Markovic
0 siblings, 0 replies; 11+ messages in thread
From: Aleksandar Markovic @ 2018-02-07 16:27 UTC (permalink / raw)
To: James Hogan, Ralf Baechle, linux-mips; +Cc: Goran Ferenc, Miodrag Dinic
>
> ________________________________________
> From: James Hogan [jhogan@kernel.org]
> Sent: Friday, February 2, 2018 11:14 PM
> To: Ralf Baechle; linux-mips@linux-mips.org
> Cc: Aleksandar Markovic; Goran Ferenc; Miodrag Dinic; James Hogan
> Subject: [PATCH 1/4] MIPS: generic: Fix machine compatible matching
>
> We now have a platform (Ranchu) in the "generic" platform which matches
> based on the FDT compatible string using mips_machine_is_compatible(),
> however that function doesn't stop at a blank struct
> of_device_id::compatible as that is an array in the struct, not a
> pointer to a string.
>
> Fix the loop completion to check the first byte of the compatible array
> rather than the address of the compatible array in the struct.
>
> Fixes: eed0eabd12ef ("MIPS: generic: Introduce generic DT-based board support")
> Signed-off-by: James Hogan <jhogan@kernel.org>
> Reviewed-by: Paul Burton <paul.burton@mips.com>
> Reviewed-by: Matt Redfearn <matt.redfearn@mips.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: linux-mips@linux-mips.org
> ---
> arch/mips/include/asm/machine.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Aleksandar Markovic <aleksandar.markovic@mips.com>
Acked-by: Miodrag Dinic <miodrag.dinic@mips.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH 2/4] MIPS: generic: Fix ranchu_of_match[] termination
@ 2018-02-07 16:27 ` Aleksandar Markovic
0 siblings, 0 replies; 11+ messages in thread
From: Aleksandar Markovic @ 2018-02-07 16:27 UTC (permalink / raw)
To: James Hogan, Ralf Baechle, linux-mips; +Cc: Goran Ferenc, Miodrag Dinic
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="us-ascii", Size: 12237 bytes --]
>
> ________________________________________
> From: James Hogan [jhogan@kernel.org]
> Sent: Friday, February 2, 2018 11:14 PM
> To: Ralf Baechle; linux-mips@linux-mips.org
> Cc: Aleksandar Markovic; Goran Ferenc; Miodrag Dinic; James Hogan
> Subject: [PATCH 2/4] MIPS: generic: Fix ranchu_of_match[] termination
>
> ranchu_of_match[] has no terminating element to end the search for a
> matching compatible string when the first and only element does not
> match, so add one now.
>
> Fixes: f2d0b0d5c171 ("MIPS: ranchu: Add Ranchu as a new generic-based board")
> Signed-off-by: James Hogan <jhogan@kernel.org>
> Reviewed-by: Paul Burton <paul.burton@mips.com>
> Reviewed-by: Matt Redfearn <matt.redfearn@mips.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Miodrag Dinic <miodrag.dinic@mips.com>
> Cc: Goran Ferenc <goran.ferenc@mips.com>
> Cc: Aleksandar Markovic <aleksandar.markovic@mips.com>
> Cc: linux-mips@linux-mips.org
> ---
> arch/mips/generic/board-ranchu.c | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Aleksandar Markovic <aleksandar.markovic@mips.com>
Acked-by: Miodrag Dinic <miodrag.dinic@mips.com>
From Aleksandar.Markovic@mips.com Wed Feb 7 17:45:00 2018
Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 07 Feb 2018 17:45:08 +0100 (CET)
Received: from 9pmail.ess.barracuda.com ([64.235.154.210]:57338 "EHLO
9pmail.ess.barracuda.com" rhost-flags-OK-OK-OK-OK)
by eddie.linux-mips.org with ESMTP id S23992692AbeBGQoVTfFKV convert rfc822-to-8bit
(ORCPT <rfc822;linux-mips@linux-mips.org>);
Wed, 7 Feb 2018 17:44:21 +0100
Received: from MIPSMAIL01.mipstec.com (mailrelay.mips.com [12.201.5.28]) by mx1402.ess.rzc.cudaops.com (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NO); Wed, 07 Feb 2018 16:43:35 +0000
Received: from MIPSMAIL01.mipstec.com ([fe80::5c93:1f20:524d:a563]) by
MIPSMAIL01.mipstec.com ([fe80::5c93:1f20:524d:a563%13]) with mapi id
14.03.0361.001; Wed, 7 Feb 2018 08:27:08 -0800
From: Aleksandar Markovic <Aleksandar.Markovic@mips.com>
To: James Hogan <jhogan@kernel.org>,
Ralf Baechle <ralf@linux-mips.org>,
"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>
CC: Goran Ferenc <Goran.Ferenc@mips.com>,
Miodrag Dinic <Miodrag.Dinic@mips.com>
Subject: RE: [PATCH 3/4] MIPS: generic: Fix Makefile alignment
Thread-Topic: [PATCH 3/4] MIPS: generic: Fix Makefile alignment
Thread-Index: AQHTnHNL3+vM+XZkm0iQBtm1ToHHq6OZJp+i
Date: Wed, 7 Feb 2018 16:27:08 +0000
Message-ID: <BD3A5F1946F2E540A31AF2CE969BAEEE2517C999@MIPSMAIL01.mipstec.com>
References: <cover.fcf1b08ac94759a5cd4b4303f350734b68872619.1517609353.git-series.jhogan@kernel.org>,<aca836516478a60b0f3d68251448ec96014a610e.1517609353.git-series.jhogan@kernel.org>
In-Reply-To: <aca836516478a60b0f3d68251448ec96014a610e.1517609353.git-series.jhogan@kernel.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [82.117.201.26]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-BESS-ID: 1518021606-321458-21852-1632-11
X-BESS-VER: 2018.1-r1801291959
X-BESS-Apparent-Source-IP: 12.201.5.28
X-BESS-Outbound-Spam-Score: 1.10
X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.189770
Rule breakdown below
pts rule name description
---- ---------------------- --------------------------------
0.50 BSF_RULE7568M META: Custom Rule 7568M
0.00 BSF_BESS_OUTBOUND META: BESS Outbound
0.60 MARKETING_SUBJECT HEADER: Subject contains popular marketing words
X-BESS-Outbound-Spam-Status: SCORE=1.10 using account:ESS59374 scores of KILL_LEVEL=7.0 tests=BSF_RULE7568M, BSF_BESS_OUTBOUND, MARKETING_SUBJECT
X-BESS-BRTS-Status: 1
Return-Path: <Aleksandar.Markovic@mips.com>
X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0)
X-Orcpt: rfc822;linux-mips@linux-mips.org
Original-Recipient: rfc822;linux-mips@linux-mips.org
X-archive-position: 62458
X-ecartis-version: Ecartis v1.0.0
Sender: linux-mips-bounce@linux-mips.org
Errors-to: linux-mips-bounce@linux-mips.org
X-original-sender: Aleksandar.Markovic@mips.com
Precedence: bulk
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
List-software: Ecartis version 1.0.0
List-Id: linux-mips <linux-mips.eddie.linux-mips.org>
X-List-ID: linux-mips <linux-mips.eddie.linux-mips.org>
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
X-list: linux-mips
>
> ________________________________________
> From: James Hogan [jhogan@kernel.org]
> Sent: Friday, February 2, 2018 11:14 PM
> To: Ralf Baechle; linux-mips@linux-mips.org
> Cc: Aleksandar Markovic; Goran Ferenc; Miodrag Dinic; James Hogan
> Subject: [PATCH 3/4] MIPS: generic: Fix Makefile alignment
>
> Fix whitespace of generic platform Makefile so that obj-y values align.
>
> Fixes: f2d0b0d5c171 ("MIPS: ranchu: Add Ranchu as a new generic-based board")
> Signed-off-by: James Hogan <jhogan@kernel.org>
> Reviewed-by: Paul Burton <paul.burton@mips.com>
> Reviewed-by: Matt Redfearn <matt.redfearn@mips.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Miodrag Dinic <miodrag.dinic@mips.com>
> Cc: Goran Ferenc <goran.ferenc@mips.com>
> Cc: Aleksandar Markovic <aleksandar.markovic@mips.com>
> Cc: linux-mips@linux-mips.org
> ---
> arch/mips/generic/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Aleksandar Markovic <aleksandar.markovic@mips.com>
Acked-by: Miodrag Dinic <miodrag.dinic@mips.com>
From shannon.nelson@oracle.com Wed Feb 7 18:02:37 2018
Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 07 Feb 2018 18:02:44 +0100 (CET)
Received: from userp2120.oracle.com ([156.151.31.85]:52984 "EHLO
userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org
with ESMTP id S23990434AbeBGRCg6aE-V (ORCPT
<rfc822;linux-mips@linux-mips.org>); Wed, 7 Feb 2018 18:02:36 +0100
Received: from pps.filterd (userp2120.oracle.com [127.0.0.1])
by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w17Gq6ZQ085370;
Wed, 7 Feb 2018 17:02:24 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc :
references : from : message-id : date : mime-version : in-reply-to :
content-type : content-transfer-encoding; s=corp-2017-10-26;
bh=t8qkj05xE5jMGyqs1OsOZL7GRtK1W9ho20c5JJygHrY=;
b=RWv2w5fV1XRN1aZrMYT/5yUTkcEmnqeHCtBwrBfLJThBqxe3AN9399dXgdKGBjDW6FC6
lCgL15B/NosiHA2x3FJ+sA8OnypeeUwoZD+7ST5mJ98rIJ9Olf8agFxl9OtKd2N1O6FU
NABG5ujgHzQksmFo10/H4gpl4I6vkyj2Q18/KUHmxV2f5ueUyMI6O1rzm0yBazn21dPK
Yjt9a7JxP/QYb96FLsTWKb9uIolmBWHSZooGj+nPjQUCSDOr1IRi81JSqm1DGVGWS1pW
JG2ZK7zHKvyjDoVtdjmlCL3xotPdymaG4IAoHnrAYWH1738vGidNZrPJUfDBKlkCdMef XQ==
Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234])
by userp2120.oracle.com with ESMTP id 2g058p0454-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
Wed, 07 Feb 2018 17:02:23 +0000
Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235])
by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w17H2MMs014469
(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL);
Wed, 7 Feb 2018 17:02:22 GMT
Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14])
by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w17H2Kqg012829;
Wed, 7 Feb 2018 17:02:22 GMT
Received: from [10.159.158.96] (/10.159.158.96)
by default (Oracle Beehive Gateway v4.0)
with ESMTP ; Wed, 07 Feb 2018 09:02:20 -0800
Subject: Re: [net-next,06/15] i40e: change flags to use 64 bits
To: James Hogan <jhogan@kernel.org>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: davem@davemloft.net, Alice Michael <alice.michael@intel.com>,
netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
jogreene@redhat.com, Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org
References: <20180126212459.4246-7-jeffrey.t.kirsher@intel.com>
<20180207150907.GB5092@saruman>
From: Shannon Nelson <shannon.nelson@oracle.com>
Organization: Oracle Corporation
Message-ID: <e7c934d7-e5f4-ee1b-0647-c31a98d9e944@oracle.com>
Date: Wed, 7 Feb 2018 09:02:17 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <20180207150907.GB5092@saruman>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8798 signatures=668663
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0
phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=779
adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
engine=8.0.1-1711220000 definitions=main-1802070213
Return-Path: <shannon.nelson@oracle.com>
X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0)
X-Orcpt: rfc822;linux-mips@linux-mips.org
Original-Recipient: rfc822;linux-mips@linux-mips.org
X-archive-position: 62459
X-ecartis-version: Ecartis v1.0.0
Sender: linux-mips-bounce@linux-mips.org
Errors-to: linux-mips-bounce@linux-mips.org
X-original-sender: shannon.nelson@oracle.com
Precedence: bulk
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
List-software: Ecartis version 1.0.0
List-Id: linux-mips <linux-mips.eddie.linux-mips.org>
X-List-ID: linux-mips <linux-mips.eddie.linux-mips.org>
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
X-list: linux-mips
On 2/7/2018 7:09 AM, James Hogan wrote:
> On Fri, Jan 26, 2018 at 01:24:50PM -0800, Jeff Kirsher wrote:
>> From: Alice Michael <alice.michael@intel.com>
>>
>> As we have added more flags, we need to now use more
>> bits and have over flooded the 32 bit size. So
>> make it 64.
>>
>> Also change all the existing bits to unsigned long long
>> bits.
>>
>> Signed-off-by: Alice Michael <alice.michael@intel.com>
>> Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
>> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
>> ---
>> drivers/net/ethernet/intel/i40e/i40e.h | 67 +++++++++++++-------------
>> drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 4 +-
>> 2 files changed, 36 insertions(+), 35 deletions(-)
>
> ...
>
>> @@ -4323,7 +4323,7 @@ static int i40e_set_priv_flags(struct net_device *dev, u32 flags)
>> * originally. We'll just punt with an error and log something in the
>> * message buffer.
>> */
>> - if (cmpxchg(&pf->flags, orig_flags, new_flags) != orig_flags) {
>> + if (cmpxchg64(&pf->flags, orig_flags, new_flags) != orig_flags) {
>
> This breaks allyesconfig builds on certain architectures, for example
> MIPS 32-bit with SMP enabled, which doesn't support cmpxchg64:
>
> CC drivers/net/ethernet/intel/i40e/i40e_ethtool.o
> drivers/net/ethernet/intel/i40e/i40e_ethtool.c: In function ‘i40e_set_priv_flags’:
> drivers/net/ethernet/intel/i40e/i40e_ethtool.c:4326:6: error: implicit declaration of function ‘cmpxchg64’; did you mean ‘__cmpxchg’? [-Werror=implicit-function-declaration]
> if (cmpxchg64(&pf->flags, orig_flags, new_flags) != orig_flags) {
> ^~~~~~~~~
> __cmpxchg
>
> Should the driver now depend on 64BIT or something?
A long time ago this was the original expectation for this driver, but
it was strongly suggested that in order to play well in the kernel it
needed to be usable in 32-bit builds as well. I suspect this sentiment
remains, and besides we don't want to break existing support, so this
probably needs to be addressed for 32-bit.
sln
>
> Cheers
> James
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH 2/4] MIPS: generic: Fix ranchu_of_match[] termination
@ 2018-02-07 16:27 ` Aleksandar Markovic
0 siblings, 0 replies; 11+ messages in thread
From: Aleksandar Markovic @ 2018-02-07 16:27 UTC (permalink / raw)
To: James Hogan, Ralf Baechle, linux-mips; +Cc: Goran Ferenc, Miodrag Dinic
>
> ________________________________________
> From: James Hogan [jhogan@kernel.org]
> Sent: Friday, February 2, 2018 11:14 PM
> To: Ralf Baechle; linux-mips@linux-mips.org
> Cc: Aleksandar Markovic; Goran Ferenc; Miodrag Dinic; James Hogan
> Subject: [PATCH 2/4] MIPS: generic: Fix ranchu_of_match[] termination
>
> ranchu_of_match[] has no terminating element to end the search for a
> matching compatible string when the first and only element does not
> match, so add one now.
>
> Fixes: f2d0b0d5c171 ("MIPS: ranchu: Add Ranchu as a new generic-based board")
> Signed-off-by: James Hogan <jhogan@kernel.org>
> Reviewed-by: Paul Burton <paul.burton@mips.com>
> Reviewed-by: Matt Redfearn <matt.redfearn@mips.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Miodrag Dinic <miodrag.dinic@mips.com>
> Cc: Goran Ferenc <goran.ferenc@mips.com>
> Cc: Aleksandar Markovic <aleksandar.markovic@mips.com>
> Cc: linux-mips@linux-mips.org
> ---
> arch/mips/generic/board-ranchu.c | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Aleksandar Markovic <aleksandar.markovic@mips.com>
Acked-by: Miodrag Dinic <miodrag.dinic@mips.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH 3/4] MIPS: generic: Fix Makefile alignment
2018-02-02 22:14 ` [PATCH 3/4] MIPS: generic: Fix Makefile alignment James Hogan
@ 2018-02-07 16:27 ` Aleksandar Markovic
0 siblings, 0 replies; 11+ messages in thread
From: Aleksandar Markovic @ 2018-02-07 16:27 UTC (permalink / raw)
To: James Hogan, Ralf Baechle, linux-mips; +Cc: Goran Ferenc, Miodrag Dinic
>
> ________________________________________
> From: James Hogan [jhogan@kernel.org]
> Sent: Friday, February 2, 2018 11:14 PM
> To: Ralf Baechle; linux-mips@linux-mips.org
> Cc: Aleksandar Markovic; Goran Ferenc; Miodrag Dinic; James Hogan
> Subject: [PATCH 3/4] MIPS: generic: Fix Makefile alignment
>
> Fix whitespace of generic platform Makefile so that obj-y values align.
>
> Fixes: f2d0b0d5c171 ("MIPS: ranchu: Add Ranchu as a new generic-based board")
> Signed-off-by: James Hogan <jhogan@kernel.org>
> Reviewed-by: Paul Burton <paul.burton@mips.com>
> Reviewed-by: Matt Redfearn <matt.redfearn@mips.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Miodrag Dinic <miodrag.dinic@mips.com>
> Cc: Goran Ferenc <goran.ferenc@mips.com>
> Cc: Aleksandar Markovic <aleksandar.markovic@mips.com>
> Cc: linux-mips@linux-mips.org
> ---
> arch/mips/generic/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Aleksandar Markovic <aleksandar.markovic@mips.com>
Acked-by: Miodrag Dinic <miodrag.dinic@mips.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH 4/4] MIPS: generic: Don't claim PC parport/serio
@ 2018-02-07 16:27 ` Aleksandar Markovic
0 siblings, 0 replies; 11+ messages in thread
From: Aleksandar Markovic @ 2018-02-07 16:27 UTC (permalink / raw)
To: James Hogan, Ralf Baechle, linux-mips
Cc: Goran Ferenc, Miodrag Dinic, Paul Burton
>
> ________________________________________
> From: James Hogan [jhogan@kernel.org]
> Sent: Friday, February 2, 2018 11:14 PM
> To: Ralf Baechle; linux-mips@linux-mips.org
> Cc: Aleksandar Markovic; Goran Ferenc; Miodrag Dinic; James Hogan; Paul Burton
> Subject: [PATCH 4/4] MIPS: generic: Don't claim PC parport/serio
>
> None of the supported MIPS generic platforms can have the PC parallel
> port or PC serial port (and we don't yet have to be concerned with
> Malta which does), and enabling the PC serial driver will result in a
> panic from i8042_flush during boot. Therefore conditionalise the MIPS
> selection of ARCH_MIGHT_HAVE_PC_{PARPORT,SERIO} on !MIPS_GENERIC.
>
> This particularly matters since commit f2d0b0d5c171 ("MIPS: ranchu: Add
> Ranchu as a new generic-based board"), which adds a board fragment which
> enables INPUT_KEYBOARD. That implicitly enables KEYBOARD_ATKBD which
> then selects SERIO_I8042 if ARCH_MIGHT_HAVE_PC_SERIO.
>
> We can always select it from specific platforms later.
>
> Fixes: f2d0b0d5c171 ("MIPS: ranchu: Add Ranchu as a new generic-based board")
> Signed-off-by: James Hogan <jhogan@kernel.org>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Miodrag Dinic <miodrag.dinic@mips.com>
> Cc: Goran Ferenc <goran.ferenc@mips.com>
> Cc: Aleksandar Markovic <aleksandar.markovic@mips.com>
> Cc: Paul Burton <paul.burton@mips.com>
> Cc: linux-mips@linux-mips.org
> ---
> Does anybody actually know which MIPS platforms can have these PC
> devices?
> ---
> arch/mips/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Aleksandar Markovic <aleksandar.markovic@mips.com>
Acked-by: Miodrag Dinic <miodrag.dinic@mips.com>
From Aleksandar.Markovic@mips.com Wed Feb 7 17:44:09 2018
Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 07 Feb 2018 17:44:17 +0100 (CET)
Received: from 9pmail.ess.barracuda.com ([64.235.150.224]:52126 "EHLO
9pmail.ess.barracuda.com" rhost-flags-OK-OK-OK-OK)
by eddie.linux-mips.org with ESMTP id S23990400AbeBGQnoptfCV convert rfc822-to-8bit
(ORCPT <rfc822;linux-mips@linux-mips.org>);
Wed, 7 Feb 2018 17:43:44 +0100
Received: from MIPSMAIL01.mipstec.com (mailrelay.mips.com [12.201.5.28]) by mx2.ess.sfj.cudaops.com (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NO); Wed, 07 Feb 2018 16:43:34 +0000
Received: from MIPSMAIL01.mipstec.com ([fe80::5c93:1f20:524d:a563]) by
MIPSMAIL01.mipstec.com ([fe80::5c93:1f20:524d:a563%13]) with mapi id
14.03.0361.001; Wed, 7 Feb 2018 08:27:04 -0800
From: Aleksandar Markovic <Aleksandar.Markovic@mips.com>
To: James Hogan <jhogan@kernel.org>,
Ralf Baechle <ralf@linux-mips.org>,
"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>
CC: Goran Ferenc <Goran.Ferenc@mips.com>,
Miodrag Dinic <Miodrag.Dinic@mips.com>
Subject: RE: [PATCH 1/4] MIPS: generic: Fix machine compatible matching
Thread-Topic: [PATCH 1/4] MIPS: generic: Fix machine compatible matching
Thread-Index: AQHTnHNJz0FFGlj3gU6grt3S0Ed+KaOZI+5b
Date: Wed, 7 Feb 2018 16:27:03 +0000
Message-ID: <BD3A5F1946F2E540A31AF2CE969BAEEE2517B986@MIPSMAIL01.mipstec.com>
References: <cover.fcf1b08ac94759a5cd4b4303f350734b68872619.1517609353.git-series.jhogan@kernel.org>,<4d44540130007c278068ea4870e3c4efbd171ee6.1517609353.git-series.jhogan@kernel.org>
In-Reply-To: <4d44540130007c278068ea4870e3c4efbd171ee6.1517609353.git-series.jhogan@kernel.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [82.117.201.26]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-BESS-ID: 1518021805-298553-27713-4448-6
X-BESS-VER: 2018.1-r1801291959
X-BESS-Apparent-Source-IP: 12.201.5.28
X-BESS-Outbound-Spam-Score: 0.60
X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.189770
Rule breakdown below
pts rule name description
---- ---------------------- --------------------------------
0.00 BSF_BESS_OUTBOUND META: BESS Outbound
0.60 MARKETING_SUBJECT HEADER: Subject contains popular marketing words
X-BESS-Outbound-Spam-Status: SCORE=0.60 using account:ESS59374 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND, MARKETING_SUBJECT
X-BESS-BRTS-Status: 1
Return-Path: <Aleksandar.Markovic@mips.com>
X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0)
X-Orcpt: rfc822;linux-mips@linux-mips.org
Original-Recipient: rfc822;linux-mips@linux-mips.org
X-archive-position: 62456
X-ecartis-version: Ecartis v1.0.0
Sender: linux-mips-bounce@linux-mips.org
Errors-to: linux-mips-bounce@linux-mips.org
X-original-sender: Aleksandar.Markovic@mips.com
Precedence: bulk
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
List-software: Ecartis version 1.0.0
List-Id: linux-mips <linux-mips.eddie.linux-mips.org>
X-List-ID: linux-mips <linux-mips.eddie.linux-mips.org>
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
X-list: linux-mips
>
> ________________________________________
> From: James Hogan [jhogan@kernel.org]
> Sent: Friday, February 2, 2018 11:14 PM
> To: Ralf Baechle; linux-mips@linux-mips.org
> Cc: Aleksandar Markovic; Goran Ferenc; Miodrag Dinic; James Hogan
> Subject: [PATCH 1/4] MIPS: generic: Fix machine compatible matching
>
> We now have a platform (Ranchu) in the "generic" platform which matches
> based on the FDT compatible string using mips_machine_is_compatible(),
> however that function doesn't stop at a blank struct
> of_device_id::compatible as that is an array in the struct, not a
> pointer to a string.
>
> Fix the loop completion to check the first byte of the compatible array
> rather than the address of the compatible array in the struct.
>
> Fixes: eed0eabd12ef ("MIPS: generic: Introduce generic DT-based board support")
> Signed-off-by: James Hogan <jhogan@kernel.org>
> Reviewed-by: Paul Burton <paul.burton@mips.com>
> Reviewed-by: Matt Redfearn <matt.redfearn@mips.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: linux-mips@linux-mips.org
> ---
> arch/mips/include/asm/machine.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Aleksandar Markovic <aleksandar.markovic@mips.com>
Acked-by: Miodrag Dinic <miodrag.dinic@mips.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH 4/4] MIPS: generic: Don't claim PC parport/serio
@ 2018-02-07 16:27 ` Aleksandar Markovic
0 siblings, 0 replies; 11+ messages in thread
From: Aleksandar Markovic @ 2018-02-07 16:27 UTC (permalink / raw)
To: James Hogan, Ralf Baechle, linux-mips
Cc: Goran Ferenc, Miodrag Dinic, Paul Burton
>
> ________________________________________
> From: James Hogan [jhogan@kernel.org]
> Sent: Friday, February 2, 2018 11:14 PM
> To: Ralf Baechle; linux-mips@linux-mips.org
> Cc: Aleksandar Markovic; Goran Ferenc; Miodrag Dinic; James Hogan; Paul Burton
> Subject: [PATCH 4/4] MIPS: generic: Don't claim PC parport/serio
>
> None of the supported MIPS generic platforms can have the PC parallel
> port or PC serial port (and we don't yet have to be concerned with
> Malta which does), and enabling the PC serial driver will result in a
> panic from i8042_flush during boot. Therefore conditionalise the MIPS
> selection of ARCH_MIGHT_HAVE_PC_{PARPORT,SERIO} on !MIPS_GENERIC.
>
> This particularly matters since commit f2d0b0d5c171 ("MIPS: ranchu: Add
> Ranchu as a new generic-based board"), which adds a board fragment which
> enables INPUT_KEYBOARD. That implicitly enables KEYBOARD_ATKBD which
> then selects SERIO_I8042 if ARCH_MIGHT_HAVE_PC_SERIO.
>
> We can always select it from specific platforms later.
>
> Fixes: f2d0b0d5c171 ("MIPS: ranchu: Add Ranchu as a new generic-based board")
> Signed-off-by: James Hogan <jhogan@kernel.org>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: Miodrag Dinic <miodrag.dinic@mips.com>
> Cc: Goran Ferenc <goran.ferenc@mips.com>
> Cc: Aleksandar Markovic <aleksandar.markovic@mips.com>
> Cc: Paul Burton <paul.burton@mips.com>
> Cc: linux-mips@linux-mips.org
> ---
> Does anybody actually know which MIPS platforms can have these PC
> devices?
> ---
> arch/mips/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Aleksandar Markovic <aleksandar.markovic@mips.com>
Acked-by: Miodrag Dinic <miodrag.dinic@mips.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2018-02-07 16:44 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-02 22:14 [PATCH 0/4] MIPS: generic: Fixes for Ranchu platform James Hogan
2018-02-02 22:14 ` [PATCH 1/4] MIPS: generic: Fix machine compatible matching James Hogan
2018-02-07 16:27 ` Aleksandar Markovic
2018-02-02 22:14 ` [PATCH 2/4] MIPS: generic: Fix ranchu_of_match[] termination James Hogan
2018-02-07 16:27 ` Aleksandar Markovic
2018-02-07 16:27 ` Aleksandar Markovic
2018-02-02 22:14 ` [PATCH 3/4] MIPS: generic: Fix Makefile alignment James Hogan
2018-02-07 16:27 ` Aleksandar Markovic
2018-02-02 22:14 ` [PATCH 4/4] MIPS: generic: Don't claim PC parport/serio James Hogan
2018-02-07 16:27 ` Aleksandar Markovic
2018-02-07 16:27 ` Aleksandar Markovic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.