* [PATCH 0/2] mvebu-mbus: Adjustments for mvebu_devs_debug_show()
@ 2018-01-12 16:57 ` SF Markus Elfring
0 siblings, 0 replies; 6+ messages in thread
From: SF Markus Elfring @ 2018-01-12 16:57 UTC (permalink / raw)
To: kernel-janitors, Gregory Clement, Jan Lübbe; +Cc: LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 12 Jan 2018 17:47:57 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Use seq_putc()
Fix a typo in five comment lines
drivers/bus/mvebu-mbus.c | 21 ++++++++++-----------
1 file changed, 10 insertions(+), 11 deletions(-)
--
2.15.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 0/2] mvebu-mbus: Adjustments for mvebu_devs_debug_show()
@ 2018-01-12 16:57 ` SF Markus Elfring
0 siblings, 0 replies; 6+ messages in thread
From: SF Markus Elfring @ 2018-01-12 16:57 UTC (permalink / raw)
To: kernel-janitors, Gregory Clement, Jan Lübbe; +Cc: LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 12 Jan 2018 17:47:57 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Use seq_putc()
Fix a typo in five comment lines
drivers/bus/mvebu-mbus.c | 21 ++++++++++-----------
1 file changed, 10 insertions(+), 11 deletions(-)
--
2.15.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] mvebu-mbus: Use seq_putc() in mvebu_devs_debug_show()
2018-01-12 16:57 ` SF Markus Elfring
@ 2018-01-12 16:58 ` SF Markus Elfring
-1 siblings, 0 replies; 6+ messages in thread
From: SF Markus Elfring @ 2018-01-12 16:58 UTC (permalink / raw)
To: kernel-janitors, Gregory Clement, Jan Lübbe; +Cc: LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 12 Jan 2018 17:12:14 +0100
A single character (line break) should be put into a sequence.
Thus use the corresponding function "seq_putc".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/bus/mvebu-mbus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/mvebu-mbus.c b/drivers/bus/mvebu-mbus.c
index 70db4d5638a6..5844901aea0b 100644
--- a/drivers/bus/mvebu-mbus.c
+++ b/drivers/bus/mvebu-mbus.c
@@ -514,7 +514,7 @@ static int mvebu_devs_debug_show(struct seq_file *seq, void *v)
seq_printf(seq, " (remap %016llx)\n",
(unsigned long long)wremap);
} else
- seq_printf(seq, "\n");
+ seq_putc(seq, '\n');
}
return 0;
--
2.15.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 1/2] mvebu-mbus: Use seq_putc() in mvebu_devs_debug_show()
@ 2018-01-12 16:58 ` SF Markus Elfring
0 siblings, 0 replies; 6+ messages in thread
From: SF Markus Elfring @ 2018-01-12 16:58 UTC (permalink / raw)
To: kernel-janitors, Gregory Clement, Jan Lübbe; +Cc: LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 12 Jan 2018 17:12:14 +0100
A single character (line break) should be put into a sequence.
Thus use the corresponding function "seq_putc".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/bus/mvebu-mbus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/mvebu-mbus.c b/drivers/bus/mvebu-mbus.c
index 70db4d5638a6..5844901aea0b 100644
--- a/drivers/bus/mvebu-mbus.c
+++ b/drivers/bus/mvebu-mbus.c
@@ -514,7 +514,7 @@ static int mvebu_devs_debug_show(struct seq_file *seq, void *v)
seq_printf(seq, " (remap %016llx)\n",
(unsigned long long)wremap);
} else
- seq_printf(seq, "\n");
+ seq_putc(seq, '\n');
}
return 0;
--
2.15.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] mvebu-mbus: Fix a typo in five comment lines
2018-01-12 16:57 ` SF Markus Elfring
@ 2018-01-12 17:00 ` SF Markus Elfring
-1 siblings, 0 replies; 6+ messages in thread
From: SF Markus Elfring @ 2018-01-12 17:00 UTC (permalink / raw)
To: kernel-janitors, Gregory Clement, Jan Lübbe; +Cc: LKML, trivial
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 12 Jan 2018 17:44:48 +0100
Adjust words in these descriptions.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/bus/mvebu-mbus.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/bus/mvebu-mbus.c b/drivers/bus/mvebu-mbus.c
index 5844901aea0b..e0c1b07108a6 100644
--- a/drivers/bus/mvebu-mbus.c
+++ b/drivers/bus/mvebu-mbus.c
@@ -23,15 +23,14 @@
*
* This driver:
*
- * - Reads out the SDRAM address decoding windows at initialization
- * time, and fills the mvebu_mbus_dram_info structure with these
- * informations. The exported function mv_mbus_dram_info() allow
- * device drivers to get those informations related to the SDRAM
- * address decoding windows. This is because devices also have their
- * own windows (configured through registers that are part of each
- * device register space), and therefore the drivers for Marvell
- * devices have to configure those device -> SDRAM windows to ensure
- * that DMA works properly.
+ * - Reads out the SDRAM address decoding windows at initialization time,
+ * and fills the mvebu_mbus_dram_info structure with this information.
+ * The exported function mv_mbus_dram_info() allows device drivers to get
+ * this information related to the SDRAM address decoding windows.
+ * This is because devices also have their own windows (configured through
+ * registers that are part of each device register space), and therefore
+ * the drivers for Marvell devices have to configure those device
+ * -> SDRAM windows to ensure that DMA works properly.
*
* - Provides an API for platform code or device drivers to
* dynamically add or remove address decoding windows for the CPU ->
@@ -123,7 +122,7 @@ struct mvebu_mbus_soc_data {
};
/*
- * Used to store the state of one MBus window accross suspend/resume.
+ * Used to store the state of one MBus window across suspend/resume.
*/
struct mvebu_mbus_win_data {
u32 ctrl;
--
2.15.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] mvebu-mbus: Fix a typo in five comment lines
@ 2018-01-12 17:00 ` SF Markus Elfring
0 siblings, 0 replies; 6+ messages in thread
From: SF Markus Elfring @ 2018-01-12 17:00 UTC (permalink / raw)
To: kernel-janitors, Gregory Clement, Jan Lübbe; +Cc: LKML, trivial
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 12 Jan 2018 17:44:48 +0100
Adjust words in these descriptions.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/bus/mvebu-mbus.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/bus/mvebu-mbus.c b/drivers/bus/mvebu-mbus.c
index 5844901aea0b..e0c1b07108a6 100644
--- a/drivers/bus/mvebu-mbus.c
+++ b/drivers/bus/mvebu-mbus.c
@@ -23,15 +23,14 @@
*
* This driver:
*
- * - Reads out the SDRAM address decoding windows at initialization
- * time, and fills the mvebu_mbus_dram_info structure with these
- * informations. The exported function mv_mbus_dram_info() allow
- * device drivers to get those informations related to the SDRAM
- * address decoding windows. This is because devices also have their
- * own windows (configured through registers that are part of each
- * device register space), and therefore the drivers for Marvell
- * devices have to configure those device -> SDRAM windows to ensure
- * that DMA works properly.
+ * - Reads out the SDRAM address decoding windows at initialization time,
+ * and fills the mvebu_mbus_dram_info structure with this information.
+ * The exported function mv_mbus_dram_info() allows device drivers to get
+ * this information related to the SDRAM address decoding windows.
+ * This is because devices also have their own windows (configured through
+ * registers that are part of each device register space), and therefore
+ * the drivers for Marvell devices have to configure those device
+ * -> SDRAM windows to ensure that DMA works properly.
*
* - Provides an API for platform code or device drivers to
* dynamically add or remove address decoding windows for the CPU ->
@@ -123,7 +122,7 @@ struct mvebu_mbus_soc_data {
};
/*
- * Used to store the state of one MBus window accross suspend/resume.
+ * Used to store the state of one MBus window across suspend/resume.
*/
struct mvebu_mbus_win_data {
u32 ctrl;
--
2.15.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-01-12 17:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-12 16:57 [PATCH 0/2] mvebu-mbus: Adjustments for mvebu_devs_debug_show() SF Markus Elfring
2018-01-12 16:57 ` SF Markus Elfring
2018-01-12 16:58 ` [PATCH 1/2] mvebu-mbus: Use seq_putc() in mvebu_devs_debug_show() SF Markus Elfring
2018-01-12 16:58 ` SF Markus Elfring
2018-01-12 17:00 ` [PATCH 2/2] mvebu-mbus: Fix a typo in five comment lines SF Markus Elfring
2018-01-12 17:00 ` SF Markus Elfring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.