All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
To: "Linus Lüssing" <linus.luessing@c0d3.blue>
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
	wkok@cumulusnetworks.com, anuradhak@cumulusnetworks.com,
	bridge@lists.linux-foundation.org, davem@davemloft.net,
	stephen@networkplumber.org
Subject: Re: [PATCH RFC] net: bridge: don't flood known multicast traffic when snooping is enabled
Date: Sat, 16 Feb 2019 10:05:40 +0200	[thread overview]
Message-ID: <479a1acf-c7f3-4e6f-4246-e1583e98d356@cumulusnetworks.com> (raw)
In-Reply-To: <20190215171332.GA1472@otheros>

On 15/02/2019 19:13, Linus Lüssing wrote:
> On Fri, Feb 15, 2019 at 03:04:27PM +0200, Nikolay Aleksandrov wrote:
>> Every user would expect to have traffic forwarded only to the configured
>> mdb destination when snooping is enabled, instead now to get that one
>> needs to enable both snooping and querier. Enabling querier on all
>> switches could be problematic and is not a good solution,
> 
> There is no need to set the querier on all snooping switches.
> br_multicast_querier_exists() checks if a querier exists on the
> link in general, not if this particular host/bridge is a querier.
> 

We need a generic solution for the case of existing mdst and no querier.
More below.

> 
>> for example as summarized by our multicast experts:
>> "every switch would send an IGMP query
> 
> What? RFC3810, section 7.1 says:
> 
> "If it is the case, a querier election mechanism (described in
>  section 7.6.2) is used to elect a single multicast router to be
>  in Querier state. [...] Nevertheless, it is only the [elected] Querier
>  that sends periodical or triggered query messages on the subnet."
> >> for any random multicast traffic it
>> received across the entire domain and it would send it forever as long as a
>> host exists wanting that stream even if it has no downstream/directly
>> connected receivers"
> 

This was taken out of context and it's my bad, I think everyone is aware
of the election process, please nevermind the above statement.

[snip]> 
> 
> Have you done some tests with this change yet, Nikolay?
> 

You've raised good questions, IPv6 indeed needs more work - we'll have to flood
link-local packets etc. but I wanted to have a discussion about no querier/existing mdst.
To simplify we can modify the patch and have traffic forwarded to the proper ports when an
mdst exists and there is no querier for both unsolicited report and user-added entry.
We can keep the current behaviour for unknown traffic with and without querier.
This would align it closer to what other vendors currently do as well IIRC.
What do you think ?

Thanks,
 Nik

WARNING: multiple messages have this Message-ID (diff)
From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
To: "Linus Lüssing" <linus.luessing@c0d3.blue>
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
	bridge@lists.linux-foundation.org, wkok@cumulusnetworks.com,
	anuradhak@cumulusnetworks.com, davem@davemloft.net
Subject: Re: [Bridge] [PATCH RFC] net: bridge: don't flood known multicast traffic when snooping is enabled
Date: Sat, 16 Feb 2019 10:05:40 +0200	[thread overview]
Message-ID: <479a1acf-c7f3-4e6f-4246-e1583e98d356@cumulusnetworks.com> (raw)
In-Reply-To: <20190215171332.GA1472@otheros>

On 15/02/2019 19:13, Linus Lüssing wrote:
> On Fri, Feb 15, 2019 at 03:04:27PM +0200, Nikolay Aleksandrov wrote:
>> Every user would expect to have traffic forwarded only to the configured
>> mdb destination when snooping is enabled, instead now to get that one
>> needs to enable both snooping and querier. Enabling querier on all
>> switches could be problematic and is not a good solution,
> 
> There is no need to set the querier on all snooping switches.
> br_multicast_querier_exists() checks if a querier exists on the
> link in general, not if this particular host/bridge is a querier.
> 

We need a generic solution for the case of existing mdst and no querier.
More below.

> 
>> for example as summarized by our multicast experts:
>> "every switch would send an IGMP query
> 
> What? RFC3810, section 7.1 says:
> 
> "If it is the case, a querier election mechanism (described in
>  section 7.6.2) is used to elect a single multicast router to be
>  in Querier state. [...] Nevertheless, it is only the [elected] Querier
>  that sends periodical or triggered query messages on the subnet."
> >> for any random multicast traffic it
>> received across the entire domain and it would send it forever as long as a
>> host exists wanting that stream even if it has no downstream/directly
>> connected receivers"
> 

This was taken out of context and it's my bad, I think everyone is aware
of the election process, please nevermind the above statement.

[snip]> 
> 
> Have you done some tests with this change yet, Nikolay?
> 

You've raised good questions, IPv6 indeed needs more work - we'll have to flood
link-local packets etc. but I wanted to have a discussion about no querier/existing mdst.
To simplify we can modify the patch and have traffic forwarded to the proper ports when an
mdst exists and there is no querier for both unsolicited report and user-added entry.
We can keep the current behaviour for unknown traffic with and without querier.
This would align it closer to what other vendors currently do as well IIRC.
What do you think ?

Thanks,
 Nik

  reply	other threads:[~2019-02-16  8:05 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-15 13:04 [PATCH RFC] net: bridge: don't flood known multicast traffic when snooping is enabled Nikolay Aleksandrov
2019-02-15 13:04 ` [Bridge] " Nikolay Aleksandrov
2019-02-15 13:09 ` Nikolay Aleksandrov
2019-02-15 13:09   ` [Bridge] " Nikolay Aleksandrov
2019-02-15 13:53 ` Ido Schimmel
2019-02-15 13:53   ` [Bridge] " Ido Schimmel
2019-02-15 17:13 ` Linus Lüssing
2019-02-15 17:13   ` [Bridge] " Linus Lüssing
2019-02-16  8:05   ` Nikolay Aleksandrov [this message]
2019-02-16  8:05     ` Nikolay Aleksandrov
2019-02-16  8:35     ` Nikolay Aleksandrov
2019-02-16  8:35       ` [Bridge] " Nikolay Aleksandrov
2019-02-16 20:04       ` Linus Lüssing
2019-02-16 20:04         ` [Bridge] " Linus Lüssing
2019-02-16 18:43     ` Ido Schimmel
2019-02-16 18:43       ` [Bridge] " Ido Schimmel
2019-02-16 19:15       ` nikolay
2019-02-16 19:15         ` [Bridge] " nikolay
2019-02-16 19:27         ` nikolay
2019-02-16 19:27           ` [Bridge] " nikolay
2019-02-16 20:37           ` Linus Lüssing
2019-02-16 20:37             ` [Bridge] " Linus Lüssing
2019-02-17  3:05 ` Florian Fainelli
2019-02-17  3:05   ` [Bridge] " Florian Fainelli
2019-02-17 10:58   ` Nikolay Aleksandrov
2019-02-17 10:58     ` [Bridge] " Nikolay Aleksandrov
2019-02-18  2:15 ` [net] 5c261115ce: hwsim.ap_vlan_without_station.fail kernel test robot
2019-02-18  2:15   ` [Bridge] [LKP] " kernel test robot
2019-02-18 12:21 ` [RFC v2] net: bridge: don't flood known multicast traffic when snooping is enabled Nikolay Aleksandrov
2019-02-18 12:21   ` [Bridge] " Nikolay Aleksandrov
2019-02-19  8:53   ` Ido Schimmel
2019-02-19  8:53     ` [Bridge] " Ido Schimmel
2019-02-19  8:57   ` Linus Lüssing
2019-02-19  8:57     ` [Bridge] " Linus Lüssing
2019-02-19  9:21     ` Linus Lüssing
2019-02-19  9:21       ` Linus Lüssing
2019-02-19 13:31       ` Nikolay Aleksandrov
2019-02-19 13:31         ` Nikolay Aleksandrov
2019-02-19 15:42         ` Linus Lüssing
2019-02-19 15:42           ` Linus Lüssing
2019-02-19 17:26           ` Nikolay Aleksandrov
2019-02-19 17:26             ` Nikolay Aleksandrov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=479a1acf-c7f3-4e6f-4246-e1583e98d356@cumulusnetworks.com \
    --to=nikolay@cumulusnetworks.com \
    --cc=anuradhak@cumulusnetworks.com \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=linus.luessing@c0d3.blue \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    --cc=stephen@networkplumber.org \
    --cc=wkok@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.