All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH libdrm] amdgpu: Use the canonical form in branch predicate
@ 2017-04-22  6:47 Edward O'Callaghan
       [not found] ` <20170422064740.2491-1-funfunctor-dczkZgxz+BNUPWh3PAxdjQ@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Edward O'Callaghan @ 2017-04-22  6:47 UTC (permalink / raw)
  To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
  Cc: emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w

Suggested-by: Emil Velikov <emil.l.velikov@gmail.com>
Signed-off-by: Edward O'Callaghan <funfunctor@folklore1984.net>
---
 amdgpu/amdgpu_cs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/amdgpu/amdgpu_cs.c b/amdgpu/amdgpu_cs.c
index 0993a6d..868eb7b 100644
--- a/amdgpu/amdgpu_cs.c
+++ b/amdgpu/amdgpu_cs.c
@@ -559,7 +559,7 @@ int amdgpu_cs_wait_semaphore(amdgpu_context_handle ctx,
 	if (ring >= AMDGPU_CS_MAX_RINGS)
 		return -EINVAL;
 	/* must signal first */
-	if (NULL == sem->signal_fence.context)
+	if (!sem->signal_fence.context)
 		return -EINVAL;
 
 	pthread_mutex_lock(&ctx->sequence_mutex);
-- 
2.9.3

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH libdrm] amdgpu: Use the canonical form in branch predicate
       [not found] ` <20170422064740.2491-1-funfunctor-dczkZgxz+BNUPWh3PAxdjQ@public.gmane.org>
@ 2017-04-24  9:52   ` Emil Velikov
  2017-04-24 12:36   ` Nicolai Hähnle
  1 sibling, 0 replies; 3+ messages in thread
From: Emil Velikov @ 2017-04-24  9:52 UTC (permalink / raw)
  To: Edward O'Callaghan; +Cc: amd-gfx mailing list

On 22 April 2017 at 07:47, Edward O'Callaghan
<funfunctor@folklore1984.net> wrote:
> Suggested-by: Emil Velikov <emil.l.velikov@gmail.com>
> Signed-off-by: Edward O'Callaghan <funfunctor@folklore1984.net>
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>

Thanks
Emil
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH libdrm] amdgpu: Use the canonical form in branch predicate
       [not found] ` <20170422064740.2491-1-funfunctor-dczkZgxz+BNUPWh3PAxdjQ@public.gmane.org>
  2017-04-24  9:52   ` Emil Velikov
@ 2017-04-24 12:36   ` Nicolai Hähnle
  1 sibling, 0 replies; 3+ messages in thread
From: Nicolai Hähnle @ 2017-04-24 12:36 UTC (permalink / raw)
  To: Edward O'Callaghan, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
  Cc: emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w

On 22.04.2017 08:47, Edward O'Callaghan wrote:
> Suggested-by: Emil Velikov <emil.l.velikov@gmail.com>
> Signed-off-by: Edward O'Callaghan <funfunctor@folklore1984.net>

Reviewed-by: Nicolai Hähnle <nicolai.haehnle@amd.com>

> ---
>  amdgpu/amdgpu_cs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/amdgpu/amdgpu_cs.c b/amdgpu/amdgpu_cs.c
> index 0993a6d..868eb7b 100644
> --- a/amdgpu/amdgpu_cs.c
> +++ b/amdgpu/amdgpu_cs.c
> @@ -559,7 +559,7 @@ int amdgpu_cs_wait_semaphore(amdgpu_context_handle ctx,
>  	if (ring >= AMDGPU_CS_MAX_RINGS)
>  		return -EINVAL;
>  	/* must signal first */
> -	if (NULL == sem->signal_fence.context)
> +	if (!sem->signal_fence.context)
>  		return -EINVAL;
>
>  	pthread_mutex_lock(&ctx->sequence_mutex);
>


-- 
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-04-24 12:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-22  6:47 [PATCH libdrm] amdgpu: Use the canonical form in branch predicate Edward O'Callaghan
     [not found] ` <20170422064740.2491-1-funfunctor-dczkZgxz+BNUPWh3PAxdjQ@public.gmane.org>
2017-04-24  9:52   ` Emil Velikov
2017-04-24 12:36   ` Nicolai Hähnle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.