From: Jason Wang <jasowang@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org, kwankhede@nvidia.com,
mst@redhat.com, tiwei.bie@intel.com,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, cohuck@redhat.com,
maxime.coquelin@redhat.com, cunming.liang@intel.com,
zhihong.wang@intel.com, rob.miller@broadcom.com,
xiao.w.wang@intel.com, haotian.wang@sifive.com,
zhenyuw@linux.intel.com, zhi.a.wang@intel.com,
jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
rodrigo.vivi@intel.com, airlied@linux.ie, daniel@ffwll.ch,
farman@linux.ibm.com, pasic@linux.ibm.com, sebott@linux.ibm.com,
oberpar@linux.ibm.com, heiko.carstens@de.ibm.com,
gor@linux.ibm.com, borntraeger@de.ibm.com,
akrowiak@linux.ibm.com, freude@linux.ibm.com,
lingshan.zhu@intel.com, idos@mellanox.com, eperezma@redhat.com,
lulu@redhat.com, parav@mellanox.com,
christophe.de.dinechin@gmail.com, kevin.tian@intel.com,
stefanha@redhat.com
Subject: Re: [PATCH V7 3/6] mdev: introduce device specific ops
Date: Tue, 5 Nov 2019 11:17:28 +0800 [thread overview]
Message-ID: <47ecfe09-0954-9517-3ac5-68db8522826d@redhat.com> (raw)
In-Reply-To: <20191104145008.4b6839f0@x1.home>
On 2019/11/5 上午5:50, Alex Williamson wrote:
>> EXPORT_SYMBOL(mdev_set_drvdata);
>>
>> +
> Extra whitespace
>
>> /* Specify the class for the mdev device, this must be called during
>> - * create() callback.
>> - */
>> + * create() callback explicitly or implicity through the helpers
> s/implicity/implicitly/
>
>> + * provided by each class. */
>> void mdev_set_class(struct mdev_device *mdev, u16 id)
>> {
>> WARN_ON(mdev->class_id);
>> @@ -55,6 +56,26 @@ void mdev_set_class(struct mdev_device *mdev, u16 id)
>> }
>> EXPORT_SYMBOL(mdev_set_class);
>>
>> +/* Specify the mdev device to be a VFIO mdev device, and set VFIO
>> + * device ops for it. This must be called from the create() callback
>> + * for VFIO mdev device.
>> + */
> Comment style. Thanks,
Will fix them all.
Thanks
>
> Alex
>
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org, kwankhede@nvidia.com,
mst@redhat.com, tiwei.bie@intel.com,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, cohuck@redhat.com,
maxime.coquelin@redhat.com, cunming.liang@intel.com,
zhihong.wang@intel.com, rob.miller@broadcom.com,
xiao.w.wang@intel.com, haotian.wang@sifive.com,
zhenyuw@linux.intel.com, zhi.a.wang@intel.com,
jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
rodrigo.vivi@intel.com, airlied@linux.ie, daniel@ffwll.ch,
farman@linux.ibm.com, pasic@linux.ibm.com, sebott@linux.ibm.com,
oberpar@linux.ibm.com, heiko.carstens@de.ibm.com,
gor@linux.ibm.com
Subject: Re: [PATCH V7 3/6] mdev: introduce device specific ops
Date: Tue, 5 Nov 2019 11:17:28 +0800 [thread overview]
Message-ID: <47ecfe09-0954-9517-3ac5-68db8522826d@redhat.com> (raw)
In-Reply-To: <20191104145008.4b6839f0@x1.home>
On 2019/11/5 上午5:50, Alex Williamson wrote:
>> EXPORT_SYMBOL(mdev_set_drvdata);
>>
>> +
> Extra whitespace
>
>> /* Specify the class for the mdev device, this must be called during
>> - * create() callback.
>> - */
>> + * create() callback explicitly or implicity through the helpers
> s/implicity/implicitly/
>
>> + * provided by each class. */
>> void mdev_set_class(struct mdev_device *mdev, u16 id)
>> {
>> WARN_ON(mdev->class_id);
>> @@ -55,6 +56,26 @@ void mdev_set_class(struct mdev_device *mdev, u16 id)
>> }
>> EXPORT_SYMBOL(mdev_set_class);
>>
>> +/* Specify the mdev device to be a VFIO mdev device, and set VFIO
>> + * device ops for it. This must be called from the create() callback
>> + * for VFIO mdev device.
>> + */
> Comment style. Thanks,
Will fix them all.
Thanks
>
> Alex
>
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: stefanha@redhat.com, christophe.de.dinechin@gmail.com,
kvm@vger.kernel.org, mst@redhat.com, airlied@linux.ie,
heiko.carstens@de.ibm.com, kevin.tian@intel.com,
dri-devel@lists.freedesktop.org,
virtualization@lists.linux-foundation.org, kwankhede@nvidia.com,
rob.miller@broadcom.com, linux-s390@vger.kernel.org,
sebott@linux.ibm.com, lulu@redhat.com, eperezma@redhat.com,
pasic@linux.ibm.com, borntraeger@de.ibm.com,
haotian.wang@sifive.com, cunming.liang@intel.com,
zhi.a.wang@intel.com, farman@linux.ibm.com, idos@mellanox.com,
gor@linux.ibm.com, intel-gfx@lists.freedesktop.org,
rodrigo.vivi@intel.com, xiao.w.wang@intel.com,
freude@linux.ibm.com, parav@mellanox.com, zhihong.wang@intel.com,
intel-gvt-dev@lists.freedesktop.org, akrowiak@linux.ibm.com,
oberpar@linux.ibm.com, tiwei.bie@intel.com,
netdev@vger.kernel.org, cohuck@redhat.com,
linux-kernel@vger.kernel.org, maxime.coquelin@redhat.com,
lingshan.zhu@intel.com
Subject: Re: [PATCH V7 3/6] mdev: introduce device specific ops
Date: Tue, 5 Nov 2019 11:17:28 +0800 [thread overview]
Message-ID: <47ecfe09-0954-9517-3ac5-68db8522826d@redhat.com> (raw)
Message-ID: <20191105031728.-OCcoXucv6XbaGz939BXjDhx_Ln8Scq3XBOq2ilj_Tw@z> (raw)
In-Reply-To: <20191104145008.4b6839f0@x1.home>
On 2019/11/5 上午5:50, Alex Williamson wrote:
>> EXPORT_SYMBOL(mdev_set_drvdata);
>>
>> +
> Extra whitespace
>
>> /* Specify the class for the mdev device, this must be called during
>> - * create() callback.
>> - */
>> + * create() callback explicitly or implicity through the helpers
> s/implicity/implicitly/
>
>> + * provided by each class. */
>> void mdev_set_class(struct mdev_device *mdev, u16 id)
>> {
>> WARN_ON(mdev->class_id);
>> @@ -55,6 +56,26 @@ void mdev_set_class(struct mdev_device *mdev, u16 id)
>> }
>> EXPORT_SYMBOL(mdev_set_class);
>>
>> +/* Specify the mdev device to be a VFIO mdev device, and set VFIO
>> + * device ops for it. This must be called from the create() callback
>> + * for VFIO mdev device.
>> + */
> Comment style. Thanks,
Will fix them all.
Thanks
>
> Alex
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: stefanha@redhat.com, christophe.de.dinechin@gmail.com,
kvm@vger.kernel.org, mst@redhat.com, airlied@linux.ie,
heiko.carstens@de.ibm.com, dri-devel@lists.freedesktop.org,
virtualization@lists.linux-foundation.org, kwankhede@nvidia.com,
rob.miller@broadcom.com, linux-s390@vger.kernel.org,
sebott@linux.ibm.com, lulu@redhat.com, eperezma@redhat.com,
pasic@linux.ibm.com, borntraeger@de.ibm.com,
haotian.wang@sifive.com, cunming.liang@intel.com,
farman@linux.ibm.com, idos@mellanox.com, gor@linux.ibm.com,
intel-gfx@lists.freedesktop.org, xiao.w.wang@intel.com,
freude@linux.ibm.com, parav@mellanox.com, zhihong.wang@intel.com,
intel-gvt-dev@lists.freedesktop.org, akrowiak@linux.ibm.com,
oberpar@linux.ibm.com, tiwei.bie@intel.com,
netdev@vger.kernel.org, cohuck@redhat.com,
linux-kernel@vger.kernel.org, maxime.coquelin@redhat.com,
lingshan.zhu@intel.com
Subject: Re: [Intel-gfx] [PATCH V7 3/6] mdev: introduce device specific ops
Date: Tue, 5 Nov 2019 11:17:28 +0800 [thread overview]
Message-ID: <47ecfe09-0954-9517-3ac5-68db8522826d@redhat.com> (raw)
Message-ID: <20191105031728.TvNtFeK8lEu_QChh2VMn41VpVMK30GjbX1edlRCQX_I@z> (raw)
In-Reply-To: <20191104145008.4b6839f0@x1.home>
On 2019/11/5 上午5:50, Alex Williamson wrote:
>> EXPORT_SYMBOL(mdev_set_drvdata);
>>
>> +
> Extra whitespace
>
>> /* Specify the class for the mdev device, this must be called during
>> - * create() callback.
>> - */
>> + * create() callback explicitly or implicity through the helpers
> s/implicity/implicitly/
>
>> + * provided by each class. */
>> void mdev_set_class(struct mdev_device *mdev, u16 id)
>> {
>> WARN_ON(mdev->class_id);
>> @@ -55,6 +56,26 @@ void mdev_set_class(struct mdev_device *mdev, u16 id)
>> }
>> EXPORT_SYMBOL(mdev_set_class);
>>
>> +/* Specify the mdev device to be a VFIO mdev device, and set VFIO
>> + * device ops for it. This must be called from the create() callback
>> + * for VFIO mdev device.
>> + */
> Comment style. Thanks,
Will fix them all.
Thanks
>
> Alex
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-11-05 3:19 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 12:39 [PATCH V7 0/6] mdev based hardware virtio offloading support Jason Wang
2019-11-04 12:39 ` [Intel-gfx] " Jason Wang
2019-11-04 12:39 ` Jason Wang
2019-11-04 12:39 ` [PATCH V7 1/6] mdev: class id support Jason Wang
2019-11-04 12:39 ` [Intel-gfx] " Jason Wang
2019-11-04 12:39 ` Jason Wang
2019-11-04 12:39 ` Jason Wang
2019-11-04 21:50 ` Alex Williamson
2019-11-04 21:50 ` Alex Williamson
2019-11-04 21:50 ` [Intel-gfx] " Alex Williamson
2019-11-04 21:50 ` Alex Williamson
2019-11-04 21:50 ` Alex Williamson
2019-11-05 3:16 ` Jason Wang
2019-11-05 3:16 ` Jason Wang
2019-11-05 3:16 ` [Intel-gfx] " Jason Wang
2019-11-05 3:16 ` Jason Wang
2019-11-05 3:16 ` Jason Wang
2019-11-04 12:39 ` Jason Wang
2019-11-04 12:39 ` [PATCH V7 2/6] modpost: add support for mdev class id Jason Wang
2019-11-04 12:39 ` Jason Wang
2019-11-04 12:39 ` [Intel-gfx] " Jason Wang
2019-11-04 12:39 ` Jason Wang
2019-11-04 12:39 ` Jason Wang
2019-11-04 12:39 ` [PATCH V7 3/6] mdev: introduce device specific ops Jason Wang
2019-11-04 12:39 ` Jason Wang
2019-11-04 12:39 ` Jason Wang
2019-11-04 21:50 ` Alex Williamson
2019-11-04 21:50 ` Alex Williamson
2019-11-04 21:50 ` [Intel-gfx] " Alex Williamson
2019-11-04 21:50 ` Alex Williamson
2019-11-04 21:50 ` Alex Williamson
2019-11-05 3:17 ` Jason Wang [this message]
2019-11-05 3:17 ` [Intel-gfx] " Jason Wang
2019-11-05 3:17 ` Jason Wang
2019-11-05 3:17 ` Jason Wang
2019-11-05 3:17 ` Jason Wang
2019-11-04 12:39 ` [PATCH V7 4/6] mdev: introduce virtio device and its device ops Jason Wang
2019-11-04 12:39 ` Jason Wang
2019-11-04 12:39 ` Jason Wang
2019-11-04 21:50 ` Alex Williamson
2019-11-04 21:50 ` [Intel-gfx] " Alex Williamson
2019-11-04 21:50 ` Alex Williamson
2019-11-04 21:50 ` Alex Williamson
2019-11-05 3:52 ` Jason Wang
2019-11-05 3:52 ` [Intel-gfx] " Jason Wang
2019-11-05 3:52 ` Jason Wang
2019-11-05 3:52 ` Jason Wang
2019-11-05 4:39 ` Alex Williamson
2019-11-05 4:39 ` [Intel-gfx] " Alex Williamson
2019-11-05 4:39 ` Alex Williamson
2019-11-05 4:39 ` Alex Williamson
2019-11-05 5:22 ` Jason Wang
2019-11-05 5:22 ` [Intel-gfx] " Jason Wang
2019-11-05 5:22 ` Jason Wang
2019-11-05 5:22 ` Jason Wang
2019-11-05 5:22 ` Jason Wang
2019-11-05 4:39 ` Alex Williamson
2019-11-05 3:52 ` Jason Wang
2019-11-04 21:50 ` Alex Williamson
2019-11-04 12:39 ` [PATCH V7 5/6] virtio: introduce a mdev based transport Jason Wang
2019-11-04 12:39 ` [Intel-gfx] " Jason Wang
2019-11-04 12:39 ` Jason Wang
2019-11-04 12:39 ` Jason Wang
2019-11-04 12:39 ` [PATCH V7 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework Jason Wang
2019-11-04 12:39 ` Jason Wang
2019-11-04 12:39 ` [Intel-gfx] " Jason Wang
2019-11-04 12:39 ` Jason Wang
2019-11-04 12:39 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47ecfe09-0954-9517-3ac5-68db8522826d@redhat.com \
--to=jasowang@redhat.com \
--cc=airlied@linux.ie \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=christophe.de.dinechin@gmail.com \
--cc=cohuck@redhat.com \
--cc=cunming.liang@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=eperezma@redhat.com \
--cc=farman@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=haotian.wang@sifive.com \
--cc=heiko.carstens@de.ibm.com \
--cc=idos@mellanox.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=lingshan.zhu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=oberpar@linux.ibm.com \
--cc=parav@mellanox.com \
--cc=pasic@linux.ibm.com \
--cc=rob.miller@broadcom.com \
--cc=rodrigo.vivi@intel.com \
--cc=sebott@linux.ibm.com \
--cc=stefanha@redhat.com \
--cc=tiwei.bie@intel.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xiao.w.wang@intel.com \
--cc=zhenyuw@linux.intel.com \
--cc=zhi.a.wang@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.